SBNavigationObserverBrowserTest.SubFrameNewTabDownload is flaky |
||||||||
Issue description
This test occasionally flakes on Win10 and other platforms, like so:
[ RUN ] SBNavigationObserverBrowserTest.SubFrameNewTabDownload
[2696:3520:0706/054753.830:WARNING:chrome_browser_main_win.cc(469)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --enable-browser-side-navigation --gtest_also_run_disabled_tests --gtest_filter=SBNavigationObserverBrowserTest.SubFrameNewTabDownload --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\s\w\ioyqkdfl\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir112_5025\d112_21164" --disable-offline-auto-reload --disable-features=NetworkPrediction --no-first-run --no-default-browser-check --enable-logging=stderr --log-level=0 --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[2696:6464:0706/054754.833:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
c:\b\c\b\win\src\chrome\browser\safe_browsing\safe_browsing_navigation_observer_browsertest.cc(310): error: Expected: expected_original_request_url
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe.html
To be equal to: actual_nav_event->original_request_url
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html
c:\b\c\b\win\src\chrome\browser\safe_browsing\safe_browsing_navigation_observer_browsertest.cc(311): error: Expected: expected_destination_url
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe.html
To be equal to: actual_nav_event->GetDestinationUrl()
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html
c:\b\c\b\win\src\chrome\browser\safe_browsing\safe_browsing_navigation_observer_browsertest.cc(310): error: Expected: expected_original_request_url
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html
To be equal to: actual_nav_event->original_request_url
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe.html
c:\b\c\b\win\src\chrome\browser\safe_browsing\safe_browsing_navigation_observer_browsertest.cc(311): error: Expected: expected_destination_url
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe_retargeting.html
To be equal to: actual_nav_event->GetDestinationUrl()
Which is: http://127.0.0.1:51933/safe_browsing/download_protection/navigation_observer/iframe.html
[ FAILED ] SBNavigationObserverBrowserTest.SubFrameNewTabDownload, where TypeParam = and GetParam() = (1218 ms)
,
Jul 6 2017
ellyjones@, glider@, could any of you send me the link to all the flakiness? I want to know if it is the browser_test failed or the browser_side_navigation_browser_test failed.
,
Jul 7 2017
Sure, here is an example: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/13671/
,
Jul 7 2017
I think this is caused by the reason as of https://bugs.chromium.org/p/chromium/issues/detail?id=736354 +clamy@, csharrison@, since flakiness only happens in browser_side_navigation tests, could you suggest something to fix this flakiness?
,
Jul 28 2017
csharrison -- Please take a look and let us know if it needs SafeBrowsing team's input.
,
Jul 28 2017
,
Jul 28 2017
Sorry, I don't have time to fix these right now. The other SB download issues fixed involved using a download observer to wait until the download is finished. See calls to DownloadItemCreatedObserver::WaitForDownloadItem for more details.
,
Jul 28 2017
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e95247e5b22ad18642c7e4b73dad42450089dc5a commit e95247e5b22ad18642c7e4b73dad42450089dc5a Author: Jialiu Lin <jialiul@chromium.org> Date: Wed Aug 02 16:29:11 2017 Fix Flacky tests in SBNavigationObserverBrowserTest Fix flacky tests in SBNavigationObserverBrowserTest is caused by the non-deterministic iframe navigation order. This CL add checks to both possible orders. Bug: 739716 , 736354 Change-Id: I0b256d492500b8f2872485235eb0b826dae6c827 Reviewed-on: https://chromium-review.googlesource.com/594711 Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Luke Z <lpz@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#491398} [modify] https://crrev.com/e95247e5b22ad18642c7e4b73dad42450089dc5a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
,
Aug 2 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by glider@chromium.org
, Jul 6 2017Status: Assigned (was: Untriaged)