New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739703 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , All , Mac
Pri: 3
Type: Bug



Sign in to add a comment

about:media-internals page shows killed video players

Project Member Reported by fbeaufort@chromium.org, Jul 6 2017

Issue description

Chrome Version       : 61.0.3147.0
OS Version: 9715.0.0
URLs (if applicable) :

What steps will reproduce the problem?
1. Go to about:media-internals
2. Open a tab with that plays video element inside
3. Kill tab from the Chrome Task Manager

What is the expected result?
The video player should disappear from about:media-internals

What happens instead of that?
Video player in about:media-internals stays, even when I reload about:media-internals page.

Here's the log:

Timestamp	Property	Value
00:00:00 00	pipeline_state	kCreated
00:00:00 00	origin_url	https://beaufortfrancois.github.io/
00:00:00 00	url	https://storage.googleapis.com/media-session/caminandes/short.mp4#t=113
00:00:00 08	total_bytes	11210142
00:00:00 08	streaming	false
00:00:00 08	single_origin	true
00:00:00 08	passed_cors_access_check	false
00:00:00 08	range_header_supported	true
00:00:00 20	pipeline_state	kStarting
00:00:00 58	info	FFmpegDemuxer: created video stream, config codec: h264 format: 2 profile: h264 baseline coded size: [640,360] visible rect: [0,0,640,360] natural size: [640,360] has extra data? true encrypted? false
00:00:00 59	info	FFmpegDemuxer: created audio stream, config codec: aac bytes_per_channel: 4 channel_layout: 3 channels: 2 samples_per_second: 44100 sample_format: 6 bytes_per_frame: 8 seek_preroll: 0ms codec_delay: 0 has extra data? true encrypted? false
00:00:00 59	audio_channels_count	2
00:00:00 59	audio_codec_name	aac
00:00:00 59	audio_sample_format	Float 32-bit planar
00:00:00 59	audio_samples_per_second	44100
00:00:00 59	bitrate	613840
00:00:00 59	found_audio_stream	true
00:00:00 59	found_video_stream	true
00:00:00 59	height	360
00:00:00 59	max_duration	146.099955
00:00:00 59	start_time	0
00:00:00 59	time_base	1/24
00:00:00 59	video_codec_name	h264
00:00:00 59	video_format	PIXEL_FORMAT_YV12
00:00:00 59	video_is_encrypted	false
00:00:00 59	width	640
00:00:00 59	seek_target	113
00:00:00 62	audio_dds	false
00:00:00 62	audio_decoder	FFmpegAudioDecoder
00:00:00 62	video_dds	false
00:00:00 62	video_decoder	FFmpegVideoDecoder
00:00:00 63	pipeline_state	kPlaying
00:00:00 63	pipeline_state	kSeeking
00:00:00 67	pipeline_state	kPlaying
00:00:00 92	height	360
00:00:00 92	width	640
00:00:00 95	video_buffering_state	BUFFERING_HAVE_ENOUGH
00:00:00 96	audio_buffering_state	BUFFERING_HAVE_ENOUGH
00:00:00 96	pipeline_buffering_state	BUFFERING_HAVE_ENOUGH
00:00:00 59	duration	146.099955
00:00:01 425	event	PLAY
 
Cc: nick@chromium.org
Hmm, killing the tab must not actually trigger the process kill notification that the media log is attached to. If you close the tab the player still goes away right? It does for me on ToT anyways.

https://cs.chromium.org/chromium/src/content/browser/media/media_internals.cc?sq=package:chromium&dr&l=309

cc: nick@ who might know if that's expected or a bug.
Cc: mmanchala@chromium.org
Labels: M-61 OS-Linux OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows-7,Windows-10,Mac-10.12.4 and Linux Ubuntu-14.04 using chrome stable version 59.0.3071.115 and canary 61.0.3156.0 with the steps mentioned in comment#0.

This is Non-Regression issue, observed from M30 #30.0.1549.0 and marking it as Untriaged to get more inputs from dev team.

Thanks..!!
According to https://cs.chromium.org/chromium/src/content/public/browser/notification_types.h?sq=package:chromium&dr&l=111, when the render process crashes, we should use WebContentsObserver::RenderProcessGone. Could that be it?
Currently we listen for these:

  registrar_.Add(this, NOTIFICATION_RENDERER_PROCESS_CLOSED,
                 NotificationService::AllBrowserContextsAndSources());
  registrar_.Add(this, NOTIFICATION_RENDERER_PROCESS_TERMINATED,
                 NotificationService::AllBrowserContextsAndSources());

Which I guess I'd expect to be the same thing. nick@ did you have any thoughts?
Cc: sande...@chromium.org
I think sandersd@'s https://chromium-review.googlesource.com/c/567644 might have fixed this. Can you repro this on current M61 Canary/Dev?
Owner: fbeaufort@chromium.org
Status: Assigned (was: Untriaged)
As per c#5, this issue is fixed by sanders@. give to reporter@ to verify if it still repro on latest dev/canary build. 
In Google Chrome 62.0.3189.0 (Official Build) canary (64-bit), the video player doesn't disappear from about:media-internals. However when I reload it, it is not there anymore.

Status: Fixed (was: Assigned)
#7: This is the intended behavior, marking as fixed.

Sign in to add a comment