New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739696 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Make UkmRecorderImpl::AddEntry a no-op if the passed entry has no metrics?

Project Member Reported by vabr@chromium.org, Jul 6 2017

Issue description

Special use-case:
PasswordFormMetricsRecorder owns a UkmEntryBuilder, and ends up passing an entry to a UkmRecorder. In some cases, the builder needs to be discarded and replaced by another one. The discarded builder has collected no metrics, so it would be helpful if it did not leave any effect on what is uploaded.

While we can work around that in PasswordFormMetricsRecorder, in general, not adding an empty entry to the upload looks like it does not make the metrics less useful.

Metrics team, what do you think? Please assign to vabr@ once you decide if this looks good to you or not.
 

Comment 1 by vabr@chromium.org, Jul 6 2017

Status: WontFix (was: Untriaged)
Well, this was short-lived, at least the PasswordFormMetricsRecorder use-case. In the code around PasswordFormMetricsRecorder, we ended up with an Init function used also for other purposes in addition to setting the correct recorder from the beginning.

It the suggestion about AddEntry is still deemed useful, the metrics team is welcome to reopen this bug. But for now, I'm closing it, because fixing it won't have effect on password manager code and no other use-case is known to me.
Cc: -vabr@chromium.org

Sign in to add a comment