Issue metadata
Sign in to add a comment
|
Regression: Size of text caret is longer then expected on bookmarks overlay.
Reported by
aiman.an...@etouch.net,
Jul 6 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3150.0 (Official Build) (cohort: Stable)e32c608bfaee28eb9bd478073a2f222fb6c28133-refs/heads/master@{#484424} (32/64-bit). OS: Windows 7. Steps to reproduce: 1.Launch Chrome, go to chrome://md-settings, change browser language to 'Telegu' from chrome://md-settings/languages. 2.Relaunch Chrome, Click on Bookmark icon in top right corner. 3.Hit right arrow key and press space bar twice and now enter some text and observe the cursor Actual Result: Size of text caret is longer then expected. Expected Result: Size of text caret should be as expected. This is regression issue broken in M-58, and will soon update bisect info. Manual Bisect Info: Good Build: 58.0.3014.0 Bad Build: 58.0.3015.0 Note: Issue is not seen on Win(8,10), MAC and LINUX OS.
,
Jul 6 2017
Using the per-revision bisect providing the bisect results, Good build:58.0.3014.0(Revision:450840). Bad build:58.0.3015.0(Revision:451180). You are probably looking for a change made after 451178 (known good), but no later than 451179 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/a255f7468a598ea8cf8a5ab0e21ab0047f52568a..a33c8f5acb10c229da14134b9987e3b16eaa74f4 From the CL above, assigning the issue to the concern owner @yiyix: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2660593002 Note :Windows-7 specific issue and Able to reproduce in latest Canary #61.0.3150.0
,
Jul 26 2017
Issue 747850 has been merged into this issue.
,
Jul 26 2017
Seems to be a purely visual regression that should be fixed but Pri-2 since it has already shipped to stable for a few milestones.
,
Aug 11 2017
This is not a localization bug. Can't confirm if it's still relevant to the current English UI.
,
Aug 14 2017
Unable to reproduce the issue on Windows 7 using chrome reported version-61.0.3150.0 & latest Canary-62.0.3184.0. Please find the attached screencast for reference. aiman.ansari@, Could you please take a look and update the thread accordingly. Thanks..!!
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0b867b844d0e05d5b5699016468870581a12ad4 commit a0b867b844d0e05d5b5699016468870581a12ad4 Author: yiyix <yiyix@chromium.org> Date: Mon Aug 14 20:01:17 2017 Fix Regression: Size of text caret is longer then expected on bookmarks overlay When the system language is set to Telegu, the text cursor is displayed to be longer than the textfield in the bookmark overlay. The problem is that different languages are displayed at different font, so the text cursor can be longer for some font, ex: Telegu. The Text cursor should stop using the fixed default height and be able to adjust its height based on the height of the textfield and the location of the origin of the cursor. TEXT=TextfieldTest.CursorViewHeight Bug: 739686 Change-Id: If57578c7fc2f8342bd81707f45db5d278d8b9822 Reviewed-on: https://chromium-review.googlesource.com/608628 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#494150} [modify] https://crrev.com/a0b867b844d0e05d5b5699016468870581a12ad4/ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc [modify] https://crrev.com/a0b867b844d0e05d5b5699016468870581a12ad4/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/a0b867b844d0e05d5b5699016468870581a12ad4/ui/views/controls/textfield/textfield_test_api.cc [modify] https://crrev.com/a0b867b844d0e05d5b5699016468870581a12ad4/ui/views/controls/textfield/textfield_test_api.h [modify] https://crrev.com/a0b867b844d0e05d5b5699016468870581a12ad4/ui/views/controls/textfield/textfield_unittest.cc
,
Aug 14 2017
aiman.ansari@ Please verify in today's canary.
,
Aug 16 2017
W.R.T to comment #9 verified the above issue on #62.0.3187.0 on Win 7. Working fine as intended.
,
Aug 16 2017
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16 2017
,
Aug 31 2017
Hi, We would just like to follow up on this. Thank you. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Jul 6 2017