New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739673 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

generate_build_files failing on 2 builders

Project Member Reported by glider@chromium.org, Jul 6 2017

Issue description

generate_build_files failing on 2 builders

Builders failed on: 
- Google Chrome Mac: 
  https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac
- Google Chrome Win: 
  https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win


First failing build: https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Mac/builds/23220

Failure reason (from https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Mac%2F23220%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout):

""" to /b/c/b/Google_Chrome_Mac/src/out/Release/args.gn.
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR Unresolved dependencies.
//content/common:common(//build/toolchain/mac:clang_x64)
  needs //media:cdm_paths(//build/toolchain/mac:clang_x64)
GN gen failed: 1
step returned non-zero exit code: 1

I suspect this has been caused by https://chromium.googlesource.com/chromium/src/+/611b35e0bbf518c76733783f0d21c48c3b298f51


 
Cc: dalecur...@chromium.org
I've clobbered the builder (https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Mac/builds/23249), but that didn't help, so I'm reverting https://chromium-review.googlesource.com/c/558304/
I ccheck all the moved targets and found only //media:cdm_paths was left to change in //content/common.

I am changing it and uploading the patch.

Please let me know if I am missing some thing else.

I can not check any https://uberchromegw.corp.google.com sites.
Status: Started (was: Assigned)
> I ccheck all the moved targets and found only //media:cdm_paths was left to change in //content/common.

Yes, that's what the bot was complaining about.
Thanks!
Labels: -Sheriff-Chromium
Builders are green so removing from sheriff queue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33aa4027589f0e506549501cd5bda0fffdf62476

commit 33aa4027589f0e506549501cd5bda0fffdf62476
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Wed Jul 12 04:13:41 2017

Create BUILD.gn files for //media/cdm.

Create new BUILD.gn file for media/cdm and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
file.

BUG= 613033 , 739673 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I944b712791833edf6417db308225295c6cb3bdbf
Reviewed-on: https://chromium-review.googlesource.com/561265
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485843}
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/chrome/browser/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/chrome/common/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/chrome/test/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/content/common/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/base/BUILD.gn
[add] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/cdm/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/cdm/ppapi/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/cdm/ppapi/ppapi_cdm_adapter.gni
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/filters/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/gpu/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/mojo/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/mojo/services/BUILD.gn

Status: Fixed (was: Started)
Patch was fixed and re-landed ~5 hours back and till now no issue.

So closing it.

Sign in to add a comment