New issue
Advanced search Search tips

Issue 739672 link

Starred by 3 users
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jan 2018
Cc:
jochen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 714373



Sign in to add a comment

Allow download button from media controls to work on cross-origin content

Project Member Reported by mlamouri@chromium.org, Jul 6 2017 
This is currently usin <a download> which  bug 714373  is planning to no longer work with cross-origin content. The download button of the media controls should still work.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77044f23f9c569d8f754edbe3f0a9feb531ebc0e

commit 77044f23f9c569d8f754edbe3f0a9feb531ebc0e
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Jul 06 12:32:53 2017

Add test for download button for cross origin media in controls.

Bug:  739672 
Change-Id: I2f488365f6a5f41d87d71c135448cb81bd759fd9
Reviewed-on: https://chromium-review.googlesource.com/541440
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484552}
[add] https://crrev.com/77044f23f9c569d8f754edbe3f0a9feb531ebc0e/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media-cross-origin-expected.txt
[add] https://crrev.com/77044f23f9c569d8f754edbe3f0a9feb531ebc0e/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media-cross-origin.html

Comment 2 by jochen@chromium.org, Jan 17 2018

Owner: jochen@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e95d46287ca8778d17067d7c7e0c3a0bdde4e97

commit 0e95d46287ca8778d17067d7c7e0c3a0bdde4e97
Author: Jochen Eisinger <jochen@chromium.org>
Date: Wed Jan 17 19:12:11 2018

Create a download request for media controls

Don't try to trigger a download through an anchor tag.

BUG= 739672 
R=mlamouri@chromium.org

Change-Id: I6dc5b18d05f60de569fa77ae1d2a355130bf6774
Reviewed-on: https://chromium-review.googlesource.com/870836
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529840}
[modify] https://crrev.com/0e95d46287ca8778d17067d7c7e0c3a0bdde4e97/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp
[modify] https://crrev.com/0e95d46287ca8778d17067d7c7e0c3a0bdde4e97/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h

Comment 4 by jochen@chromium.org, Jan 17 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment