New issue
Advanced search Search tips

Issue 739663 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT import] import failed due to "did not match expected format" for linux_chromium_tsan_rel_ng

Project Member Reported by foolip@chromium.org, Jul 6 2017

Issue description

https://chromium-review.googlesource.com/c/560956

This import failed. The android_blink_rel bot is purple, but that doesn't seem like the root cause. From the wpt-importer logs:

Waiting for try jobs (timeout: 10800 seconds).
Waiting. 122 seconds passed.
Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpUSoRQw/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpUSoRQw/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 112, in main
    commit_successful = self.do_auto_update()
  File "/mnt/data/b/rr/tmpUSoRQw/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 354, in do_auto_update
    timeout_seconds=TIMEOUT_SECONDS)
  File "/mnt/data/b/rr/tmpUSoRQw/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 83, in wait_for_try_jobs
    try_results = self.try_job_results()
  File "/mnt/data/b/rr/tmpUSoRQw/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 121, in try_job_results
    build_to_status[self._build(result)] = self._try_job_status(result)
  File "/mnt/data/b/rr/tmpUSoRQw/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 147, in _build
    assert match, '%s did not match expected format' % url
AssertionError: https://luci-milo.appspot.com/swarming/task/372e95afdb555d10 did not match expected format
step returned non-zero exit code: 1

https://luci-milo.appspot.com/swarming/task/372e95afdb555d10 is a successful linux_chromium_tsan_rel_ng build.
 
qyearsley@, can you triage further?
Cc: -qyears...@chromium.org
Components: Blink>Infra>Ecosystem
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
Yep! What happened here is that it's trying to get build numbers for all try jobs, but swarming task jobs don't have sequential build numbers, they have hexadecimal IDs.

TestImporter.do_auto_update and/or GitCL.try_job_results needs to be changed.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf0466652ebda522eafb04289c3fd246e74b0664

commit cf0466652ebda522eafb04289c3fd246e74b0664
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Jul 06 23:35:40 2017

Change Build class to accept task ID in place of build number.

This CL would make it so that the Build class can potentially have
hexadecimal task IDs as build number. At the moment, such builds would
still not be able to have archived results, since we depend on the build
number when deciding where to archive layout test results. The difference
now is that if a Build status is checked but no results are fetched,
no error will be raised.

Bug:  739663 
Change-Id: I6e57f371d4bdd0d41e53fdc2a8cbd7c9625de4ec
Reviewed-on: https://chromium-review.googlesource.com/562561
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484765}
[modify] https://crrev.com/cf0466652ebda522eafb04289c3fd246e74b0664/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py
[modify] https://crrev.com/cf0466652ebda522eafb04289c3fd246e74b0664/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py
[modify] https://crrev.com/cf0466652ebda522eafb04289c3fd246e74b0664/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py
[modify] https://crrev.com/cf0466652ebda522eafb04289c3fd246e74b0664/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Status: Fixed (was: Assigned)

Sign in to add a comment