New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739631 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Wrong navigation is seen in RTL using left/right arrow keys at chrome://settings/manageProfile

Reported by sans...@etouch.net, Jul 6 2017 
Chrome Version: 61.0.3150.0 (Official Build) e32c608bfaee28eb9bd478073a2f222fb6c28133-refs/heads/master@{#484424} 32/64 bit 
OS:Windows (7,8,10), Mac (10.11.6, 10.12.3), Linux (14.04 LTS)

Pre-condition: Select ‘Right-to-left’ direction for Force UI direction from chrome://flags

Steps:
1. Launch Chrome and navigate to chrome://settings/manageProfile
2. Press tab key until focus is seen on Avtar icons, press left or right arrow keys and observe

Actual: Wrong navigation is seen using left/right arrow keys. i.e on hitting right arrow key focus navigates to left and vice-versa

Expected: On hitting right arrow key focus should navigate to right and vice-versa

This is regression is broken in ‘M 61’ and below is manual bisect info:

Good build:61.0.3138.0
Bad build:61.0.3140.0
Actual_video.mp4
654 KB View Download
Expected_video.mp4
263 KB View Download

Comment 1 by sandeepkumars@chromium.org, Jul 6 2017

Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good build: 61.0.3138.0 (Revision: 481386).
Bad build:  61.0.3140.0 (Revision: 482096).

You are probably looking for a change made after 481775 (known good), but no later than 481776 (first known bad).

CHANGELOG URL
---------------
https://chromium.googlesource.com/chromium/src/+log/ddcb2490139405d4cafae70b3adfefd6b3b11a2f..e67dbad97952415cabff9444ed85f543579240e6

From the CL above, assigning the issue to the concern owner

@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2950943002

Able to reproduce the issue using # 61.0.3150.0 on Win10, mac 10.12.5 and Linux Ubuntu 14.04

Thanks.

Comment 2 by rbasuvula@chromium.org, Jul 6 2017

Labels: Proj-MaterialDesign-WebUI

Comment 3 by dpa...@chromium.org, Jul 6 2017

Labels: -Pri-1 Pri-2

Comment 4 by dpa...@chromium.org, Jul 12 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a06f8385c3ea867c64acc1faf281fe388eb98b6b

commit a06f8385c3ea867c64acc1faf281fe388eb98b6b
Author: dpapad <dpapad@chromium.org>
Date: Thu Jul 13 02:54:47 2017

MD Settings: Fix avatar selector grid arrow keystrokes in RTL mode.

Bug:  739631 
Change-Id: Iecabaae34cd2e20124a5721d65bb8ab92460acf5
Reviewed-on: https://chromium-review.googlesource.com/569181
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486239}
[modify] https://crrev.com/a06f8385c3ea867c64acc1faf281fe388eb98b6b/chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js
[modify] https://crrev.com/a06f8385c3ea867c64acc1faf281fe388eb98b6b/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.js

Comment 6 by dpa...@chromium.org, Jul 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment