New issue
Advanced search Search tips

Issue 739622 link

Starred by 4 users
Status: Started
Owner:
hidehiko@chromium.org
Cc:
derat@chromium.org
tzik@chromium.org
satorux@chromium.org
yusukes@chromium.org
hashimoto@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocked on:
issue 234463
Blocking:
issue 764795



Sign in to add a comment

Use OnceCallback in chromeos/dbus.

Project Member Reported by hidehiko@chromium.org, Jul 6 2017 
Just a tracking issue.

It allows us to compile time check of unintended multiple callback invocation.

Then, we can use BindOnce consistently in ARC code base.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0

commit e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Jul 06 10:16:25 2017

Use OnceCallback for VoidDBusMethodCallback.

BUG=739622
TEST=Ran trybot.

Change-Id: Iadd4f13f679d24e03bd112055635da8756e4f910
Reviewed-on: https://chromium-review.googlesource.com/561033
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484526}
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/arc_obb_mounter_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/arc_obb_mounter_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/biod/biod_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/biod/biod_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/biod/fake_biod_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/biod/fake_biod_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/dbus_method_call_status.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_arc_obb_mounter_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_arc_obb_mounter_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_shill_device_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_shill_device_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_shill_ipconfig_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/fake_shill_ipconfig_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/mock_cryptohome_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/mock_cryptohome_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/mock_session_manager_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/mock_session_manager_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/session_manager_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/shill_client_helper.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/shill_client_helper.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/shill_device_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/shill_device_client.h
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/shill_ipconfig_client.cc
[modify] https://crrev.com/e9cfddfdd90e83c4d7753f8ec9c502500d32b4c0/chromeos/dbus/shill_ipconfig_client.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/179a6c96f8637ddd57a02195bb635b5ff2120adf

commit 179a6c96f8637ddd57a02195bb635b5ff2120adf
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jul 11 07:09:07 2017

Replace MockCryptohomeClient by fake in UserCloudPolicyStoreChromeOSTest.

This is preparation to remove MockCryptohomeClient,
as prepration to replace Callback by OnceCallback in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: I51397108a365d8b79b8de8a48263d7b62ef0182b
Reviewed-on: https://chromium-review.googlesource.com/563153
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485545}
[modify] https://crrev.com/179a6c96f8637ddd57a02195bb635b5ff2120adf/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/179a6c96f8637ddd57a02195bb635b5ff2120adf/chromeos/dbus/fake_cryptohome_client.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c478ce270250d10f1899e42ae963242d8d9157c

commit 8c478ce270250d10f1899e42ae963242d8d9157c
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Jul 12 19:15:56 2017

Replace MockCryptohomeClient by fake in AttestationFlowTest.

This is preparation to remove MockCryptohomeClient,
as preparation to replace Callback by OnceCallback in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: I00a48c7ff97c3f6b1938a42528a5e736c7352c8d
Reviewed-on: https://chromium-review.googlesource.com/566777
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486049}
[modify] https://crrev.com/8c478ce270250d10f1899e42ae963242d8d9157c/chromeos/attestation/attestation_flow_unittest.cc
[modify] https://crrev.com/8c478ce270250d10f1899e42ae963242d8d9157c/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/8c478ce270250d10f1899e42ae963242d8d9157c/chromeos/dbus/fake_cryptohome_client.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7843a8afd9056bd3d2d89ca52e0077a11c5fef8d

commit 7843a8afd9056bd3d2d89ca52e0077a11c5fef8d
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Jul 14 04:46:39 2017

Replace MockCryptohomeClient by fake in ChromeBrowsingDataRemoverDelegateTest.

This is preparation to remove MockCryptohomeClient,
as preparation to replace Callback by OnceCallback in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: I4b6f21228e402973a18e07aa5d80a134b2018f58
Reviewed-on: https://chromium-review.googlesource.com/569798
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486676}
[modify] https://crrev.com/7843a8afd9056bd3d2d89ca52e0077a11c5fef8d/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/7843a8afd9056bd3d2d89ca52e0077a11c5fef8d/chromeos/dbus/fake_cryptohome_client.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55ad6813e1b9ef392bb081add5879c31bd59c3e1

commit 55ad6813e1b9ef392bb081add5879c31bd59c3e1
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jul 18 14:58:43 2017

Replace MockCryptohomeClient by fake in AttestationPolicyObserverTest.

This is preparation to remove MockCryptohomeClient,
as preparation to replace Callback by OnceCallback in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: I77b9dfed9ce8662530e40e2dda085eb2852ae171
Reviewed-on: https://chromium-review.googlesource.com/569902
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487470}
[modify] https://crrev.com/55ad6813e1b9ef392bb081add5879c31bd59c3e1/chrome/browser/chromeos/attestation/attestation_policy_observer_unittest.cc
[modify] https://crrev.com/55ad6813e1b9ef392bb081add5879c31bd59c3e1/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/55ad6813e1b9ef392bb081add5879c31bd59c3e1/chromeos/dbus/fake_cryptohome_client.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b69855788e2668169522a997ff5d0d8bbb3cddf4

commit b69855788e2668169522a997ff5d0d8bbb3cddf4
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Jul 19 20:27:10 2017

Replace MockCryptohomeClient by fake in Enterprise API tests.

This is preparation to remove MockCryptohomeClinet,
as preparation to replace Callback by OnceCallback in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: I2c326050e48dae5671a796f152c7e723ccba601d
Reviewed-on: https://chromium-review.googlesource.com/570119
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487956}
[modify] https://crrev.com/b69855788e2668169522a997ff5d0d8bbb3cddf4/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/b69855788e2668169522a997ff5d0d8bbb3cddf4/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/b69855788e2668169522a997ff5d0d8bbb3cddf4/chromeos/dbus/fake_cryptohome_client.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40e1a3f583581893d24ae17d5272c7ab3b1167c1

commit 40e1a3f583581893d24ae17d5272c7ab3b1167c1
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Jul 20 03:52:14 2017

Remove MockCryptohomeClient.

This CL replaces last use of MockCryptohomeClient by fake,
and then remove it.

BUG=739622
TEST=Ran trybot.

Change-Id: I9477b540b40789c663657147b8172f5ae189dfc3
Reviewed-on: https://chromium-review.googlesource.com/571244
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488128}
[modify] https://crrev.com/40e1a3f583581893d24ae17d5272c7ab3b1167c1/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
[modify] https://crrev.com/40e1a3f583581893d24ae17d5272c7ab3b1167c1/chromeos/BUILD.gn
[delete] https://crrev.com/a94fcfb2cbb571f1fe9367a800e538906a31523f/chromeos/dbus/mock_cryptohome_client.cc
[delete] https://crrev.com/a94fcfb2cbb571f1fe9367a800e538906a31523f/chromeos/dbus/mock_cryptohome_client.h
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62ed3eea4e65533583374f68f929bc545e4a429

commit d62ed3eea4e65533583374f68f929bc545e4a429
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Sep 05 05:16:56 2017

Use BindOnce for ObjectProxy::CallMethod family in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: Ic7ff37535bb0218825da5c39e94ed1602ccec010
Reviewed-on: https://chromium-review.googlesource.com/649306
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499563}
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/arc_midis_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/arc_obb_mounter_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/arc_oemcrypto_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/biod/biod_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/cras_audio_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/cros_disks_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/easy_unlock_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/gsm_sms_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/image_burner_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/image_loader_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/lorgnette_manager_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/media_analytics_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/modem_messaging_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/permission_broker_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/power_manager_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/shill_client_helper.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/system_clock_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/update_engine_client.cc
[modify] https://crrev.com/d62ed3eea4e65533583374f68f929bc545e4a429/chromeos/dbus/upstart_client.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aae63faf77d15a59cb105a06388e3e30df102a3

commit 1aae63faf77d15a59cb105a06388e3e30df102a3
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Sep 05 13:16:39 2017

Use OnceCallback for StringDBusMethodCallback.

BUG=739622
TEST=Ran trybot.

Change-Id: I676204d010767aac076466e025091ff1aaa04607
Reviewed-on: https://chromium-review.googlesource.com/649450
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499615}
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/fake_image_loader_client.cc
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/fake_image_loader_client.h
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/image_loader_client.cc
[modify] https://crrev.com/1aae63faf77d15a59cb105a06388e3e30df102a3/chromeos/dbus/image_loader_client.h
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e86d6d81cc472190fb7cf7f86fbd93c31ae525fd

commit e86d6d81cc472190fb7cf7f86fbd93c31ae525fd
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Sep 05 17:34:29 2017

Replace CustomFakeCryptohomeClient by FakeCrytohomeClient.

The customized part is unused. So, just replace it.

BUG=739622
TEST=Ran trybots.

Change-Id: I6886dffe650310b8452c7126cd8deabdbce183fb
Reviewed-on: https://chromium-review.googlesource.com/578706
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499665}
[modify] https://crrev.com/e86d6d81cc472190fb7cf7f86fbd93c31ae525fd/chrome/browser/chromeos/attestation/attestation_policy_browsertest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d94c477b09ed656322b700bd3081d22d842449e8

commit d94c477b09ed656322b700bd3081d22d842449e8
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Sep 05 18:12:51 2017

Merge CustomFakeCryptohomeClient into FakeCryptohomeClient.

Now FakeCryptohomeClient has the features implemented in
CustomFakeCryptohomeClient, so migrate them.

BUG=739622
TEST=Ran trybots.

Change-Id: I96f571f2b28a5567788fa078d7ab97297021d66e
Reviewed-on: https://chromium-review.googlesource.com/577985
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499677}
[modify] https://crrev.com/d94c477b09ed656322b700bd3081d22d842449e8/chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc
[modify] https://crrev.com/d94c477b09ed656322b700bd3081d22d842449e8/chromeos/dbus/fake_cryptohome_client.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1156b4573400470b10f21e1043c65b9fad424d75

commit 1156b4573400470b10f21e1043c65b9fad424d75
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Sep 12 03:55:06 2017

Use more C++11 code in dbus/.

Use std::unique_ptr for MethodCall::FromRawMessage()
and Signal::FromRawMessage().
Use nullptr instead of NULL.
Use constexpr for constant in anonymous namespace in
ObjectProxy.

BUG=739622
TEST=Ran trybots.

Change-Id: I84fb7bc0318b09a77a44540575a97db6e5992db0
Reviewed-on: https://chromium-review.googlesource.com/658168
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501171}
[modify] https://crrev.com/1156b4573400470b10f21e1043c65b9fad424d75/dbus/message.cc
[modify] https://crrev.com/1156b4573400470b10f21e1043c65b9fad424d75/dbus/message.h
[modify] https://crrev.com/1156b4573400470b10f21e1043c65b9fad424d75/dbus/object_proxy.cc

Comment 14 by hidehiko@chromium.org, Sep 13 2017

Blocking: 764795
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/676ec87a5571836f1e8c2340eb235bec3b465bc4

commit 676ec87a5571836f1e8c2340eb235bec3b465bc4
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Sep 13 19:17:51 2017

Introduce DBusMethodCallback<>.

base/ starts to support Optional, as "loaner" class till c++17 std::optional.
DBusMethodCallback family can be migrate to one template
callback type with base::Optional for simplicity.
Also, with this change, on failure, it is not necessary to create
values, even default ones.
    
BUG=739622
TEST=Ran trybot.
TEST=TBD

Change-Id: I50efee891e02b2d76b6b7e6469d1697acbd10fba
Reviewed-on: https://chromium-review.googlesource.com/652047
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501712}
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos.h
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/cryptohome/async_method_caller.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/fake_image_loader_client.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/fake_image_loader_client.h
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/image_loader_client.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/dbus/image_loader_client.h
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/system/version_loader.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/tpm/tpm_password_fetcher.cc
[modify] https://crrev.com/676ec87a5571836f1e8c2340eb235bec3b465bc4/chromeos/tpm/tpm_password_fetcher.h
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c661e71064ac69735d4ec4e6d69e69299ff6e03

commit 8c661e71064ac69735d4ec4e6d69e69299ff6e03
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Sep 15 15:45:22 2017

Remove FakeBoolDBusMethod.

The class was unsued, so just removed.

BUG=739622
TEST=Ran trybot.

Change-Id: Ib78d090aa8e80cd84d98f8d63a7bb7ccac828dcc
Reviewed-on: https://chromium-review.googlesource.com/668379
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502267}
[modify] https://crrev.com/8c661e71064ac69735d4ec4e6d69e69299ff6e03/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380

commit bbebe805f0e24f6cb7dd909559a8a6ed3e94e380
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Sep 19 12:33:11 2017

Migrate Bool(ean)?DBusMethodCallback to DBusMethodCallback<bool>.

Part of OnceCallback migration in chromeos/dbus.

BUG=739622
TEST=Ran trybot.

Change-Id: Ic932aa7c018297a064889c4f05c8578bca712474
Reviewed-on: https://chromium-review.googlesource.com/666944
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502831}
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/attestation/attestation_policy_observer.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/chromeos/settings/install_attributes.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/attestation/attestation_flow.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/attestation/attestation_flow_unittest.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/fake_image_loader_client.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/fake_image_loader_client.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/image_loader_client.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/dbus/image_loader_client.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/login/auth/cryptohome_authenticator.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/tpm/tpm_password_fetcher.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/tpm/tpm_password_fetcher.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/tpm/tpm_token_info_getter.cc
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/tpm/tpm_token_info_getter.h
[modify] https://crrev.com/bbebe805f0e24f6cb7dd909559a8a6ed3e94e380/chromeos/tpm/tpm_token_info_getter_unittest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ff18b26be5d09e03efc81b5546c4dbaa660eb1

commit 34ff18b26be5d09e03efc81b5546c4dbaa660eb1
Author: Tatiana Gornak <melandory@chromium.org>
Date: Tue Sep 19 12:56:18 2017

Revert "Migrate Bool(ean)?DBusMethodCallback to DBusMethodCallback<bool>."

This reverts commit bbebe805f0e24f6cb7dd909559a8a6ed3e94e380.

Reason for revert: Suspecting in breaking the compilation for ChromeOS build

Original change's description:
> Migrate Bool(ean)?DBusMethodCallback to DBusMethodCallback<bool>.
> 
> Part of OnceCallback migration in chromeos/dbus.
> 
> BUG=739622
> TEST=Ran trybot.
> 
> Change-Id: Ic932aa7c018297a064889c4f05c8578bca712474
> Reviewed-on: https://chromium-review.googlesource.com/666944
> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502831}

TBR=hashimoto@chromium.org,stevenjb@chromium.org,skuhne@chromium.org,bauerb@chromium.org,hidehiko@chromium.org,waffles@chromium.org,emaxx@chromium.org

Change-Id: I4dcf82e6eb3f745582c48c9b035c92b0c72b69ac
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 739622
Reviewed-on: https://chromium-review.googlesource.com/672505
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502834}
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/attestation/attestation_policy_observer.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/chromeos/settings/install_attributes.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/attestation/attestation_flow.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/attestation/attestation_flow_unittest.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/fake_image_loader_client.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/fake_image_loader_client.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/image_loader_client.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/dbus/image_loader_client.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/login/auth/cryptohome_authenticator.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/tpm/tpm_password_fetcher.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/tpm/tpm_password_fetcher.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/tpm/tpm_token_info_getter.cc
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/tpm/tpm_token_info_getter.h
[modify] https://crrev.com/34ff18b26be5d09e03efc81b5546c4dbaa660eb1/chromeos/tpm/tpm_token_info_getter_unittest.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d78f056c3059c283654227375953331b3d133de3

commit d78f056c3059c283654227375953331b3d133de3
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Sep 21 08:30:06 2017

Remove ObjectPathDBusMethodCallback.

It was unsued.

BUG=739622
TEST=Ran trybot.

Change-Id: I5bf3248cd39e5e694ab661285ac3792566bb6cfb
Reviewed-on: https://chromium-review.googlesource.com/672684
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503387}
[modify] https://crrev.com/d78f056c3059c283654227375953331b3d133de3/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/d78f056c3059c283654227375953331b3d133de3/chromeos/dbus/shill_client_helper.cc
[modify] https://crrev.com/d78f056c3059c283654227375953331b3d133de3/chromeos/dbus/shill_client_helper.h
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f69d99c90a25ee0a8ab5eaa5d358bc7fb8166261

commit f69d99c90a25ee0a8ab5eaa5d358bc7fb8166261
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Sep 21 17:42:39 2017

Move instance management to D-Bus thread.

Currently, on method call completion,
Response/ErrorResponse instance is created on the Origin thread,
then is posted to D-Bus thread on deletion.

Rather, this CL creates and deletes instance on D-Bus thread
in common pattern.
Also, this CL handles an edge case better, where Origin thread
task runner is not running so PostTask is failing in
OnPendingCallIsComplete().
Previously, the instance was leaked, but with this CL
it will be unref'ed on the D-Bus thread.

BUG=739622
TEST=Ran trybots.

Change-Id: I4a75ad5d12d100607a39b801fb0ce2394c344fae
Reviewed-on: https://chromium-review.googlesource.com/664521
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503497}
[modify] https://crrev.com/f69d99c90a25ee0a8ab5eaa5d358bc7fb8166261/dbus/object_proxy.cc
[modify] https://crrev.com/f69d99c90a25ee0a8ab5eaa5d358bc7fb8166261/dbus/object_proxy.h
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375ccf5f18de69cb61f4116281c4baf4a5103762

commit 375ccf5f18de69cb61f4116281c4baf4a5103762
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Sep 21 18:15:00 2017

Reland "Migrate Bool(ean)?DBusMethodCallback to DBusMethodCallback<bool>."

This is a reland of bbebe805f0e24f6cb7dd909559a8a6ed3e94e380
Original change's description:
> Migrate Bool(ean)?DBusMethodCallback to DBusMethodCallback<bool>.
> 
> Part of OnceCallback migration in chromeos/dbus.
> 
> BUG=739622
> TEST=Ran trybot.
> 
> Change-Id: Ic932aa7c018297a064889c4f05c8578bca712474
> Reviewed-on: https://chromium-review.googlesource.com/666944
> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502831}

Bug: 739622
Change-Id: Idc0b0659e24ebd96eadaf57f872dea926e2e52ac
Reviewed-on: https://chromium-review.googlesource.com/672563
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503512}
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/attestation/attestation_policy_observer.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/chromeos/settings/install_attributes.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/attestation/attestation_flow.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/attestation/attestation_flow_unittest.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/fake_image_loader_client.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/fake_image_loader_client.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/image_loader_client.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/dbus/image_loader_client.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/login/auth/cryptohome_authenticator.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/tpm/tpm_password_fetcher.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/tpm/tpm_password_fetcher.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/tpm/tpm_token_info_getter.cc
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/tpm/tpm_token_info_getter.h
[modify] https://crrev.com/375ccf5f18de69cb61f4116281c4baf4a5103762/chromeos/tpm/tpm_token_info_getter_unittest.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8

commit e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Sep 25 15:36:15 2017

Use OnceCallback for WaitForServiceToBeAvailable.

BUG=739622
TEST=Ran trybot.

Change-Id: I41bfb67105a1e06254da7c622b9a2804c4d37b64
Reviewed-on: https://chromium-review.googlesource.com/676606
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504065}
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/arc_oemcrypto_client.cc
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/cras_audio_client.cc
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/cras_audio_client.h
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/debug_daemon_client.h
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/fake_cras_audio_client.cc
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/fake_cras_audio_client.h
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/fake_debug_daemon_client.h
[modify] https://crrev.com/e7bf32bcbe0a431a9c3d566190f5b4643a73b1e8/chromeos/dbus/system_clock_client.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea73964b13c82965d73a34abe2952844114415fd

commit ea73964b13c82965d73a34abe2952844114415fd
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Oct 03 05:01:53 2017

Migrate ProtobufMethodCallback into DBusMethodCallback.

BUG=739622
TEST=Build.

Change-Id: Ia8715a55b5d93abaf38fe417e8257a43bbe107a8
Reviewed-on: https://chromium-review.googlesource.com/695482
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505946}
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/settings/install_attributes.h
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chrome/browser/chromeos/settings/install_attributes_unittest.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chromeos/cryptohome/homedir_methods_unittest.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/ea73964b13c82965d73a34abe2952844114415fd/chromeos/dbus/fake_cryptohome_client.h
Project Member

Comment 28 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31770914c9fd156159df0141d7c4e79f044225d2

commit 31770914c9fd156159df0141d7c4e79f044225d2
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Oct 10 18:17:15 2017

Remove CheckArcAvailability().

The function is no longer used. Remove it.

BUG=739622
TEST=Build.

Change-Id: I929e05a725e8a3312a371f6d2663dd1739db199c
Reviewed-on: https://chromium-review.googlesource.com/709234
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507722}
[modify] https://crrev.com/31770914c9fd156159df0141d7c4e79f044225d2/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/31770914c9fd156159df0141d7c4e79f044225d2/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/31770914c9fd156159df0141d7c4e79f044225d2/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/31770914c9fd156159df0141d7c4e79f044225d2/chromeos/dbus/session_manager_client.h
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76aca4a484cfbc5981593136c671f7dd819f1a3d

commit 76aca4a484cfbc5981593136c671f7dd819f1a3d
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Oct 11 17:42:02 2017

Get rid of DBusMethodCallStatus from VoidDBusMethodCallback.

Also, deprecate DBusMethodCallStatus.

BUG=739622
TEST=Ran trybot.

Change-Id: Ie01f2defa643de5abb2d32f635633a53a4e0581f
Reviewed-on: https://chromium-review.googlesource.com/704614
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508023}
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.h
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chrome/browser/chromeos/login/session/user_session_manager.h
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/arc_midis_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/arc_obb_mounter_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/arc_oemcrypto_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/biod/biod_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/biod/biod_client_unittest.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/biod/fake_biod_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/biod/fake_biod_client_unittest.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/biod/test_utils.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/biod/test_utils.h
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/dbus_method_call_status.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/fake_arc_midis_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/fake_arc_obb_mounter_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/fake_arc_oemcrypto_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/fake_shill_device_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/fake_shill_device_client.h
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/fake_shill_ipconfig_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/shill_client_helper.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/shill_client_unittest_base.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/dbus/shill_client_unittest_base.h
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/network/host_resolver_impl_chromeos_unittest.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/network/network_device_handler_impl.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/chromeos/network/shill_property_handler_unittest.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/components/arc/midis/arc_midis_bridge.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/components/arc/midis/arc_midis_bridge.h
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/components/arc/obb_mounter/arc_obb_mounter_bridge.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/services/device/fingerprint/fingerprint_chromeos.cc
[modify] https://crrev.com/76aca4a484cfbc5981593136c671f7dd819f1a3d/services/device/fingerprint/fingerprint_chromeos.h
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2d1f8923ae8b256231e33062bddad180f116f83

commit e2d1f8923ae8b256231e33062bddad180f116f83
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Oct 13 05:21:30 2017

Migrate ArcCallback to VoidDBusMethodCallback.

Along with the change, small refactoring is done
around RestartJob handling.

BUG=739622
TEST=Build.

Change-Id: If345b9dbca2637612cc25f0cbcd9588618670509
Reviewed-on: https://chromium-review.googlesource.com/714742
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508604}
[modify] https://crrev.com/e2d1f8923ae8b256231e33062bddad180f116f83/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/e2d1f8923ae8b256231e33062bddad180f116f83/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/e2d1f8923ae8b256231e33062bddad180f116f83/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/e2d1f8923ae8b256231e33062bddad180f116f83/chromeos/dbus/session_manager_client.h
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9377acb13018f943637bdcf32381fb92439d79cf

commit 9377acb13018f943637bdcf32381fb92439d79cf
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Oct 16 02:33:56 2017

Migrate DevicePolicy feature to FakeSessionManagerClient.

This CL migrates the DevicePolicy related implementation
from DeviceSettingsTestHelper into FakeSessionManagerClient.

Along with the change, SessionManagerOperationTest.RestartLoad
needs to introduce another callback which runs during the flow
to emulate restarting.
To that purpose, ObservableDeviceSettingsTestHelper is introduced
to the file.

BUG=739622
TEST=Ran trybot.

Change-Id: I8c9b219edc030e4a1338595772b74acdaf533071
Reviewed-on: https://chromium-review.googlesource.com/718716
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508972}
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/policy/off_hours/device_off_hours_controller_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/settings/device_settings_service_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/settings/device_settings_test_helper.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/settings/device_settings_test_helper.h
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chrome/browser/chromeos/system/device_disabling_manager_unittest.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/9377acb13018f943637bdcf32381fb92439d79cf/chromeos/dbus/fake_session_manager_client.h
Project Member

Comment 34 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20da910e7ade8037bbaa6314a69208faade806b6

commit 20da910e7ade8037bbaa6314a69208faade806b6
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Wed Oct 18 18:08:34 2017

Migrate DeviceSettingsTestHelper into FakeSessionManagerClient.

DeviceSettingsTestHelper has almost same bahavior with
FakeSessionManagerClient. De-duplicate the code.

BUG=739622
TEST=Ran trybot.

Change-Id: Ibdfb94669ef8e0fa6995536cc1438f0b3cd25856
Reviewed-on: https://chromium-review.googlesource.com/722142
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509812}
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/policy/off_hours/device_off_hours_controller_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/settings/device_settings_service_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/settings/device_settings_test_helper.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/settings/device_settings_test_helper.h
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
[modify] https://crrev.com/20da910e7ade8037bbaa6314a69208faade806b6/chrome/browser/chromeos/system/device_disabling_manager_unittest.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe6246c6b575f97319e06b564a6d8e76cbc1ad2e

commit fe6246c6b575f97319e06b564a6d8e76cbc1ad2e
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Oct 19 19:54:56 2017

Introduce CallMethodWithErrorResponse().

Taking two callbacks API (CallMethodWithErrorCallback()) is
not familiar with OnceCallback unfortunately.
So, instead, this CL introduces a ResponseOrErrorCallback,
which takes either Response* or ErrorResponse*, and it is
called on completion of CallMethod task regardless of whether it
is success or fail.

CallMethodWithErrorCallback() is deprecated now,
and the callers will be migarted into CallMethodWithErrorResponse()
in following CLs.

BUG=739622
TEST=Build.

Change-Id: Ib12e27de0d1dc09f2878679c53e0ad741c916fe9
Reviewed-on: https://chromium-review.googlesource.com/704794
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510166}
[modify] https://crrev.com/fe6246c6b575f97319e06b564a6d8e76cbc1ad2e/dbus/mock_object_proxy.cc
[modify] https://crrev.com/fe6246c6b575f97319e06b564a6d8e76cbc1ad2e/dbus/mock_object_proxy.h
[modify] https://crrev.com/fe6246c6b575f97319e06b564a6d8e76cbc1ad2e/dbus/object_proxy.cc
[modify] https://crrev.com/fe6246c6b575f97319e06b564a6d8e76cbc1ad2e/dbus/object_proxy.h
Project Member

Comment 38 by bugdroid1@chromium.org, Oct 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5698d37baf925f0319918910494d444c7a4d237b

commit 5698d37baf925f0319918910494d444c7a4d237b
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Oct 23 18:06:46 2017

Migrate TestPowerManagerClient into FakeManagerClient.

This moves the fake implementation to shared fake class.

BUG=739622
TEST=Build/Ran bots.

Change-Id: Iad93cbd23bf3a3177907289a6f97800d7338bcee
Reviewed-on: https://chromium-review.googlesource.com/732874
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510849}
[modify] https://crrev.com/5698d37baf925f0319918910494d444c7a4d237b/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc
[modify] https://crrev.com/5698d37baf925f0319918910494d444c7a4d237b/chromeos/dbus/fake_power_manager_client.cc
[modify] https://crrev.com/5698d37baf925f0319918910494d444c7a4d237b/chromeos/dbus/fake_power_manager_client.h
Project Member

Comment 39 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86f38b0d863c4615ca5add1f49fd8a42c0c7add2

commit 86f38b0d863c4615ca5add1f49fd8a42c0c7add2
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Oct 26 02:24:01 2017

Migrate RetrievePolicyCallback to OnceCallback.

Along with the migraiton, swapped its argument to follow
the common practice in chrome (state first, followed by optional argument
which is only available in specific state (SUCCESS in this case)).

BUG=739622
TEST=Build/Ran bots.

Change-Id: Ia6c93ce342b6d3550ba0caa81e3de4c0e3627f45
Reviewed-on: https://chromium-review.googlesource.com/737394
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511705}
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/policy/device_local_account_policy_store.cc
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/policy/device_local_account_policy_store.h
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/settings/session_manager_operation.cc
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/settings/session_manager_operation.h
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/86f38b0d863c4615ca5add1f49fd8a42c0c7add2/chromeos/dbus/session_manager_client.h
Project Member

Comment 41 by bugdroid1@chromium.org, Oct 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/181b297d04625c7a3da91fd32596e7a0cbf0a647

commit 181b297d04625c7a3da91fd32596e7a0cbf0a647
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Oct 30 06:43:53 2017

Migrate Callbacks defined in PowerManagerClient to DBusMethodCallback.

Along with the change, now PowerManagerClient starts
to report error to its callers, instead of ignoring errors.
Instead, callers starts to handle errors.

BUG=739622
TEST=Build/Ran bots.

Change-Id: Ib59431b1ca2136b10f06382f97801fe7cba33e5d
Reviewed-on: https://chromium-review.googlesource.com/735281
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512447}
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/system/brightness/brightness_controller_chromeos.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/system/brightness/brightness_controller_chromeos.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/system/brightness/tray_brightness.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/system/brightness/tray_brightness.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/system/brightness_control_delegate.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/system/power/power_button_display_controller.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/system/power/power_button_display_controller.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chrome/browser/chromeos/lock_screen_apps/state_controller.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chrome/browser/chromeos/lock_screen_apps/state_controller.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chrome/browser/ui/webui/settings/chromeos/device_power_handler.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chromeos/dbus/fake_power_manager_client.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chromeos/dbus/fake_power_manager_client.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chromeos/dbus/power_manager_client.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/chromeos/dbus/power_manager_client.h
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/components/arc/power/arc_power_bridge.cc
[modify] https://crrev.com/181b297d04625c7a3da91fd32596e7a0cbf0a647/components/arc/power/arc_power_bridge.h

Comment 42 by hidehiko@chromium.org, Nov 1 2017

Blockedon: 234463
Project Member

Comment 43 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c24558c479ad51b755ccf046e3306b8455273179

commit c24558c479ad51b755ccf046e3306b8455273179
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Nov 10 17:33:25 2017

Use VoidDBusMethodCallback for GetPerfOutput().

The only caller of GetPerfOutput is PerfOutput.
In error callback, the detailed error info was not used.
So, this CL migrates the callback to VoidDBusMethodCallback.
The new callback is always called unlike the old one,
which is called only on error. The passed |success| tells
whether the D-Bus call is succeeded or not.

BUG=739622
TEST=Build.

Change-Id: I0793d7ebd774e91415e9577fa2a680141363a477
Reviewed-on: https://chromium-review.googlesource.com/755233
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515582}
[modify] https://crrev.com/c24558c479ad51b755ccf046e3306b8455273179/chrome/browser/metrics/perf/perf_output.cc
[modify] https://crrev.com/c24558c479ad51b755ccf046e3306b8455273179/chrome/browser/metrics/perf/perf_output.h
[modify] https://crrev.com/c24558c479ad51b755ccf046e3306b8455273179/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/c24558c479ad51b755ccf046e3306b8455273179/chromeos/dbus/debug_daemon_client.h
[modify] https://crrev.com/c24558c479ad51b755ccf046e3306b8455273179/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/c24558c479ad51b755ccf046e3306b8455273179/chromeos/dbus/fake_debug_daemon_client.h
Project Member

Comment 44 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bb318bbfd7c83cd0e07933ad89700f4dace1652

commit 2bb318bbfd7c83cd0e07933ad89700f4dace1652
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 14 02:23:15 2017

Migrate CrasAudioClient::GetNodes to DBusMethodCallback.

Along with the change, log_error_ in CrasAudioHandler is removed.
The flag is introduced to reduce the logging during reboot,
because cras service may not yet start. However, now we have
WaitForServiceToBeAvailable(), so that we can correctly
wait it is up.

BUG=739622
TEST=Ran trybots.
     Ran on DUT, and made sure no log spam in /var/log/chrome/chrome.

Change-Id: Ic36f3a3096ae0abf213fdf7329d6141d7d1475d9
Reviewed-on: https://chromium-review.googlesource.com/760437
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516146}
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chrome/browser/chromeos/login/session/chrome_session_manager.h
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chromeos/dbus/cras_audio_client.cc
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chromeos/dbus/cras_audio_client.h
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chromeos/dbus/cras_audio_client_unittest.cc
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chromeos/dbus/fake_cras_audio_client.cc
[modify] https://crrev.com/2bb318bbfd7c83cd0e07933ad89700f4dace1652/chromeos/dbus/fake_cras_audio_client.h
Project Member

Comment 45 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68ecbdc5f3ce8557a26936f9a47062208f418ba9

commit 68ecbdc5f3ce8557a26936f9a47062208f418ba9
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 14 05:12:00 2017

Reduce gmock usage in modem_messaging_client_unittest.cc.

This is preparation to migarte callbacks in modem_messaging_client
into DBusMethodCallback.
Removes MockCallback.

BUG=739622
TEST=Ran bots.

Change-Id: I885b82bd463764786aab582ea23a07624b24935f
Reviewed-on: https://chromium-review.googlesource.com/768254
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516199}
[modify] https://crrev.com/68ecbdc5f3ce8557a26936f9a47062208f418ba9/chromeos/dbus/modem_messaging_client_unittest.cc
Project Member

Comment 46 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f30a19782f1e6ae79ac9587ed6afe712c3291f74

commit f30a19782f1e6ae79ac9587ed6afe712c3291f74
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 14 06:16:00 2017

Reduce gmock usage in gsm_sms_client_unittest.cc.

This is preparation to migarte callbacks in gsm_sms_client
into DBusMethodCallback.
Removes MockCallback.

BUG=739622
TEST=Ran bots.

Change-Id: I52dfcfb69111ed21ddda1a7b857bf3be8ea7e454
Reviewed-on: https://chromium-review.googlesource.com/766927
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516203}
[modify] https://crrev.com/f30a19782f1e6ae79ac9587ed6afe712c3291f74/chromeos/dbus/gsm_sms_client_unittest.cc
Project Member

Comment 47 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c105b5d1f2e610d309a821f5264fbbe1eed0a94

commit 1c105b5d1f2e610d309a821f5264fbbe1eed0a94
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Nov 14 06:18:17 2017

Migrate DebugDaemonClient to DBusMethodCallback part 1.

BUG=739622
TEST=Build/Ran bots.

Change-Id: If3d1b71f7509c836005daa723b5a8f010bc8746a
Reviewed-on: https://chromium-review.googlesource.com/766807
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516207}
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chrome/browser/chromeos/system_logs/debug_daemon_log_source.h
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.cc
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.h
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chromeos/dbus/debug_daemon_client.h
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/1c105b5d1f2e610d309a821f5264fbbe1eed0a94/chromeos/dbus/fake_debug_daemon_client.h
Project Member

Comment 49 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd

commit 5289cdfe7145d3d5d839fe27c9f44f21d3c380bd
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Dec 01 04:47:29 2017

Migrate LorgnetteManagerClient into DBusMethod.

BUG=739622
TEST=Ran trybots. Ran documentscan_AppTestWithFakeLorgnette on DUT.

Change-Id: I53358981be8b33e934ea5846391cad5fbc2af62b
Reviewed-on: https://chromium-review.googlesource.com/796491
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520856}
[modify] https://crrev.com/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd/chromeos/dbus/fake_lorgnette_manager_client.cc
[modify] https://crrev.com/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd/chromeos/dbus/fake_lorgnette_manager_client.h
[modify] https://crrev.com/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd/chromeos/dbus/lorgnette_manager_client.cc
[modify] https://crrev.com/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd/chromeos/dbus/lorgnette_manager_client.h
[modify] https://crrev.com/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd/extensions/browser/api/document_scan/document_scan_interface_chromeos.cc
[modify] https://crrev.com/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd/extensions/browser/api/document_scan/document_scan_interface_chromeos.h
[modify] https://crrev.com/5289cdfe7145d3d5d839fe27c9f44f21d3c380bd/extensions/browser/api/document_scan/document_scan_interface_chromeos_unittest.cc
Project Member

Comment 51 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ce6dc33aa499fe190b06399fc70ca34cdc1569

commit 06ce6dc33aa499fe190b06399fc70ca34cdc1569
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Fri Dec 08 19:32:03 2017

Get rid of Callback from CrosDisksClient part 1.

This CL removes Callback usage for D-Bus signals in
CrosDisksClient.
For the interface, Observer is used following the guideline.
For the implementation, OnceCallback and RepeatingCallback are
used.

BUG=739622
TEST=Ran on bots.

Change-Id: I453dd2f4f6148adad074e915500cc651090cefd8
Reviewed-on: https://chromium-review.googlesource.com/817714
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522840}
[modify] https://crrev.com/06ce6dc33aa499fe190b06399fc70ca34cdc1569/chromeos/dbus/cros_disks_client.cc
[modify] https://crrev.com/06ce6dc33aa499fe190b06399fc70ca34cdc1569/chromeos/dbus/cros_disks_client.h
[modify] https://crrev.com/06ce6dc33aa499fe190b06399fc70ca34cdc1569/chromeos/dbus/fake_cros_disks_client.cc
[modify] https://crrev.com/06ce6dc33aa499fe190b06399fc70ca34cdc1569/chromeos/dbus/fake_cros_disks_client.h
[modify] https://crrev.com/06ce6dc33aa499fe190b06399fc70ca34cdc1569/chromeos/disks/disk_mount_manager.cc
[modify] https://crrev.com/06ce6dc33aa499fe190b06399fc70ca34cdc1569/chromeos/disks/disk_mount_manager_unittest.cc
Project Member

Comment 52 by bugdroid1@chromium.org, Feb 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0c329f7fea90bfda0818b4963ce5d54c98f44a1

commit e0c329f7fea90bfda0818b4963ce5d54c98f44a1
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Feb 05 03:36:36 2018

Replace Callback by OnceCallback in SMSClient.

BUG=739622
TEST=Ran on bots.

Change-Id: I53ac04966f159a063752507c8b0463f3306a793f
Reviewed-on: https://chromium-review.googlesource.com/896778
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534318}
[modify] https://crrev.com/e0c329f7fea90bfda0818b4963ce5d54c98f44a1/chromeos/dbus/fake_sms_client.cc
[modify] https://crrev.com/e0c329f7fea90bfda0818b4963ce5d54c98f44a1/chromeos/dbus/fake_sms_client.h
[modify] https://crrev.com/e0c329f7fea90bfda0818b4963ce5d54c98f44a1/chromeos/dbus/sms_client.cc
[modify] https://crrev.com/e0c329f7fea90bfda0818b4963ce5d54c98f44a1/chromeos/dbus/sms_client.h
Project Member

Comment 56 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd

commit e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Feb 08 02:08:05 2018

Remove Callback from MediaAnalyticsClient.

The remaining Callback for the client is to recieve a D-Bus signal.
Following
https://chromium.googlesource.com/chromiumos/docs/+/master/dbus_in_chrome.md#keep-your-class-minimal
replace it by Observer.

BUG=739622
TEST=Ran on trybot.

Change-Id: If723e7ecbee3d7255a588185b6d925023fd14bcb
Reviewed-on: https://chromium-review.googlesource.com/907008
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535254}
[modify] https://crrev.com/e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd/chromeos/dbus/fake_media_analytics_client.cc
[modify] https://crrev.com/e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd/chromeos/dbus/fake_media_analytics_client.h
[modify] https://crrev.com/e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd/chromeos/dbus/media_analytics_client.cc
[modify] https://crrev.com/e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd/chromeos/dbus/media_analytics_client.h
[modify] https://crrev.com/e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd/extensions/browser/api/media_perception_private/media_perception_api_manager.cc
[modify] https://crrev.com/e7f52779442d9dc32bbe4e8b3d5e03d9eb6c39fd/extensions/browser/api/media_perception_private/media_perception_api_manager.h

Comment 59 by lhchavez@chromium.org, Jan 7

Cc: -lhchavez@chromium.org
►

Sign in to add a comment