Arc notification is shown in 2x size |
|||||
Issue descriptionChrome Version: 61.0.3147.0 OS: Chrome OS What steps will reproduce the problem? (1) Show ARC notification What is the expected result? Notifications are shown in normal size What happens instead? Notifications were shown in 2x size Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jul 6 2017
This is tracked internally: https://issuetracker.google.com/issues/63311162
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd3f79e2d866df4ab2a389c1272583fc90105152 commit bd3f79e2d866df4ab2a389c1272583fc90105152 Author: Peng Huang <penghuang@google.com> Date: Thu Jul 06 11:10:43 2017 exo: Use notification surface's content size in ArcNotificationSurfaceImpl Bug: 739620 Change-Id: I4109e45f5f800f90d11ec37e06b839e9f4f2ae5b Reviewed-on: https://chromium-review.googlesource.com/559750 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#484542} [modify] https://crrev.com/bd3f79e2d866df4ab2a389c1272583fc90105152/components/exo/notification_surface.cc [modify] https://crrev.com/bd3f79e2d866df4ab2a389c1272583fc90105152/components/exo/notification_surface.h [modify] https://crrev.com/bd3f79e2d866df4ab2a389c1272583fc90105152/components/exo/surface_tree_host.h [modify] https://crrev.com/bd3f79e2d866df4ab2a389c1272583fc90105152/ui/arc/notification/arc_notification_surface_impl.cc
,
Jul 6 2017
Peng, thank you for fixing! It looks the buttons (close and settings button) is still broken on Samus and Caroline (I didn't test other devices). Click events on buttons are not handled by button but by surface window. Do you have any idea about the issue?
,
Jul 6 2017
Ok, I found the cause of the issue mentioned in #4. It look CustomWindowTargeter in surface_tree_host.cc prevents click events from being delivered to the buttons. Let me fix.
,
Jul 7 2017
,
Jul 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c03f6e2c0c72aea643810a67360057efbd31b13 commit 4c03f6e2c0c72aea643810a67360057efbd31b13 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Sun Jul 09 06:07:18 2017 Support child non-exo windows of the root surface in exo::SurfaceTreeHost This patch fixed the issue of close and settings buttons in arc notifications. Bug: 739620 Change-Id: I0d050d3cec66f0470a7babb9f40833487f0e3071 Reviewed-on: https://chromium-review.googlesource.com/561996 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#485157} [modify] https://crrev.com/4c03f6e2c0c72aea643810a67360057efbd31b13/components/exo/surface_tree_host.cc
,
Jul 10 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hirono@chromium.org
, Jul 6 2017