New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739612 link

Starred by 4 users
Status: Fixed
Owner:
mattcary@chromium.org
Closed: Sep 2017
Cc:
█ wugenqing@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

To expose effective connection type and NQE related information to CCT callbacks

Project Member Reported by wugenqing@chromium.org, Jul 6 2017 
Some page load time metrics are already added, like these under label ProgressiveWebMetrics:
https://bugs.chromium.org/p/chromium/issues/list?q=label:ProgressiveWebMetrics

Some of them are available from CCT (Chrome Custom Tabs) callbacks, like first contentful paint.

This bug is to request more network quality related information from Chrome through the CCT callbacks:
1) effective connection type;
2) other NQE (network quality estimation) information like bandwidth and latency (RTT).

Comment 1 by mattcary@chromium.org, Jul 10 2017

Status: Assigned (was: Untriaged)

Comment 2 by mattcary@chromium.org, Jul 27 2017

Components: UI>Browser>Mobile>CustomTabs

Comment 3 by mattcary@chromium.org, Jul 27 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232

commit 95cfa8712eea88acdae5cb3a5d4a3bf4bad79232
Author: Matthew Cary <mattcary@chromium.org>
Date: Tue Aug 22 16:20:44 2017

Add additional WebPerformance metrics to PageLoadMetrics.

This forwards net::LoadTimingInfo information found at RequestComplete
time to the PageLoadMetrics OnLoadedResource event, exposing detailed
network statistics to PageLoadMetrics, including DNS and request send
timings.

Bug:  739612 
Change-Id: I4001876007b732b2018348e25ff0aa02580d83a5
Reviewed-on: https://chromium-review.googlesource.com/591807
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496324}
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/95cfa8712eea88acdae5cb3a5d4a3bf4bad79232/chrome/browser/page_load_metrics/page_load_metrics_observer.h
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e0b725647baaf52102d6298954dda80da700f2

commit 05e0b725647baaf52102d6298954dda80da700f2
Author: Matthew Cary <mattcary@chromium.org>
Date: Fri Sep 15 09:19:34 2017

CCT: export load timing and network quality estimation.

Expose load timing and network quality estimation to a Custom Tabs
client via the AndroidPageLoadMetricsObserver.

Bug:  739612 , 749711 
Change-Id: Ic15600f0360d89b36e2bdd7277cc45c539294b6a
Reviewed-on: https://chromium-review.googlesource.com/601467
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502214}
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/java/src/org/chromium/chrome/browser/metrics/PageLoadMetrics.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/PageLoadMetricsTest.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h
[add] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/test/BUILD.gn

Comment 6 by mattcary@chromium.org, Sep 15 2017

Status: Fixed (was: Started)
This is finally in and will be out to dev soon.

I'll mark this as fixed, if there are any problems with the implementation another bug can be created.

Comment 7 by dproy@chromium.org, Mar 16 2018

Labels: -progressivewebmetrics
►

Sign in to add a comment