New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739607 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted text caret is observed in 'URL' text filed of Edit bookmark overlay.

Reported by avsha...@etouch.net, Jul 6 2017

Issue description

Chrome Version : 61.0.3150.0 (Official Build) e32c608bfaee28eb9bd478073a2f222fb6c28133-refs/heads/master@{#484424} 32/64 bit
OS : Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome, open NTP and click on 'Bookmark this page' icon.
2. Click on 'Edit' button and observe the URL text field in 'Edit bookmark' overlay. 

Actual Result : Unwanted text caret is observed in 'URL' text filed of Edit bookmark overlay.

Expected Result : Unnecessarily text caret should not be seen in 'URL' text filed.

This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info.
Good build : 61.0.3149.0
Bad build : 61.0.3150.0

Note : Will soon update other OS info.

 
Actual_Bookmarks.mp4
742 KB View Download
Labels: OS-Linux
Update : 

Able to reproduce issue in Linux(14.04 LTS) OS with #61.0.3150.0 build and issue is not seen in Mac(10.11.6, 10.12.3) OS.
Labels: hasbisect-per-revision
Owner: yiyix@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3149.0(Revision:484159).
Bad build:61.0.3150.0(Revision:484424).

You are probably looking for a change made after 484421 (known good), but no later than 484422 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/e97871b5c8dac1a414318d7a6554ba033894cc36..daf838dca867613a3f7dc9fa915b14b6245da83e

From the CL above, assigning the issue to the concern owner

@yiyix: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on:https://chromium-review.googlesource.com/559591
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & not in Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3150.0

Comment 3 by yiyix@chromium.org, Jul 10 2017

Cc: yiyix@chromium.org x...@chromium.org msw@chromium.org harpreet@chromium.org nek...@chromium.org jamescook@chromium.org
 Issue 740627  has been merged into this issue.

Comment 4 by yiyix@chromium.org, Jul 11 2017

Cc: lfg@chromium.org
 Issue 741035  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/528b5d650eba7b4ded686622888a20d4e0a27b1b

commit 528b5d650eba7b4ded686622888a20d4e0a27b1b
Author: yiyix <yiyix@chromium.org>
Date: Wed Jul 12 16:13:39 2017

Remove unwanted text caret in 'URL' text filed of "Edit" bookmark overlay

The |cursor_view| in Textfield uses the default construction of view, 
where the cursor is always initialized as visible. It was showing in some 
default location before landing fix of bug  crbug.com/734988 . It now shows 
in the beginning of the Textfield instead. As a result, an unwanted text 
cursor is displayed to users. In this change, after calling  
UpdateCursorViewLocation, UpdateCursorVisibility is added to adjust the 
visibility.  

Bug:  739607 
Change-Id: I3243857173c9c30cb0da11eae31f030e26771bd7
Reviewed-on: https://chromium-review.googlesource.com/564019
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485983}
[modify] https://crrev.com/528b5d650eba7b4ded686622888a20d4e0a27b1b/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/528b5d650eba7b4ded686622888a20d4e0a27b1b/ui/views/controls/textfield/textfield_unittest.cc

Comment 6 by yiyix@chromium.org, Jul 13 2017

 Issue 742048  has been merged into this issue.

Comment 7 by yiyix@chromium.org, Jul 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment