Implement new object lifetime/deletion semantics |
|||||||||||||||||
Issue descriptionMozilla gave some thought to the semantics of deleting objects that can be attached to container objects in https://github.com/KhronosGroup/WebGL/pull/2178 , in particular WebGLBuffers that are hooked up to WebGLVertexArrayObjects. Chrome needs to implement the new semantics. This involves avoiding doing redundant work during calls like DeleteBuffer, and deferring answering "false" for IsBuffer longer than Chrome currently does. Note per last comment on that pull request there may be a problem with the new semantics, but we probably won't figure that out fully until implementing them.
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a58703a885159856b5bce37a4c7798a7c481ae39 commit a58703a885159856b5bce37a4c7798a7c481ae39 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Jul 07 04:31:43 2017 Roll WebGL 9ffa3b5..5e57726 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/9ffa3b5..5e57726 BUG= 731324 , 735784 , 736499 , 739604 , angleproject:2095 TBR=kainino@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie2ef09eaf2087059d1c3dd190c4098993cd7ec61 Reviewed-on: https://chromium-review.googlesource.com/562857 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#484832} [modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/DEPS [modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
Jul 9
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
Still needs to be done in order to pass the WebGL conformance suite.
,
Aug 2
,
Oct 24
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/319faa6f9fc6bb050759c111202dbb61ba99086d commit 319faa6f9fc6bb050759c111202dbb61ba99086d Author: Kenneth Russell <kbr@chromium.org> Date: Wed Oct 24 17:21:44 2018 Roll WebGL 6d2f3f4..0d55c88 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6d2f3f4..0d55c88 Includes suppressions for the following failures: conformance/rendering/rendering-sampling-feedback-loop.html conformance2/textures/misc/tex-mipmap-levels.html conformance2/textures/image_bitmap_from_video/ tex-2d-rgb565-rgb-unsigned_short_5_6_5.html deqp/functional/gles3/lifetime.html deqp/functional/gles3/shaderoperator/common_functions_*.html Bug: 660844, 739604 , 766918, 849576, 886970, 890002 , 890539, 898350 , 898351 , angleproject:2832 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I85be441fa86090e5ed056a9366452248985693e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297570 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602377} [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/DEPS [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
Nov 27
,
Nov 27
,
Dec 21
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5394466865517b38f95c074e43efddde95875d6b commit 5394466865517b38f95c074e43efddde95875d6b Author: James Darpinian <jdarpinian@chromium.org> Date: Fri Dec 21 05:30:26 2018 WebGL: Check object deletion flag Bug: 916924 , 739604 Change-Id: I36f6280226e3c03ed8ae89bd9ff59a82631a9a21 Reviewed-on: https://chromium-review.googlesource.com/c/1388032 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#618464} [modify] https://crrev.com/5394466865517b38f95c074e43efddde95875d6b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99488969407932b90aab9a881cbf71246f48dd6b commit 99488969407932b90aab9a881cbf71246f48dd6b Author: James Darpinian <jdarpinian@chromium.org> Date: Fri Dec 21 22:00:16 2018 WebGL: Check object deletion flag Bug: 916924 , 739604 Change-Id: I36f6280226e3c03ed8ae89bd9ff59a82631a9a21 Reviewed-on: https://chromium-review.googlesource.com/c/1388032 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618464}(cherry picked from commit 5394466865517b38f95c074e43efddde95875d6b) Reviewed-on: https://chromium-review.googlesource.com/c/1388563 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#508} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/99488969407932b90aab9a881cbf71246f48dd6b/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99488969407932b90aab9a881cbf71246f48dd6b Commit: 99488969407932b90aab9a881cbf71246f48dd6b Author: jdarpinian@chromium.org Commiter: jdarpinian@chromium.org Date: 2018-12-21 22:00:16 +0000 UTC WebGL: Check object deletion flag Bug: 916924 , 739604 Change-Id: I36f6280226e3c03ed8ae89bd9ff59a82631a9a21 Reviewed-on: https://chromium-review.googlesource.com/c/1388032 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618464}(cherry picked from commit 5394466865517b38f95c074e43efddde95875d6b) Reviewed-on: https://chromium-review.googlesource.com/c/1388563 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#508} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 5
,
Jan 8
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00e490b0346f2d22d5ec47cae3a9d4d591428fa5 commit 00e490b0346f2d22d5ec47cae3a9d4d591428fa5 Author: Kenneth Russell <kbr@chromium.org> Date: Tue Jan 08 22:50:42 2019 Fix handling of deleted WebGL objects. When WebGL objects are deleted manually, it is supposed to be illegal to pass them back into the API. The earlier code was not enforcing this rule properly. Add consistent validation functions to WebGLRenderingContextBase, and improve the naming and semantics of the associated helper functions. Programs and shaders are handled specially in the ES 3.0 specification and dEQP tests, and have a couple of carve-outs. This fixes longstanding failures of the WebGL 1.0 and 2.0 vertex array object conformance tests, as well as several other failures uncovered by new and strengthened conformance tests in https://github.com/KhronosGroup/WebGL/pull/2764 . Bug: 739604 Change-Id: Ia7fad75beefc6c0ca5915662235b49cace17f9ba Reviewed-on: https://chromium-review.googlesource.com/c/1389615 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#620917} [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/ext_disjoint_timer_query.cc [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/ext_disjoint_timer_query_webgl2.cc [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/oes_vertex_array_object.cc [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/webgl_multiview.cc [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/webgl_object.cc [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/webgl_object.h [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h [modify] https://crrev.com/00e490b0346f2d22d5ec47cae3a9d4d591428fa5/third_party/blink/renderer/modules/webgl/webgl_shared_platform_3d_object.cc
,
Jan 9
,
Jan 9
,
Jan 9
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95f04483a1655984eb27ae004ee1ada05e4a73f1 commit 95f04483a1655984eb27ae004ee1ada05e4a73f1 Author: Kenneth Russell <kbr@chromium.org> Date: Wed Jan 09 03:16:37 2019 Roll WebGL a2b3563..f22b9ad https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a2b3563..f22b9ad Bug: 739604 Tbr: jdarpinian@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I4292af75c9dae2ecd8afd34ac37f025addfb3349 Reviewed-on: https://chromium-review.googlesource.com/c/1401602 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#621028} [modify] https://crrev.com/95f04483a1655984eb27ae004ee1ada05e4a73f1/DEPS [modify] https://crrev.com/95f04483a1655984eb27ae004ee1ada05e4a73f1/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
Jan 9
,
Jan 9
This is fixed, modulo bugs only happening with the passthrough command decoder, and being tested on the waterfall. |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by kbr@chromium.org
, Jul 6 2017