New issue
Advanced search Search tips

Issue 739603 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 732668



Sign in to add a comment

Remove mime_util and link_header_util dependency from Blink

Project Member Reported by kinuko@chromium.org, Jul 6 2017

Issue description

Maybe just moving it into a better place that can be referenced from Blink and browser-side code (e.g. WebKit/common), or make it header-only things and have it in WebKit/public.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74702f9f9999ec901ab18b34f29fe8655dc237fc

commit 74702f9f9999ec901ab18b34f29fe8655dc237fc
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Mon Jul 31 03:27:53 2017

Move components/mime_util to WebKit/common

Bug: 739603
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I4ea6792a6412df74225da50db214889bb1d02a26
Reviewed-on: https://chromium-review.googlesource.com/588875
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490703}
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/DEPS
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/media_galleries/fileapi/media_path_filter.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/media_galleries/fileapi/supported_audio_video_checker.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/predictors/loading_data_collector.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/ui/cocoa/drag_util.mm
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/components/BUILD.gn
[delete] https://crrev.com/81c1febb8eeccc4e1620f014a90975cd301726cb/components/mime_util/BUILD.gn
[delete] https://crrev.com/81c1febb8eeccc4e1620f014a90975cd301726cb/components/mime_util/mime_util.h
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/browser/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/browser/DEPS
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/child/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/child/DEPS
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/child/blink_platform_impl.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/public/common/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/public/common/DEPS
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/content/public/common/drop_data.cc
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/Source/platform/network/DEPS
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/Source/platform/network/NetworkUtils.cpp
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp
[add] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/BUILD.gn
[modify] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/DEPS
[add] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/common_export.h
[rename] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/mime_util/DEPS
[rename] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/mime_util/OWNERS
[rename] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/mime_util/mime_util.cc
[add] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/mime_util/mime_util.h
[rename] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/mime_util/mime_util_unittest.cc
[add] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/test/run_all_unittests.cc
[add] https://crrev.com/74702f9f9999ec901ab18b34f29fe8655dc237fc/third_party/WebKit/common/test/run_all_unittests.h

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug -Hotlist-Recharge-Cold Type-Task
Status: Assigned (was: Untriaged)
loading triage:
mime_util was moved to //third_party/blink/public/common/mime_util/ and //third_party/blink/common/mime_util by kinuko's CL at #3.

link_header_util is now placed at //components/link_header_util/

Kinuko, do you think we need other works for this bug? Otherwise, let's close.

Sign in to add a comment