New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739601 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference in blink::LayoutObject::SetShouldDoFullPaintInvalidationWithoutGeometryChange

Project Member Reported by ClusterFuzz, Jul 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5786036272889856

Fuzzer: inferno_twister
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x0000007b
Crash State:
  blink::LocalFrameView::ScheduleVisualUpdateForPaintInvalidationIfNeeded
  blink::LayoutObject::SetShouldDoFullPaintInvalidationWithoutGeometryChange
  blink::LayoutObject::SetShouldDoFullPaintInvalidation
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=483471:483525

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5786036272889856


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Labels: M-61 Test-Predator-Wrong
Owner: joelhockey@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "localframeview.cpp" assigning to the concern owner.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/fa221b2627217d88cf5d8823b9330eae1d7df2fc

@joelhockey -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Owner: wangxianzhu@chromium.org
I've had a look at this.  It is the class LayoutObject that has the null reference, rather than LocalFrameView.

Reassigning to @wangxianzhu who appears to be familiar with this code.
Do you need to guard this line for the case where FrameView has been detached and is null?
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/LayoutObject.cpp?l=3483&rcl=b10ef0b9cfc8c2de5c363275a6af8068e58df525

Summary: Null-dereference in blink::LayoutObject::SetShouldDoFullPaintInvalidationWithoutGeometryChange (was: Null-dereference in blink::LocalFrameView::ScheduleVisualUpdateForPaintInvalidationIfNeeded)
Updated title
Project Member

Comment 4 by ClusterFuzz, Jul 12 2017

ClusterFuzz has detected this issue as fixed in range 485497:485520.

Detailed report: https://clusterfuzz.com/testcase?key=5786036272889856

Fuzzer: inferno_twister
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x0000007b
Crash State:
  blink::LocalFrameView::ScheduleVisualUpdateForPaintInvalidationIfNeeded
  blink::LayoutObject::SetShouldDoFullPaintInvalidationWithoutGeometryChange
  blink::LayoutObject::SetShouldDoFullPaintInvalidation
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=483471:483525
Fixed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=485497:485520

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5786036272889856


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Jul 12 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5786036272889856 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment