NTP Flags Contain References to Removed #enable-ntp-snippets Flag
Reported by
13hu...@gmail.com,
Jul 6 2017
|
||||
Issue descriptionSteps to reproduce the problem: 1. chrome://flags 2. Find "see #enable-ntp-snippets" What is the expected behavior? What went wrong? 8 of the NTP flags reference the nonexistent #enable-ntp-snippets flag in their descriptions. These references should have been removed when that flag got removed in Chrome 58 Did this work before? N/A Chrome version: 59.0.3071.125 Channel: stable OS Version: 6.0.1 Flash Version: See also Issue 717803
,
Jul 6 2017
+vitalii@ I think most of the flags are yours? Can we also remove some extra features? Like Physical web, remote tabs etc?
,
Jul 7 2017
The feature was renamed in https://codereview.chromium.org/2655263003, I will do a followup removing the dangling mentions. Regarding extra features, I created issue 740036.
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0f43e95839d59d443be8ad29542c788d5faad13 commit d0f43e95839d59d443be8ad29542c788d5faad13 Author: Vitalii Iarko <vitaliii@chromium.org> Date: Fri Jul 07 12:14:56 2017 [NTP::Cleanup] Remove dangling mentions of #enable-ntp-snippets. The flag itself was renamed in https://codereview.chromium.org/2655263003. Bug: 739584 Change-Id: Ic7b648cda606cbd2710886c60f7f50b96f23dffa Reviewed-on: https://chromium-review.googlesource.com/563201 Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#484894} [modify] https://crrev.com/d0f43e95839d59d443be8ad29542c788d5faad13/chrome/browser/flag_descriptions.cc
,
Jul 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by krav...@chromium.org
, Jul 6 2017Owner: dgn@chromium.org
Status: Assigned (was: Unconfirmed)