New issue
Advanced search Search tips

Issue 739578 link

Starred by 2 users
Status: Fixed
Owner:
aga...@chromium.org
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PolyRietveld has two links forcing different polygerrit URL params.

Project Member Reported by lgar...@chromium.org, Jul 6 2017 
What steps will reproduce the problem?
(1) Visit https://codereview.chromium.org/ with the "non-deprecated" Polymer Rietveld UI.
(2) Click on "Open Gerrit"

What is the expected result?
End up in the Polymer Gerrit UI, or end up in whichever UI has a cookie set.

What happens instead?
?polygerrit=0
Screen Shot 2017-07-05 at 18.28.52.png
352 KB View Download

Comment 1 by lgar...@chromium.org, Jul 6 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/0787481f99d841836785fb13a132daf4d0a0f857

commit 0787481f99d841836785fb13a132daf4d0a0f857
Author: Aaron Gable <agable@chromium.org>
Date: Thu Jul 06 17:31:21 2017
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/25c28697394836a306875345b476014092229c79

commit 25c28697394836a306875345b476014092229c79
Author: Aaron Gable <agable@chromium.org>
Date: Thu Jul 06 17:33:51 2017

Fix terrible typo in Rietveld link to PolyGerrit

Bug:  739578 
Change-Id: I8f7bbb08ba021816c905055aed7ed4d461f1a012
Reviewed-on: https://chromium-review.googlesource.com/562097
Reviewed-by: Katie Thomas <katthomas@google.com>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/25c28697394836a306875345b476014092229c79/appengine/chromium_rietveld/new_static/components/cr-app.html

Comment 5 by aga...@chromium.org, Jul 6 2017

Status: Fixed (was: Started)
Both changes have been deployed. Thanks for finding this!
►

Sign in to add a comment