New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739553 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DTP: Network.enableRequestInterception should be Network.setRequestInterceptionEnabled

Project Member Reported by pfeldman@chromium.org, Jul 5 2017

Issue description

For consistency...
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efbc4622124b43235b32c6428b275acf62e96f7d

commit efbc4622124b43235b32c6428b275acf62e96f7d
Author: Alex Clarke <alexclarke@chromium.org>
Date: Fri Jul 07 18:21:59 2017

Rename enableRequestInterception to setRequestInterceptionEnabled

Bug:  739553 
Change-Id: Ia505463664123245200fb94f37a7a1178df4fc18
Reviewed-on: https://chromium-review.googlesource.com/563385
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484989}
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/content/browser/devtools/devtools_url_request_interceptor.h
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/headless/lib/frame_id_browsertest.cc
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/interception-test.js
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/efbc4622124b43235b32c6428b275acf62e96f7d/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json

Status: Fixed (was: Assigned)

Sign in to add a comment