This is step 1 from Issue 738611. 1. Modify our code to conform to "hybrid" mode, while still using Polymer 1. See that issue for details. See also: https://www.polymer-project.org/2.0/docs/upgrade#upgrade-strategy
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7759504f2a5d6145db6d102c7fd15cf614def66 commit e7759504f2a5d6145db6d102c7fd15cf614def66 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Jul 06 02:14:58 2017 [Polymer2] move style in dom-module into template This CL moves the <style> within a <dom-module> into the <template>. (It's easier to look at the diffs that try to parse that, but it means I moved <style> tags into <template> tags). Placing <style> within <template> is the intended 'new way' that Polymer 2 demands. Polymer 1 allows either placement of the <style> tags. This is a step toward Polymer 2 that doesn't interfere with the current use of Polymer 1. TBR=fukino@chromium.org (code health) Bug: 739532 Change-Id: Iff9d324e4df32661294f13f72d334513cb8d3a10 Reviewed-on: https://chromium-review.googlesource.com/560697 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#484445} [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/chrome/browser/resources/settings/controls/settings_radio_group.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/file_manager/file_manager/foreground/elements/files_ripple.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/file_manager/file_manager/foreground/elements/files_safe_media.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/file_manager/file_manager/foreground/elements/files_toast.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/file_manager/file_manager/foreground/elements/files_tooltip.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/webui/resources/cr_elements/policy/cr_policy_indicator.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html [modify] https://crrev.com/e7759504f2a5d6145db6d102c7fd15cf614def66/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f554301a3f844613539ae835ec0fdfbbd78202ee commit f554301a3f844613539ae835ec0fdfbbd78202ee Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Jul 14 23:49:17 2017 [Polymer2] content to slot on simple cases This CL changes some old content Polymer slotting with the newer keyword slot. These are the simple, unnamed cases in MD settings. The cases that use slot names will be done separately. Bug: 739532 Change-Id: I7a4bd4c186f1e4e576bb19569bdd45a9264a1ff0 Reviewed-on: https://chromium-review.googlesource.com/564062 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#486945} [modify] https://crrev.com/f554301a3f844613539ae835ec0fdfbbd78202ee/chrome/browser/resources/settings/controls/controlled_radio_button.html [modify] https://crrev.com/f554301a3f844613539ae835ec0fdfbbd78202ee/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/f554301a3f844613539ae835ec0fdfbbd78202ee/chrome/browser/resources/settings/controls/settings_radio_group.html [modify] https://crrev.com/f554301a3f844613539ae835ec0fdfbbd78202ee/chrome/browser/resources/settings/settings_page/settings_subpage.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03a5bd08a162540c03eb00b3b6e275e582d2f3ec commit 03a5bd08a162540c03eb00b3b6e275e582d2f3ec Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jul 19 00:07:24 2017 [MD settings] use slot and slotted polymer hybrid for cr-dialog This CL changes cr-dialog to use ::slotted() CSS and slot="" and name="" style matching for slotting contents. Bug: 739532 Change-Id: Ief250f404b0408f79e231af080df431d28dd2637 Reviewed-on: https://chromium-review.googlesource.com/572159 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487678} [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/chromeos/emulator/audio_settings.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/chromeos/login/offline_gaia.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/chromeos/login/saml_confirm_password.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_bookmarks/command_manager.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_bookmarks/edit_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_extensions/load_error.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_extensions/options_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_extensions/pack_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_history/history_list.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_user_manager/error_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/md_user_manager/import_supervised_user.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/about_page/update_warning_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/device_page/display_overscan_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/device_page/drive_cache_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/internet_page/network_proxy.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/internet_page/network_siminfo.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/languages_page/add_languages_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/people_page/import_data_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/people_page/password_prompt_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/people_page/users_add_user_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/reset_page/powerwash_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/reset_page/reset_profile_banner.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/site_settings/add_site_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/03a5bd08a162540c03eb00b3b6e275e582d2f3ec/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
FYI, I am converting some occurrences of <content> to <slot> in MD Settings at https://chromium-review.googlesource.com/590529. Mentioning to avoid duplicate work.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d2472111e77064f80cbc2fd15f76b6746d9bab3 commit 1d2472111e77064f80cbc2fd15f76b6746d9bab3 Author: dpapad <dpapad@chromium.org> Date: Fri Jul 28 01:10:58 2017 MD Settings: Migrate most occurrences of <content> to <slot> Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0c915885b70b618cabe778a1a1e6fc4e288de26d Reviewed-on: https://chromium-review.googlesource.com/590529 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#490174} [modify] https://crrev.com/1d2472111e77064f80cbc2fd15f76b6746d9bab3/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html [modify] https://crrev.com/1d2472111e77064f80cbc2fd15f76b6746d9bab3/chrome/browser/resources/settings/controls/settings_toggle_button.html [modify] https://crrev.com/1d2472111e77064f80cbc2fd15f76b6746d9bab3/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/1d2472111e77064f80cbc2fd15f76b6746d9bab3/chrome/browser/resources/settings/settings_page/settings_animated_pages.html [modify] https://crrev.com/1d2472111e77064f80cbc2fd15f76b6746d9bab3/chrome/browser/resources/settings/settings_page/settings_section.html [modify] https://crrev.com/1d2472111e77064f80cbc2fd15f76b6746d9bab3/chrome/browser/resources/settings/settings_page/settings_subpage.html [modify] https://crrev.com/1d2472111e77064f80cbc2fd15f76b6746d9bab3/chrome/browser/resources/settings/system_page/system_page.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99ccdeff6bb76eecb2d49c52c28bbaf7a88be267 commit 99ccdeff6bb76eecb2d49c52c28bbaf7a88be267 Author: dpapad <dpapad@chromium.org> Date: Sat Jul 29 04:42:39 2017 MD Settings: Migrate remaining occurrences of <content> to <slot> Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75215b4a8363cdfd403e54d584f63670d5a11b64 Reviewed-on: https://chromium-review.googlesource.com/590953 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#490625} [modify] https://crrev.com/99ccdeff6bb76eecb2d49c52c28bbaf7a88be267/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html [modify] https://crrev.com/99ccdeff6bb76eecb2d49c52c28bbaf7a88be267/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e93362b902955b808fea7db06fb2d97c351549 commit f2e93362b902955b808fea7db06fb2d97c351549 Author: dpapad <dpapad@chromium.org> Date: Wed Aug 09 06:56:46 2017 WebUI: Convert <content> to <slot> in md-user-manager and PDF viewer. Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id955b6047810879a54c865ce08a0932167541593 Reviewed-on: https://chromium-review.googlesource.com/607091 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#492871} [modify] https://crrev.com/f2e93362b902955b808fea7db06fb2d97c351549/chrome/browser/resources/md_user_manager/user_manager_pages.html [modify] https://crrev.com/f2e93362b902955b808fea7db06fb2d97c351549/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2d1e7c07dd748c4697951ea386d6d0097fc6599 commit a2d1e7c07dd748c4697951ea386d6d0097fc6599 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Aug 09 22:12:36 2017 [Polymer] change cr-drawer from content to slot This CL changes the <content> use in cr_drawer.html to use <slot> as part of the transition to Polymer 2. Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9da9dfa1a18d4e5e29cd742170643b6217fdb730 Reviewed-on: https://chromium-review.googlesource.com/606936 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#493160} [modify] https://crrev.com/a2d1e7c07dd748c4697951ea386d6d0097fc6599/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27ce4da734ec5534c21cd44fa5d7a26ff4a6189d commit 27ce4da734ec5534c21cd44fa5d7a26ff4a6189d Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Dec 13 22:39:12 2017 [CR elements] migrate some <content> use to <slot> This CL is a step toward using Polymer 2. It converts some uses of <content> (the Polymer 1 way) to <slot> (the Polymer 2 way of slotting in items). Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I745ccd5ace1bde2254ce4daa63e254184281affe Reviewed-on: https://chromium-review.googlesource.com/820556 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#523920} [modify] https://crrev.com/27ce4da734ec5534c21cd44fa5d7a26ff4a6189d/chrome/browser/resources/md_downloads/toolbar.html [modify] https://crrev.com/27ce4da734ec5534c21cd44fa5d7a26ff4a6189d/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.html [modify] https://crrev.com/27ce4da734ec5534c21cd44fa5d7a26ff4a6189d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcb8207757197226745edb5139e3e20132f54ce2 commit dcb8207757197226745edb5139e3e20132f54ce2 Author: dpapad <dpapad@chromium.org> Date: Thu Feb 08 20:30:08 2018 Settings WebUI: Adjust CSS var() syntax to conform to Polymer 2 hybrid. Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib16001c996351c4aaf86a6d9f9c33aca36c56714 Reviewed-on: https://chromium-review.googlesource.com/907869 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#535495} [modify] https://crrev.com/dcb8207757197226745edb5139e3e20132f54ce2/chrome/browser/resources/settings/controls/controlled_radio_button.html [modify] https://crrev.com/dcb8207757197226745edb5139e3e20132f54ce2/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ddf088932ac84967a29c0bb0e5978e7feab3dd1 commit 9ddf088932ac84967a29c0bb0e5978e7feab3dd1 Author: dpapad <dpapad@chromium.org> Date: Thu Feb 08 20:51:42 2018 WebUI Polymer 2 migration: Update @apply syntax in various pages. Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I111d512efcfc88cb04c9639046da3498a9397e96 Reviewed-on: https://chromium-review.googlesource.com/907738 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#535504} [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_bookmarks/list.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_downloads/manager.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_extensions/item_list.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_history/history_item.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_history/history_list.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_history/synced_device_card.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_user_manager/shared_styles.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/md_user_manager/user_manager.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/media_router/elements/route_details/route_details.css [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/print_preview/new/button_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/print_preview/new/checkbox_radio_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/print_preview/new/select_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/controls/controlled_radio_button.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/controls/extension_controlled_indicator.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/controls/important_site_checkbox.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/controls/settings_toggle_button.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/device_page/display_layout.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/device_page/stylus.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/internet_page/internet_subpage.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/people_page/fingerprint_list.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/search_engines_page/search_engines_list.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/search_engines_page/search_engines_page.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/settings_page/settings_section.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/settings_page/settings_subpage.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/settings_ui/settings_ui.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_components/chromeos/network/network_proxy_exclusions.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/cr_icons_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/paper_toggle_style_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/cr_elements/shared_style_css.html [modify] https://crrev.com/9ddf088932ac84967a29c0bb0e5978e7feab3dd1/ui/webui/resources/html/action_link_css.html
Found one more class of changes that need to happen before migrating to 2. Specifically need to update is="custom-style" and :root as described at [1]. See example CL at [2]. [1] https://www.polymer-project.org/2.0/docs/upgrade#shadow-dom-styles [2] https://chromium-review.googlesource.com/c/chromium/src/+/1077666
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7 commit 40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7 Author: dpapad <dpapad@chromium.org> Date: Mon Jun 04 20:41:43 2018 WebUI Polymer2 migration: Update is="custom-style" to <custom-style>. While in 1.x hybrid mode, need to use both <custom-style> <style is="custom-style">..</style> </custom-style> Once in 2.x, the is="custom-style" part can be fully dropped. Also updating various instances of ":root" per upgrade guide. Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ec732f6485b3ff584da0ca62c933a9ad62037a2 Reviewed-on: https://chromium-review.googlesource.com/1077666 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#564221} [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/chromeos/emulator/device_emulator.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/md_bookmarks/shared_vars.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/md_history/shared_vars.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/md_user_manager/shared_styles.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/md_user_manager/user_manager.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/pdf/elements/shared-vars.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/print_preview/new/print_preview_shared_css.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/chrome/browser/resources/settings/settings_vars_css.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/ui/webui/resources/cr_elements/paper_input_style_css.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/ui/webui/resources/cr_elements/shared_vars_css.html [modify] https://crrev.com/40fe0a230281f3d8711c8efdb38ad9a8fc37ffc7/ui/webui/resources/html/md_select_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c54a56ee4b550623b7c1ad87b7bbc6b7a9d5a4d commit 5c54a56ee4b550623b7c1ad87b7bbc6b7a9d5a4d Author: dpapad <dpapad@chromium.org> Date: Sat Jun 30 04:17:25 2018 WebUI Polymer 2: Eliminate last usage of "dom-module is=". Instead "dom-module id=" should be used everywhere. This change makes CrSettingsFocusRowBehavior.FocusTest pass in Polymer 2. Bug: 739532 Change-Id: I9ae09e78e5239bc7432845d4ced9632811d4a7cc Reviewed-on: https://chromium-review.googlesource.com/1121582 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571760} [modify] https://crrev.com/5c54a56ee4b550623b7c1ad87b7bbc6b7a9d5a4d/chrome/test/data/webui/settings/focus_row_behavior_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4970f410b0be68995a987df5218a63cdb62c97e commit f4970f410b0be68995a987df5218a63cdb62c97e Author: dpapad <dpapad@chromium.org> Date: Sat Sep 15 01:00:46 2018 ChromeOS WebUI: Import the correct polymer.html config file everywhere. When importing Polymer, the following file should always be used chrome://resources/html/polymer.html Instead of third_party's chrome://resources/polymer/v1_0/polymer/polymer.html The former properly configures Polymer to use native Shadow DOM (among other settings). This is in preparation of the Polymer 2 migration, which forces the usage of Shadow DOM by default. Bug: 739532 Change-Id: I456527da1e2dc3765d78b0f4f3436678722d1347 Reviewed-on: https://chromium-review.googlesource.com/1227174 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#591544} [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/custom_elements_lock.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/custom_elements_user_pod.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/gaia_header.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/gaia_input_form.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/html-echo.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/offline_ad_login.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/oobe-screen.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/oobe.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/saml_interstitial.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/unrecoverable_cryptohome_error_card.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/login/update_required_card.html [modify] https://crrev.com/f4970f410b0be68995a987df5218a63cdb62c97e/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c696feb73f73be9cc174fb617762f6a5c54af849 commit c696feb73f73be9cc174fb617762f6a5c54af849 Author: dpapad <dpapad@chromium.org> Date: Thu Sep 27 17:19:20 2018 File Manager: Update remaining <style is="custom-style"> for Polymer 2. per Polymer 2 migration guide: - wrap <style is="custom-style"> with <custom-style> - move <custom-style> inside <body> Bug: 739532 Change-Id: I089208681d14e19e71251a41e80bd024c02d1b3a Reviewed-on: https://chromium-review.googlesource.com/1247530 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594762} [modify] https://crrev.com/c696feb73f73be9cc174fb617762f6a5c54af849/ui/file_manager/gallery/gallery.html [modify] https://crrev.com/c696feb73f73be9cc174fb617762f6a5c54af849/ui/file_manager/video_player/video_player.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d4bc971b10234d6d11cc8fefc49b8982096d122 commit 2d4bc971b10234d6d11cc8fefc49b8982096d122 Author: dpapad <dpapad@chromium.org> Date: Thu Sep 27 21:25:13 2018 File Manager: Use :not(:defined) instead of :unresolved for Polymer 2. Bug: 739532, 875525 Change-Id: I4bf43b572eb7a9417f373b414ef101d1d580ef4b Reviewed-on: https://chromium-review.googlesource.com/1249840 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594870} [modify] https://crrev.com/2d4bc971b10234d6d11cc8fefc49b8982096d122/ui/file_manager/file_manager/foreground/css/file_manager.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c79ead06c24400f12c150529a5ec55060577f87 commit 5c79ead06c24400f12c150529a5ec55060577f87 Author: dpapad <dpapad@chromium.org> Date: Thu Oct 18 19:39:03 2018 Fix sync-confirmation dialog styling in Polymer 2. Need to wrap <style is="custom-style"> with <custom-style> such that styling works both in Polymer 1 and Polymer 2. Bug: 739532, 896507 Change-Id: I40e4a1fa6ac071cc31268c5e86fa13a023a59490 Reviewed-on: https://chromium-review.googlesource.com/c/1287258 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600868} [modify] https://crrev.com/5c79ead06c24400f12c150529a5ec55060577f87/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81a077ccc718aefac3fb85015c7bea264f9993e2 commit 81a077ccc718aefac3fb85015c7bea264f9993e2 Author: rbpotter <rbpotter@chromium.org> Date: Tue Oct 23 19:19:31 2018 MD User Manager: Update <style is="custom-style"> for Polymer 2 Wrapping <style is="custom-style"> with <custom-style> per Polymer 2 migration guide. This also fixes a styling issue with the remove user button, which occurred when Polymer 2 was turned on by default. Bug: 896583 , 739532 Change-Id: Ic7648996881b945cad2895e675c45afcb095daf0 Reviewed-on: https://chromium-review.googlesource.com/c/1294593 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602046} [modify] https://crrev.com/81a077ccc718aefac3fb85015c7bea264f9993e2/chrome/browser/resources/md_user_manager/user_manager.html [modify] https://crrev.com/81a077ccc718aefac3fb85015c7bea264f9993e2/ui/login/account_picker/md_user_pod_template.html
Comment 1 by bugdroid1@chromium.org
, Jul 6 2017