New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739529 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Figure out key handling responsibilities between pdf.js and PDFiumEngine

Project Member Reported by thestig@chromium.org, Jul 5 2017

Issue description

For the PDF Viewer, some of the key handling code is in chrome/browser/resources/pdf/pdf.js, where handleKeyEvent_() has a chance to intercept DOM keydown events. The rest is in PDFiumEngine (in C++) where it has OnKeyDown(), OnChar(), and OnKeyUp() methods.

We should figure out when to handle an event in JS vs when to handle it in C++. We do not want to end up in a situation where some developers handle keyboard events in JS, and others handle similar events in C++.

Furthermore, sometimes the JS key handling code ends up calling KeyboardEvent.preventDefault(). From the C++ side, PDFiumEngine::OnKeyDown() gets skipped, but OnChar() and OnKeyUp() still get called. Should OnChar() and OnKeyUp() be prevented as well somehow? Or should the C++ code just expect and handle OnKeyUp() calls without a corresponding OnKeyDown() call?
 
Owner: dsinclair@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Owner: ----
Status: Untriaged (was: Assigned)
Setting PDF bugs assigned to me back to untriaged so they can get re-assigned as needed.
Status: Available (was: Untriaged)

Sign in to add a comment