Initially most text in MD Settings was intentionally not selectable by the user, and the text that was selectable was explicitly marked as such with additional logic, see [1]. Later at [2] a top-level "user-select: text" was specified which makes all of the UI text selectable (see screenshot), making most CSS rules at [1] redundant. If allowing all text to be selected is indeed the desired behavior, then we should remove all redundant user-select logic. [1] https://cs.chromium.org/search/?q=user-select+file:%5Esrc/chrome/browser/resources/settings/+package:%5Echromium$&type=cs [2] https://codereview.chromium.org/2904783003
CL at https://chromium-review.googlesource.com/c/562521/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b18578bd35569b971144d4547ee048b68adf795a commit b18578bd35569b971144d4547ee048b68adf795a Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Jul 07 03:02:52 2017 [MD settings] remove redundant user-select: text css This CL removes -webkit-user-select: text css that were made redundant by CL 2904783003. I also tracked down uses of removed .selectable classes that became unnecessary by removing the css above. Bug: 739518 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I53aa08d2923373a3b52112f3f5dff498da4023f6 Reviewed-on: https://chromium-review.googlesource.com/562521 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#484814} [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/about_page/detailed_build_info.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/site_settings/all_sites.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/browser/resources/settings/site_settings/site_list.html [modify] https://crrev.com/b18578bd35569b971144d4547ee048b68adf795a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
Comment 1 by dschuyler@chromium.org
, Jul 6 2017