New issue
Advanced search Search tips

Issue 739514 link

Starred by 3 users
Status: Fixed
Owner:
hirosh...@chromium.org
Closed: Jul 2017
Cc:
kouhei@chromium.org
neis@chromium.org
hirosh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

load event is fired for inline classic scripts if there is a style sheet that is blocking scripts

Project Member Reported by hirosh...@chromium.org, Jul 5 2017 
<link rel="stylesheet" href="resources/slow.py"></link>
<script onload="foo1()">...some inline script...</script>
<script onload="foo2()">...some inline script...</script>

Are foo1() and foo2() executed?
Chromium (M59 -- M61): Yes / No.
Firefox (54.0): No / No.
Spec: No / No.

Comment 1 by hirosh...@chromium.org, Jul 5 2017

issue739514.html
172 bytes View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a589e1f43f36535e10667213f4ad19e33ad17e3

commit 8a589e1f43f36535e10667213f4ad19e33ad17e3
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Jul 07 02:27:18 2017

Add comprehensive wpt tests for script load/error events

These tests cover
1. all clauses of Step 23 of "prepare a script" in the spec
   https://html.spec.whatwg.org/#prepare-a-script, and
2. all branches around ScriptLoader/HTMLParserScriptRunner
   (but not XMLDocument) that correspond to 1.

Bug: 686281,  739514 ,  715369 
Change-Id: Ib5a7077864ee213f93272c76b3cf38e2d280cc99
Reviewed-on: https://chromium-review.googlesource.com/560636
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484800}
[modify] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/load-error-events-1.html
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/load-error-events-2.html
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/load-error-events-3.html
[delete] https://crrev.com/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/load-event.html
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/load-error-events-inline.html
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/load-error-events.html
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/resources/load-error-events-helpers.js
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/resources/load-error-events.py
[add] https://crrev.com/8a589e1f43f36535e10667213f4ad19e33ad17e3/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/resources/slow.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72f9a4aac2ccfdf18e0618c7fcdc25f1a88cec28

commit 72f9a4aac2ccfdf18e0618c7fcdc25f1a88cec28
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Jul 07 23:29:38 2017

Do not fire load event for inline scripts in HTMLParserScriptRunner

According to the spec: Step 8 of "execute a script block":
https://html.spec.whatwg.org/#execute-the-script-block

This CL stops firing load events for
- parser-inserted inline module scripts without async in HTML,
  i.e. those fall into 1st Clause of Step 23 of "prepare a script"
  ( Issue 715369 ; This CL and [1] stop firing load events of all
  inline module scripts)
- parser-inserted inline classic scripts that fall into
  5th Clause of Step 23 of "prepare a script" ( Issue 739514 )

[1] https://chromium-review.googlesource.com/c/557978/

Bug: 686281,  739514 ,  715369 
Change-Id: Ia1a2e9653bccb99ff47faa1d8b8186c043e83770
Reviewed-on: https://chromium-review.googlesource.com/557972
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485100}
[modify] https://crrev.com/72f9a4aac2ccfdf18e0618c7fcdc25f1a88cec28/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/72f9a4aac2ccfdf18e0618c7fcdc25f1a88cec28/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

Comment 4 by hirosh...@chromium.org, Jul 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment