2 recent reverts got rejected because the culprits were wrong: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.win/WinClang64%20(dbg)/13950 and https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.gpu/GPU%20Win%20Builder/66148 in both try jobs, the revisions that are immediately before culprit is skipped. We may need to modify recipes to make sure the revision that's immediately before culprit be compiled/tested.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/29b855bf2ab4166792399850564491208eefa1c0 commit 29b855bf2ab4166792399850564491208eefa1c0 Author: Chan <chanli@chromium.org> Date: Wed Jul 19 18:29:11 2017 [Findit] Use analyze more strictly when running compile try jobs. We should only use analyze when we will compile revisions linearly. And even then we should not skip the first revision in range. Bug: 739495 Change-Id: I1e7fa99e00ba902479a19352a22be957a59fbe33 Reviewed-on: https://chromium-review.googlesource.com/576807 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/29b855bf2ab4166792399850564491208eefa1c0/scripts/slave/recipes/findit/chromium/compile.expected/compile_affected_targets_only.json [modify] https://crrev.com/29b855bf2ab4166792399850564491208eefa1c0/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_bad_output.json [modify] https://crrev.com/29b855bf2ab4166792399850564491208eefa1c0/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_valid.json [modify] https://crrev.com/29b855bf2ab4166792399850564491208eefa1c0/scripts/slave/recipes/findit/chromium/compile.py [modify] https://crrev.com/29b855bf2ab4166792399850564491208eefa1c0/scripts/slave/recipes/findit/chromium/compile.expected/compile_skipped.json [modify] https://crrev.com/29b855bf2ab4166792399850564491208eefa1c0/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_error_code.json [modify] https://crrev.com/29b855bf2ab4166792399850564491208eefa1c0/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_directory_does_not_exist.json
Comment 1 by chanli@chromium.org
, Jul 10 2017