Issue metadata
Sign in to add a comment
|
Click-and-hold on reload button always yields menu |
||||||||||||||||||||
Issue descriptionAs in summary. That reload menu should only show with devtools up. Robert suspect this is his; ccing him. Will bisect.
,
Jul 5 2017
Ah, the difference is that I only blocked right-click, not click-hold.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36969c47fb5943856ceb8e76dbc65c7df662f0b5 commit 36969c47fb5943856ceb8e76dbc65c7df662f0b5 Author: Robert Sesek <rsesek@chromium.org> Date: Thu Jul 06 18:34:23 2017 [Mac] Do not open the reload button menu on click-hold unless DevTools is open. After f7fd12c1dedd498830bc2e9d049687749dbadcf9, the menu could be opened by click-hold-drag even if DevTools were not open, due to the way MenuButton works. The menu should only be avaiable if DevTools is open. This CL adds a new openMenuOnClickHold property to MenuButton, defaulting to YES, that can be used to disable the click-hold-drag behavior of the button. This is now set for the reload button. In addition, this fixes, enables, and expands MenuButtonTest.OpenOnClickAndHold. Bug: 739467 Bug: 517384 Change-Id: I70d900964734dd5c30f2d97fdfdaa32cd4551544 Reviewed-on: https://chromium-review.googlesource.com/562116 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#484685} [modify] https://crrev.com/36969c47fb5943856ceb8e76dbc65c7df662f0b5/chrome/browser/ui/cocoa/menu_button.h [modify] https://crrev.com/36969c47fb5943856ceb8e76dbc65c7df662f0b5/chrome/browser/ui/cocoa/menu_button.mm [modify] https://crrev.com/36969c47fb5943856ceb8e76dbc65c7df662f0b5/chrome/browser/ui/cocoa/menu_button_unittest.mm [modify] https://crrev.com/36969c47fb5943856ceb8e76dbc65c7df662f0b5/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
,
Jul 6 2017
,
Jul 11 2017
Tested the issue on Mac OS X 10.12.5 using Chrome Dev# 61.0.3153.4 and noticed that the functionality is working as intended. Below are the steps followed -- (i) Launched Chrome and opened Dev Tools. (ii) Click and hold reload button to observe context menu. Attaching a screenshot for reference. Adding TE-Verified labels accordingly. Thank You. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by a...@chromium.org
, Jul 5 2017Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Owner: rsesek@chromium.org