Issue 739462 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	l...@chromium.org
Closed:	Jul 2017
Components:	Platform>DevTools
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	3
Type:	Bug

DevTools: Page.setDocumentContent should not be using diff/patch, should overwrite DOM instead as in document.write.

Project Member Reported by pfeldman@chromium.org, Jul 5 2017

Issue description

Basically, we need to do document.open(), document.write() and document.close() in the implementation.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7299ed5a97695accbb5b04e269ac05ec9366d30b

commit 7299ed5a97695accbb5b04e269ac05ec9366d30b
Author: luoe <luoe@chromium.org>
Date: Sat Jul 08 00:28:52 2017

DevTools: Page.setDocumentContent without using DOMPatchSupport

BUG= 739462 

Review-Url: https://codereview.chromium.org/2972273002
Cr-Commit-Position: refs/heads/master@{#485113}

[add] https://crrev.com/7299ed5a97695accbb5b04e269ac05ec9366d30b/third_party/WebKit/LayoutTests/inspector-protocol/page/setDocumentContent-expected.txt
[add] https://crrev.com/7299ed5a97695accbb5b04e269ac05ec9366d30b/third_party/WebKit/LayoutTests/inspector-protocol/page/setDocumentContent.js
[modify] https://crrev.com/7299ed5a97695accbb5b04e269ac05ec9366d30b/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/7299ed5a97695accbb5b04e269ac05ec9366d30b/third_party/WebKit/Source/core/inspector/DOMPatchSupport.h
[modify] https://crrev.com/7299ed5a97695accbb5b04e269ac05ec9366d30b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Comment 2 by l...@chromium.org, Jul 11 2017

Status: Fixed (was: Assigned)

►

Issue 739462 link

Issue metadata

DevTools: Page.setDocumentContent should not be using diff/patch, should overwrite DOM instead as in document.write.

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 8 2017

Comment 1 Deleted

Comment 2 by l...@chromium.org, Jul 11 2017

Comment 2 Deleted

Sign in to add a comment