Issue 739439 link

Starred by 4 users

Issue metadata

Status:	Fixed
Owner:	alexilin@chromium.org
Closed:	Jul 2017
Cc:	█ twif...@chromium.org █ jamartin@chromium.org sclit...@chromium.org alexilin@chromium.org mattcary@chromium.org pasko@chromium.org lizeb@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Precache

Remove support for precaching resources

Project Member Reported by bengr@chromium.org, Jul 5 2017

Issue description

We are not intending to launch the precache code, so we should delete it.

Affected directories:

components/precache
src/chrome/browser/precache
src/chrome/browser/android/precache
src/chrome/android/java[tests]/src/org/chromium/chrome/browser/precache


There's also a persistent PrecacheDatabase that should be cleared before the code is deleted.

Comment 1 by pasko@chromium.org, Jul 5 2017

Cc: lizeb@chromium.org mattcary@chromium.org alexilin@chromium.org

I think nothing is blocking deletion of said directories. Any objections?

Comment 2 by alexilin@chromium.org, Jul 5 2017

Owner: alexilin@chromium.org
Status: Assigned (was: Available)

Yes, we planned to do this and it was in my backlog for a while. I'll handle it.

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2314148b449e3540a17da95879f2836245c1d421

commit 2314148b449e3540a17da95879f2836245c1d421
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Fri Jul 07 12:49:02 2017

Remove precache code (aka Wi-Fi Prefetch) (1/3)

The project was turned down and the precache code is no longer executed.

Removal will be done in three steps:
1. Unwire precache from chrome/browser/predictors. (current)
2. Delete the rest use of precache.
3. Delete all precache directories.

Bug:  739439 
Change-Id: I3fa933951ee9223396f64ad6a46c159aafdb9b8a
Reviewed-on: https://chromium-review.googlesource.com/561523
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484901}
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/BUILD.gn
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/precache/precache_manager_factory.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/loading_test_util.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/loading_test_util.h
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/resource_prefetch_predictor_tables.h
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/components/precache/content/precache_manager.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/components/precache/content/precache_manager.h
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/components/precache/core/precache_fetcher.h
[modify] https://crrev.com/2314148b449e3540a17da95879f2836245c1d421/components/precache/core/precache_fetcher_unittest.cc

Comment 4 by bengr@chromium.org, Jul 7 2017

Status: Started (was: Assigned)

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a87a53947ecc189c37fec3da875533204826c6d

commit 0a87a53947ecc189c37fec3da875533204826c6d
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed Jul 12 19:08:08 2017

Remove precache code (aka Wi-Fi Prefetch) (2/3)

The project was turned down and the precache code is no longer executed.

Removal is done in three steps:
1. Unwire precache from chrome/browser/predictors. (done http://crrev.com/c/561523)
2. Delete the rest use of precache. (current)
3. Delete all precache directories.

Bug:  739439 
Change-Id: I105e0a79393c884c71d079fa05e11f748b61302a
Reviewed-on: https://chromium-review.googlesource.com/563409
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486046}
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_factory.cc
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/0a87a53947ecc189c37fec3da875533204826c6d/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122

commit d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Mon Jul 17 11:00:12 2017

Remove precache code (aka Wi-Fi Prefetch) (3/3)

The project was turned down and the precache code is no longer executed.

Removal is done in three steps:
1. Unwire precache from chrome/browser/predictors. (done http://crrev.com/c/561523)
2. Delete the rest use of precache. (done http://crrev.com/c/563409)
3. Delete all precache directories. (current)

Bug:  739439 
Change-Id: Ide5e797602a71d2dc657f11b84bed99a2ac17020
Reviewed-on: https://chromium-review.googlesource.com/561538
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487041}
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/chrome/android/BUILD.gn
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/chrome/android/java/DEPS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/java/src/org/chromium/chrome/browser/precache/FailureReason.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/java/src/org/chromium/chrome/browser/precache/OWNERS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheTaskScheduler.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheUMA.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/java/src/org/chromium/chrome/browser/precache/SyncServiceInitializedNotifier.java
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/chrome/android/java_sources.gni
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/chrome/android/javatests/DEPS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/MockPrecacheController.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/OWNERS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheUMATest.java
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/chrome/browser/BUILD.gn
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/chrome/browser/android/chrome_jni_registrar.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/android/precache/precache_launcher.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/android/precache/precache_launcher.h
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/chrome/browser/metrics/chrome_metrics_service_accessor.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/precache/OWNERS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/precache/precache_manager_factory.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/precache/precache_manager_factory.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/precache/precache_util.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/chrome/browser/precache/precache_util.h
[modify] https://crrev.com/d3ae6e94dbbc1b9f49a1ab6c98e607e54641f122/components/BUILD.gn
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/DEPS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/OWNERS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/README
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/android/BUILD.gn
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/android/java/src/org/chromium/components/precache/DeviceState.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/android/java/src/org/chromium/components/precache/NetworkInfoDelegate.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/android/java/src/org/chromium/components/precache/NetworkInfoDelegateFactory.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/android/javatests/src/org/chromium/components/precache/DeviceStateTest.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/android/javatests/src/org/chromium/components/precache/MockDeviceState.java
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/content/BUILD.gn
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/content/DEPS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/content/precache_manager.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/content/precache_manager.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/content/precache_manager_unittest.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/BUILD.gn
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/DEPS
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/fetcher_pool.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/fetcher_pool_unittest.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_database.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_database.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_database_unittest.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_fetcher.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_fetcher.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_fetcher_unittest.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_manifest_util.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_manifest_util.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_referrer_host_table.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_referrer_host_table.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_referrer_host_table_unittest.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_session_table.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_session_table.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_session_table_unittest.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_switches.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_switches.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_url_table.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_url_table.h
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/precache_url_table_unittest.cc
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/proto/precache.proto
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/proto/quota.proto
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/proto/timestamp.proto
[delete] https://crrev.com/e9f72053995eec1a97ac3cef567ca65e7414f29a/components/precache/core/proto/unfinished_work.proto

Comment 7 by alexilin@chromium.org, Jul 17 2017

Status: Fixed (was: Started)

R.I.P.

►

Issue 739439 link

Issue metadata

Remove support for precaching resources

Issue description

Comment 1 by pasko@chromium.org, Jul 5 2017

Comment 1 Deleted

Comment 2 by alexilin@chromium.org, Jul 5 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jul 7 2017

Comment 3 Deleted

Comment 4 by bengr@chromium.org, Jul 7 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jul 12 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jul 17 2017

Comment 6 Deleted

Comment 7 by alexilin@chromium.org, Jul 17 2017

Comment 7 Deleted

Sign in to add a comment