New issue
Advanced search Search tips

Issue 739433 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Test flake: ChromeResourceDispatcherHostDelegateBrowserTest.MirrorRequestHeader

Project Member Reported by ellyjo...@chromium.org, Jul 5 2017

Issue description

This test failed (flaked?) on Win7 Tests dbg:

[ RUN      ] ChromeResourceDispatcherHostDelegateBrowserTest.MirrorRequestHeader
[2256:4616:0705/094705.166:WARNING:chrome_browser_main_win.cc(469)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ChromeResourceDispatcherHostDelegateBrowserTest.MirrorRequestHeader --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\swarm_slave\w\ionycoi7\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4248_5233\d4248_24259" --disable-offline-auto-reload --disable-features=NetworkPrediction --no-first-run --no-default-browser-check --enable-logging=stderr --log-level=0 --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[1532:3424:0705/094705.588:ERROR:direct_composition_surface_win.cc(1007)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE.
[1532:3424:0705/094705.665:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
c:\b\c\b\win\src\chrome\browser\loader\chrome_resource_dispatcher_host_delegate_browsertest.cc(423): error: Value of: base::ContainsKey(*request_headers, url)
  Actual: true
Expected: false
Google Test trace:
c:\b\c\b\win\src\chrome\browser\loader\chrome_resource_dispatcher_host_delegate_browsertest.cc(503): https://www.google.com/
[4872:1224:0705/094710.888:ERROR:render_process_impl.cc(173)] WebFrame LEAKED 1 TIMES
[2256:720:0705/094711.018:ERROR:process_win.cc(140)] Unable to terminate process: Access is denied. (0x5)
[  FAILED  ] ChromeResourceDispatcherHostDelegateBrowserTest.MirrorRequestHeader, where TypeParam =  and GetParam() =  (10329 ms)

I'm not sure if that warning is related or not. rhalavati@, you added this test - can you take a look please? :)
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be1c2597a84d554c3a08234616e2871ac6da1383

commit be1c2597a84d554c3a08234616e2871ac6da1383
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Jul 14 17:05:34 2017

RDHD MirrorRequestHeader browsertest updated.

There was a possible race condition between IO and UI threads in this test.
It is now prevented by adding an extra wait for task completion.

Bug:  739433 
Change-Id: If2060e859cfb001218cee909eafb6739a4e5d314
Reviewed-on: https://chromium-review.googlesource.com/568144
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486786}
[modify] https://crrev.com/be1c2597a84d554c3a08234616e2871ac6da1383/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc

Comment 3 by battre@chromium.org, Jul 14 2017

Cc: mmenke@chromium.org
And here is the output:

[ RUN      ] ChromeResourceDispatcherHostDelegateBrowserTest.MirrorRequestHeader
[4312:2676:0714/125801.734:ERROR:direct_composition_surface_win.cc(1007)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE.
[4312:2676:0714/125801.958:INFO:media_foundation_video_encode_accelerator_win.cc(335)] Windows versions earlier than 8 are not supported.
../../chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc(423): error: Value of: base::ContainsKey(*request_headers, url)
  Actual: true
Expected: false
URL: https://www.redirected.com/, Headers: Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3158.0 Safari/537.36
X-Chrome-UMA-Enabled: 1
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8
Google Test trace:

../../chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc(504): https://www.google.com/

--> This is not a favicon issue!

Let's look into it further on Monday.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abfc73c2f6661c88862d83b57b4e2f79cecdcafb

commit abfc73c2f6661c88862d83b57b4e2f79cecdcafb
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Jul 19 13:45:46 2017

Interceptor changed for RDHD MirrorRequestHeader browsertest.

An extra network request by google_url_tracker caused a flaky bug in 
RDHD::MirrorRequestHeader. This is now prevented by changing interceptor
from hostname to url.

Bug:  739433 
Change-Id: I45f7f518e22d0e8dc3ddf1f3ee26c28a2f287ce4
Reviewed-on: https://chromium-review.googlesource.com/574021
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487847}
[modify] https://crrev.com/abfc73c2f6661c88862d83b57b4e2f79cecdcafb/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc

Status: Fixed (was: Started)
The flaky error has not happened since this update was landed, while it was quite frequent before.

Sign in to add a comment