New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739432 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Invalid config set does not catch invalid configs that begin with "projects/" or "services/"

Project Member Reported by cwpayton@google.com, Jul 5 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Visit luci-config.appspot.com
(2) Navigate to Configuration Service and then to config.get_config_sets
(3) In the config_set field, type in "projects/doesnotexist" or "services/doesnotexist"
(4) Click "Authorize and execute"

What is the expected result?

A 400 error with the error message "invalid config set u'projects/doesnotExist'"

What happens instead?

A config set is returned with information about the config set that was provided (even though it does not exist).


NOTE: If you would like to see expected behavior, type "doesNotExist" into the config_set field without the preceding "projects/" or "services/"
 

Comment 1 by cwpayton@google.com, Jul 10 2017

Description: Show this description

Comment 2 by cwpayton@google.com, Jul 10 2017

Components: Infra>Platform>Config

Comment 3 by estaab@chromium.org, Jul 10 2017

Status: Assigned (was: Untriaged)

Comment 4 by no...@chromium.org, Jul 10 2017

this happens only for admins because the code does not even bother to check if the config set exists. It does not affect users, thus Pri-3 is appropriate.

Comment 5 by no...@chromium.org, Jul 10 2017

Cc: cwpayton@google.com
Owner: ----
Status: Available (was: Assigned)
making it available because we have more important things to do
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 11 2017

Labels: Hotlist-Google
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
With config validation this now actually returns 403, so we should be able to close this as Fixed.

Sign in to add a comment