Edit mode in save passwords list in settings should not allow proceeding to detailed password view |
|||
Issue descriptionCurrently, if the user taps to select a password in the list for deletion, the tap also opens the detailed password view. (To reproduce, enable "Enable View/Copy Passwords" experimental setting.)
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4d8ef261ff7621c5b74a8331fc4b07e4ce23653 commit b4d8ef261ff7621c5b74a8331fc4b07e4ce23653 Author: Vaclav Brozek <vabr@chromium.org> Date: Thu Jul 06 06:04:02 2017 Fix edit mode detection in save password settings view The view controller currently uses self.editing, which seems not working. Querying [self.editor isEditing] works better. BUG= 739425 R=lpromero@chromium.org Change-Id: Ie785bf49dab9eff03e43982ffefbec52bb33e2ae Reviewed-on: https://chromium-review.googlesource.com/559682 Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#484476} [modify] https://crrev.com/b4d8ef261ff7621c5b74a8331fc4b07e4ce23653/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/b4d8ef261ff7621c5b74a8331fc4b07e4ce23653/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
,
Jul 6 2017
,
Oct 6 2017
Verified on 62.0.3202.47 Beta on iOS 11.0 iPad Pro 12'5, iPhone6+ iOS 10.3.3 https://drive.google.com/a/google.com/file/d/0B6GVWQnhaMClM2lwMk9zbUtDa0E/view?usp=sharing |
|||
►
Sign in to add a comment |
|||
Comment 1 by vabr@chromium.org
, Jul 5 2017