New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739422 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
hobby only
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 159166



Sign in to add a comment

Fix colour of the "Site" header in password detail view of settings on iOS

Project Member Reported by vabr@chromium.org, Jul 5 2017

Issue description

It should be grey as the other headers.

(To reproduce, enable "Enable View/Copy Passwords" experimental setting.)
 

Comment 1 by vabr@chromium.org, Jul 5 2017

Description: Show this description

Comment 2 by vabr@chromium.org, Jul 5 2017

Components: UI>Browser>Passwords

Comment 3 by vabr@chromium.org, Jul 5 2017

Labels: Hotlist-Polish

Comment 4 by vabr@chromium.org, Jul 5 2017

Status: Started (was: Assigned)
Uploading screenshot from the fixed version.
Screen Shot 2017-07-05 at 8.18.22 PM.png
87.3 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6bc2a13d1c18a0fa8b432709aa157e8e237540e

commit c6bc2a13d1c18a0fa8b432709aa157e8e237540e
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Jul 05 20:58:50 2017

Make Site header in password detail view grey

BUG= 739422 

Change-Id: Ie228454057953c1ef53c4e22f02d0164cd96a41e
Reviewed-on: https://chromium-review.googlesource.com/559546
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484346}
[modify] https://crrev.com/c6bc2a13d1c18a0fa8b432709aa157e8e237540e/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

Comment 7 by vabr@chromium.org, Jul 6 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on latest chrome beta version 62.0.3202.40. Compared the screen shot in comment# 4.  Looks good.

Sign in to add a comment