New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739415 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6644


Sign in to add a comment

CL summary no longer appears in bug reports

Project Member Reported by shrike@chromium.org, Jul 5 2017

Issue description

With Rietveld, cls that apply to a bug append a link to the cl, a commit link, author name, and the description that the engineer entered for the change. It appears that with Gerrit, only the cl link, commit link, and author name are appended for each change. This means that when I receive an e-mail from the bugreporter about a change to a bug (I am cc'ed, by rule, on a lot of bugs), I can't just read the e-mail to understand the change that was made. I have to click the commit link to get that info. It also means that bugs are now just lists of changes with no info about those changes. To piece together what happened on a bug you have to open a tab for the bug, and then new tabs for each cl. Can the cl description be included in these Gerrit bug updates?

 

Comment 1 by wyatta@google.com, Jul 5 2017

Cc: aga...@chromium.org

Comment 2 by logan@google.com, Jul 5 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration

Comment 3 by logan@google.com, Jul 5 2017

Project: chromium
Moved issue gerrit:6644 to now be  issue chromium:739415 .
Components:
Owner: shrike@chromium.org
Status: ExternalDependency (was: New)
Can you please link to such an example? I believe you are mistaken. For example, here is an update posted to a bug based on a commit made via gerrit: https://bugs.chromium.org/p/chromium/issues/detail?id=737779#c3


bugdroid only includes the links and author name when the commit is in an internal/private/locked-down repository, to avoid leaking commit messages and file names from internal code. This is true for both Rietveld and Gerrit, and I suspect that this is the behavior that you're seeing.
Status: WontFix (was: ExternalDependency)
I have seen a number of instances of this behavior across a number of bugs, the most recent being here:

https://bugs.chromium.org/p/chromium/issues/detail?id=737683#c6

but as you note this is WAI when working with internal repositories, which I believe is the case here. I will keep an eye out for more instances and see if there are any where the change is not from an internal/private/locked-down repository.

Sign in to add a comment