When using onscreen keyboard to enter query in search box, hitting “enter” doesn’t do anything |
||||||
Issue descriptionSteps to repro: Enter maximize mode, use the v keyboard to enter a query, use the v keyboard to hit enter. Start at search_box_view.cc
,
Jul 5 2017
Unable to Repro, holding until I can confirm this with sgabriel@
,
Jul 6 2017
I'm able to repro, the steps are: (1) Open full screen mode. (2) Use v keyboard to enter a query that matches an app (like Chromium) for the first result. (3) Hit enter, the app doesn't open. If the first result is not an app and is a search, it works normally.
,
Jul 6 2017
Happens with physical keyboard also.
,
Jul 6 2017
I think this is an issue with partial focus. It works as intended with the feature flag disabled.
,
Jul 7 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57d461f80f1d36ca3c85a1da43ad8538c5e992cf commit 57d461f80f1d36ca3c85a1da43ad8538c5e992cf Author: hejq <hejq@chromium.org> Date: Thu Jul 20 02:18:27 2017 Fix app list item indexing bug. When the Play Store app search feature is enabled, we have separators between items in the SearchResultTileItemListView. We have to skip those separators while indexing items. BUG= 739410 BUG=739841 Review-Url: https://codereview.chromium.org/2972243002 Cr-Commit-Position: refs/heads/master@{#488098} [modify] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/BUILD.gn [modify] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/app_list_features.cc [modify] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/app_list_features.h [modify] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/test/app_list_test_view_delegate.h [modify] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/views/search_result_answer_card_view_unittest.cc [modify] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/views/search_result_list_view_unittest.cc [modify] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/views/search_result_tile_item_list_view.cc [add] https://crrev.com/57d461f80f1d36ca3c85a1da43ad8538c5e992cf/ui/app_list/views/search_result_tile_item_list_view_unittest.cc
,
Jul 20 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by newcomer@chromium.org
, Jul 5 2017