New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739408 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Mouse/touchpad scroll event should transition from peeking to fullscreen.

Project Member Reported by newcomer@chromium.org, Jul 5 2017

Issue description

AppListView::OnMouseEvent, OnGestureEvent.
 
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8a3badb43f071f13b420aeacccf818cbf5e9bef

commit b8a3badb43f071f13b420aeacccf818cbf5e9bef
Author: newcomer <newcomer@chromium.org>
Date: Mon Jul 17 20:22:37 2017

New AppListView Scroll Behavior.

The old AppListView did not respond to scroll events from PEEKING mode.
Now the AppListView transitions from PEEKING to FULLSCREEN_ALL_APPS when
a scroll event (mousewheel or touchpad gesture) is received via
AppListView::HandleScroll.

I had to make a fix to ensure that events are properly propogating, and
I had to explicitly pass MouseWheel events from the SearchBoxView
widget.

New Tests:
MouseWheel Scroll events from the SearchBoxView from PEEKING.
MouseWheel scroll events from the AppListView shield from PEEKING.
Ditto, from other states.

BUG= 739408 

Review-Url: https://codereview.chromium.org/2982453002
Cr-Commit-Position: refs/heads/master@{#487222}

[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/pagination_controller.cc
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/views/app_list_page.cc
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/views/app_list_page.h
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/b8a3badb43f071f13b420aeacccf818cbf5e9bef/ui/views/controls/textfield/textfield_controller.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9807.0.0, 62.0.3176.0

Sign in to add a comment