rdar://33184203

In some cases load timeouts with this console message: "Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service"

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7c2ee628552ec6a9d624dcd1b78442991615715

commit a7c2ee628552ec6a9d624dcd1b78442991615715
Author: Eugene But <eugenebut@google.com>
Date: Thu Jul 13 19:51:05 2017

Always add WKWebView to the view hierarchy on iOS 11.

On iOS 11 WKWebView loads much slower if it is not a part of the view
hierarchy. This is more-likely a system issue, however it is important
to have a workaround until Apple fixes the bug.

BUG:  739390 ,  703222 , 734669
Change-Id: I09d5c3ffadee44d3a5a6d834d4b5f0839b20f50b
Reviewed-on: https://chromium-review.googlesource.com/566183
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486460}
[modify] https://crrev.com/a7c2ee628552ec6a9d624dcd1b78442991615715/ios/web/web_state/ui/crw_web_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8

commit 28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Thu Jul 20 12:46:32 2017

iOS 11 WKWebView load is broken

In iOS 11, WKWebView has issues (time outs) when loading request if the
view is not part of the hierarchy. The WKWebView is now added to the
hierarchy but off screen.

Bug:  738435 ,  739390 
Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
Reviewed-on: https://chromium-review.googlesource.com/577807
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488213}
[modify] https://crrev.com/28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8/components/signin/ios/browser/account_consistency_service.mm

I tested that on beta 4, it looks like it is fixed. Can somebody else can confirm before I remove those hack?

Yes this looks good on iOS11 beta#4. Tested on M60.0.3112.72 stable channel with iPhone7. Steps mentioned in the bug 734669 are no longer reproduced.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb05dc3f6ee2a4615eeb4b3708b32b2b537518c

commit ecb05dc3f6ee2a4615eeb4b3708b32b2b537518c
Author: Justin Cohen <justincohen@chromium.org>
Date: Wed Jul 26 18:25:21 2017

Revert "Always add WKWebView to the view hierarchy on iOS 11."

This reverts commit a7c2ee628552ec6a9d624dcd1b78442991615715.

Reason for revert: This appears fixed in Xcode 9 beta 4.

Original change's description:
> Always add WKWebView to the view hierarchy on iOS 11.
> 
> On iOS 11 WKWebView loads much slower if it is not a part of the view
> hierarchy. This is more-likely a system issue, however it is important
> to have a workaround until Apple fixes the bug.
> 
> BUG:  739390 ,  703222 , 734669
> Change-Id: I09d5c3ffadee44d3a5a6d834d4b5f0839b20f50b
> Reviewed-on: https://chromium-review.googlesource.com/566183
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486460}

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ifc1aa7a26ab6ea4a4347380e451bcf8da03dc1bb
Reviewed-on: https://chromium-review.googlesource.com/586727
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489702}
[modify] https://crrev.com/ecb05dc3f6ee2a4615eeb4b3708b32b2b537518c/ios/web/web_state/ui/crw_web_controller.mm

Lets merge this to 61 after a few days to bake.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

srikanthg@ any issues on canary after this revert?  If not I'll merge to M61 now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40de2a142623043bb744f808ca5652340b2c00b8

commit 40de2a142623043bb744f808ca5652340b2c00b8
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Mon Jul 31 11:27:05 2017

Revert "iOS 11 WKWebView load is broken"

This reverts commit 28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8.

Reason for revert: This appears fixed in Xcode 9 beta 4.

Original change's description:
> iOS 11 WKWebView load is broken
> 
> In iOS 11, WKWebView has issues (time outs) when loading request if the
> view is not part of the hierarchy. The WKWebView is now added to the
> hierarchy but off screen.
> 
> Bug:  738435 ,  739390 
> Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
> Reviewed-on: https://chromium-review.googlesource.com/577807
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488213}

TBR=rohitrao@chromium.org,msarda@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,jlebel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  738435 ,  739390 
Change-Id: Ic57820325fef5ac86b93b4f02f449b97f0b458e0
Reviewed-on: https://chromium-review.googlesource.com/591671
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490743}
[modify] https://crrev.com/40de2a142623043bb744f808ca5652340b2c00b8/components/signin/ios/browser/account_consistency_service.mm

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/540592130e1c03ce01b57f5a18d5de79c8bc7122

commit 540592130e1c03ce01b57f5a18d5de79c8bc7122
Author: Justin Cohen <justincohen@google.com>
Date: Mon Jul 31 20:24:04 2017

Revert "Always add WKWebView to the view hierarchy on iOS 11."

This reverts commit a7c2ee628552ec6a9d624dcd1b78442991615715.

Reason for revert: This appears fixed in Xcode 9 beta 4.

Original change's description:
> Always add WKWebView to the view hierarchy on iOS 11.
>
> On iOS 11 WKWebView loads much slower if it is not a part of the view
> hierarchy. This is more-likely a system issue, however it is important
> to have a workaround until Apple fixes the bug.
>
> BUG:  739390 ,  703222 , 734669
> Change-Id: I09d5c3ffadee44d3a5a6d834d4b5f0839b20f50b
> Reviewed-on: https://chromium-review.googlesource.com/566183
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486460}


TBR=justincohen@chromium.org

(cherry picked from commit ecb05dc3f6ee2a4615eeb4b3708b32b2b537518c)

Change-Id: Ifc1aa7a26ab6ea4a4347380e451bcf8da03dc1bb
Reviewed-on: https://chromium-review.googlesource.com/586727
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489702}
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/594948
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#176}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/540592130e1c03ce01b57f5a18d5de79c8bc7122/ios/web/web_state/ui/crw_web_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/731e8f89b4d1db6fecc2384c3825e95c4d8f206d

commit 731e8f89b4d1db6fecc2384c3825e95c4d8f206d
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Tue Aug 01 17:43:49 2017

Revert "iOS 11 WKWebView load is broken"

This reverts commit 28dfaa0da2e4ca268f6bbec2ede88c8a8c1933f8.

Reason for revert: This appears fixed in Xcode 9 beta 4.

Original change's description:
> iOS 11 WKWebView load is broken
>
> In iOS 11, WKWebView has issues (time outs) when loading request if the
> view is not part of the hierarchy. The WKWebView is now added to the
> hierarchy but off screen.
>
> Bug:  738435 ,  739390 
> Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
> Reviewed-on: https://chromium-review.googlesource.com/577807
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488213}

TBR=eugenebut@chromium.org, jlebel@chromium.org, justincohen@chromium.org, msarda@chromium.org, rohitrao@chromium.org


(cherry picked from commit 40de2a142623043bb744f808ca5652340b2c00b8)

Bug:  750739 ,  738435 ,  739390 
Change-Id: Ic57820325fef5ac86b93b4f02f449b97f0b458e0
Reviewed-on: https://chromium-review.googlesource.com/591671
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490743}
Reviewed-on: https://chromium-review.googlesource.com/596308
Cr-Commit-Position: refs/branch-heads/3163@{#211}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/731e8f89b4d1db6fecc2384c3825e95c4d8f206d/components/signin/ios/browser/account_consistency_service.mm

Regressed on iOS 11.3 Beta.

Issue 809074 has been merged into this issue.

What's the update on this blocker. M65 release is nearing

This is an iOS bug. We have a workaround, but it's not on trunk yet. Not sure if we can realistically ship this to M65.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7168d58bee6349e97eeb9dce83f610c9ce78b5

commit 9f7168d58bee6349e97eeb9dce83f610c9ce78b5
Author: Eugene But <eugenebut@chromium.org>
Date: Tue Feb 13 22:33:08 2018

Always add WKWebView to the view hierarchy on iOS 11.3.

On iOS 11.3 WKWebView loads much slower if it is not a part of the view
hierarchy. This is more-likely a system issue, however it is important
to have a workaround until Apple fixes the bug.

BUG= 739390 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8a066a97699a56980689b1d37dde560e69d91ff1
Reviewed-on: https://chromium-review.googlesource.com/910712
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536517}
[modify] https://crrev.com/9f7168d58bee6349e97eeb9dce83f610c9ce78b5/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/9f7168d58bee6349e97eeb9dce83f610c9ce78b5/ios/web/features.mm
[modify] https://crrev.com/9f7168d58bee6349e97eeb9dce83f610c9ce78b5/ios/web/public/features.h
[modify] https://crrev.com/9f7168d58bee6349e97eeb9dce83f610c9ce78b5/ios/web/web_state/ui/crw_web_controller.mm

srikanthg@, please verify. We should merge this to M65.

This bug requires manual review: Less than 15 days to go before AppStore submit on M65
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Fix Looks good.
Verified on M66.0.3348.0 canary
iOS: 11.3 beta#2, iPhoneX

srikanthg@ FYI, on the next beta we can test if core issue is fixed by disabling 'PreloadWebViewWhenNavigatingFromNativeContentOnIOS11_3'

 PreloadWebViewWhenNavigatingFromNativeContentOnIOS11_3 does not have a flag in chrome://flags, but we can test with M64.

Both the issues that are duped based on same root cause http://crbug/809074 and http://crbug/809149 are not present in M64. So I am not sure if testing on M64 is correct way. Anyways, I tested both of these issues on the same build numbers as I originally reported (M65,66) this time on iOS11.3 beta#3 and not able to reproduce anymore.

Do you know if you want to revert back the fix and test again?

eugenebut@ would passing --disable-features= PreloadWebViewWhenNavigatingFromNativeContentOnIOS11_3 or --enable-features=PreloadWebViewWhenNavigatingFromNativeContentOnIOS11_3 work?

Eric, do you know the answer to Comment #32? We have feature flags, which are not part of chrome://flags list and we want to test the app with PreloadWebViewWhenNavigatingFromNativeContentOnIOS11_3 enabled.

Srikanthg, I believe that M64 does not have the workaround and the bug should be reproducible with M64 on iOS 11.3 Beta 2.

Eugene, do you still want to merge #23 into M65?

Only if Beta 3 still have this bug. Srikanth, do you see this issue with M65 on iOS 11.3 Beta 3?

iOS11.3 beta#3 doesn't have this issue.

Thanks, then we should not merge this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b14d14b98e3ed271764fdc0cc4f9ba54cdaa7e93

commit b14d14b98e3ed271764fdc0cc4f9ba54cdaa7e93
Author: Eugene But <eugenebut@chromium.org>
Date: Fri Feb 23 20:06:47 2018

Revert "Always add WKWebView to the view hierarchy on iOS 11.3."

This reverts commit 9f7168d58bee6349e97eeb9dce83f610c9ce78b5.

Reason for revert: iOS 11.3 Beta 3 does not have this bug

Original change's description:
> Always add WKWebView to the view hierarchy on iOS 11.3.
> 
> On iOS 11.3 WKWebView loads much slower if it is not a part of the view
> hierarchy. This is more-likely a system issue, however it is important
> to have a workaround until Apple fixes the bug.
> 
> BUG= 739390 
> 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I8a066a97699a56980689b1d37dde560e69d91ff1
> Reviewed-on: https://chromium-review.googlesource.com/910712
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536517}

TBR=justincohen@chromium.org,eugenebut@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  739390 
Change-Id: I1d5332e35361e19020e34d4c12bbb2e87e8d036a
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/935222
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538873}
[modify] https://crrev.com/b14d14b98e3ed271764fdc0cc4f9ba54cdaa7e93/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b14d14b98e3ed271764fdc0cc4f9ba54cdaa7e93/ios/web/features.mm
[modify] https://crrev.com/b14d14b98e3ed271764fdc0cc4f9ba54cdaa7e93/ios/web/public/features.h
[modify] https://crrev.com/b14d14b98e3ed271764fdc0cc4f9ba54cdaa7e93/ios/web/web_state/ui/crw_web_controller.mm

Issue verified 
Version: Chrome Canary 66.0.3356.0
Device: iPhone 6, iPhone 8 
iOS: 11.3 beta#3, 11.2.6

Webpage loaded immediately. No time outs
https://drive.google.com/open?id=17Cl9JwcMXY_AKfHFAaHQ2Rjy2fe1Ponk