Remove Tryjob-Request label from ANGLE Gerrit/CQ |
|||||||
Issue descriptionI tried to make a CL to fix this myself but either ANGLE project owners don't have the permissions required to administer ANGLE, or I'm trying to upload my CL to the wrong branch. Andrii can you help with this? Also, can we get the ability to maintain this ourselves, or at least a pointer on how to do it properly if we can already?
,
Jul 5 2017
Angle is currently (effectively) configured to use the ChromeOS labels: CR+/-2, CQ+2, Verified+1, and Trybot-Ready+1. It's easy to remove the Trybot-Ready label, but it's important to note that you'll then have a wholly unique set of labels. Would Angle prefer to come into the Chromium fold and only use CR+/-1, and CQ+2 (i.e. no Verified, and no CR+/-2)? Current git admin: please work with Angle to help them standardize if they want to.
,
Jul 5 2017
,
Jul 6 2017
Current git admin: I think we'd like to have a unique set of labels, without the Tryjob-Request but with CR+2 and CQ+2.
,
Jul 6 2017
,
Jul 10 2017
Issue boomeranged...
,
Jul 10 2017
I'm not aware of a way to grant you edit permissions on your project without granting you edit permissions on all projects :( So, here is a CL to unify all angle config in just angle: https://chromium-review.googlesource.com/565719 once above land, we can delete all config in angle/angle repo and just let it inherit from parent repo.
,
Jul 10 2017
Above landed. Final CL: https://chromium-review.googlesource.com/c/565576/
,
Jul 10 2017
,
Jul 10 2017
Thanks Andrii!
,
Jul 13 2017
I think that since this change, Commit Bot is making a bunch of merge commits in our repo: https://chromium.googlesource.com/angle/angle.git/+log/ . Andrii, could you take a look?
,
Jul 13 2017
yeah, that was my bad, I forgot that submit strategies aren't inherited. Changed from merge to Rebase-Always.
,
Jul 13 2017
,
Jul 13 2017
Awesome, thanks for the quick fix! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tandrii@chromium.org
, Jul 5 2017Owner: ----
Status: Untriaged (was: Assigned)