New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739374 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Jul 2017
Cc:
█ petershih@chromium.org
█ yhong@chromium.org
█ pihsun@chromium.org
yllin@chromium.org
█ stimim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: test list clean up: remove factory_environment and engineering_mode from args

Project Member Reported by hungte@chromium.org, Jul 5 2017 
This is part of the process of simplifying test list.

Test list args used to have factory_environment and engineering_mode.
engineering_mode is usually decided by factory_environment.

These were introduced in the day that we think Google engineers will need to run same software in an environment without complete factory environment (for example, shopfloor).

However, looking at the test lists today:
 - almost all board overlays need factory_environment=True
 - when running tests locally, usually it's easier to setup a mock shopfloor,
   or always run selective tests in engineering mode, than turning off factory_environment.

I think there's no more reason to keep factory_environment. And we can always keep system in "non-engineering mode" unless people toggled that.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/73fde09f076b7bb1df9f891ae8be40f1d5c1b312

commit 73fde09f076b7bb1df9f891ae8be40f1d5c1b312
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Jul 10 18:22:35 2017

test_lists: Remove 'factory_environment' argument.

The 'factory_environment' was made to simplify testing, but is now
deprecated by the design of "engineering mode". We found that no one
sets factory_environment to False today, and is simply making test lists
unpredictable.

We should stop having factory_environment setting in test list
arguments. It should be something dynamic (like engineering mode)
or more specific setting (like enable_shopfloor).

BUG= chromium:739374 
TEST=make test

Change-Id: I4042983d4f82911b243fa944abbcea7fa745c1c9
Reviewed-on: https://chromium-review.googlesource.com/559609
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/goofy/goofy_remote.py
[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/test/test_lists/generic_smt.py
[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/test/test_lists/firmware_stress.py
[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/test/test_lists/generic_fatp.py
[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/test/test_lists/generic_run_in.py
[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/test/test_lists/generic.py
[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/test/test_lists/generic_rrt.py
[modify] https://crrev.com/73fde09f076b7bb1df9f891ae8be40f1d5c1b312/py/test/test_lists/generic_grt.py

Comment 2 by hungte@chromium.org, Jul 26 2017

Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment