New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739366 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
hobby only
Closed: Nov 19
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocking:
issue 621355



Sign in to add a comment

Split PasswordFormManager depending on usage

Project Member Reported by vabr@chromium.org, Jul 5 2017

Issue description

PasswordFormManager (PFM) is unfortunately a multi-purpose class. It should be separated by function.

In particular, to unblock  issue 725883 , PFM can now be cloned to repeatedly pass copies of a PFM instance held by PasswordManager to the UI code. Instead, the classes used by PasswordManager and the UI code should really be different, and should allow the appropriate translation from one into the other instead of cloning.

More info in the design doc https://docs.google.com/document/d/1ITlXh41T50NnMyAkKV1gVtTRD-TZ959rgeF6rMLK7pw/edit# (ask vabr@ for access if you need it).
 
Status: WontFix (was: Assigned)
This is unlikely to happen in this form any more.
dvadym@ had some ideas about separating the control over filling from the saving functions in the save password prompt and may arrive at implementing those at some point.

Sign in to add a comment