New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739356 link

Starred by 1 user
Status: Fixed
Owner:
█ yoshiki@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
tetsui@chromium.org
yhanada@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

message_center_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by glider@chromium.org, Jul 5 2017 
message_center_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

=================================================================
==21433==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 888 byte(s) in 1 object(s) allocated from:
    #0 0x518512 in operator new(unsigned long) (/b/s/w/ir/out/Release/message_center_unittests+0x518512)
    #1 0xea2300 in message_center::NotificationControlButtonsView::ShowCloseButton(bool) ui/message_center/views/notification_control_buttons_view.cc:49:21
    #2 0xe78330 in UpdateControlButtonsVisibilityWithNotification ui/message_center/views/notification_view.cc:630:26
    #3 0xe78330 in message_center::NotificationView::NotificationView(message_center::MessageCenterController*, message_center::Notification const&) ui/message_center/views/notification_view.cc:191
    #4 0xe72e8a in message_center::MessageViewFactory::Create(message_center::MessageCenterController*, message_center::Notification const&, bool) ui/message_center/views/message_view_factory.cc
    #5 0xe55aeb in AddNotificationAt ui/message_center/views/message_center_view.cc:513:7
    #6 0xe55aeb in message_center::MessageCenterView::OnNotificationAdded(std::string const&) ui/message_center/views/message_center_view.cc:340
    #7 0x615a1c in message_center::MessageCenterViewTest::AddNotification(std::unique_ptr<message_center::Notification, std::default_delete<message_center::Notification> >) ui/message_center/views/message_center_view_unittest.cc:346:25
    #8 0x62bc14 in message_center::MessageCenterViewTest_CloseButtonEnablity_Test::TestBody() ui/message_center/views/message_center_view_unittest.cc:717:3
    #9 0xd6b6fc in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #10 0xd6b6fc in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2471
    #11 0xd6cee4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2653:11
    #12 0xd6e046 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2771:28
    #13 0xd82136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4648:43
    #14 0xd816a9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #15 0xd816a9 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4256
    #16 0x109cfa9 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46
    #17 0x109cfa9 in base::TestSuite::Run() base/test/test_suite.cc:271
    #18 0x10a11c6 in Run base/callback.h:80:12
    #19 0x10a11c6 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned long, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:216
    #20 0x10a0cbf in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:462:10
    #21 0x51b4c9 in main ui/message_center/test/run_all_unittests.cc:71:10
    #22 0x7fcbffbdff44 in __libc_start_main /build/eglibc-MjiXCM/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 512 byte(s) in 1 object(s) allocated from:
    #0 0x518512 in operator new(unsigned long) (/b/s/w/ir/out/Release/message_center_unittests+0x518512)
    #1 0x1d776fc in allocate build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/ext/new_allocator.h:104:27
    #2 0x1d776fc in _M_allocate_node build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:533
    #3 0x1d776fc in _M_create_nodes build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:627
    #4 0x1d776fc in _M_initialize_map build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:601
    #5 0x1d776fc in _Deque_base build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:453
    #6 0x1d776fc in deque build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:783
    #7 0x1d776fc in ui::EventHandler::EventHandler() ui/events/event_handler.cc:12
    #8 0x1fbc773 in InkDropGestureHandler ui/views/animation/ink_drop_host_view.cc:44:12
    #9 0x1fbc773 in MakeUnique<views::InkDropHostView::InkDropGestureHandler, views::InkDropHostView *> base/memory/ptr_util.h:56
    #10 0x1fbc773 in views::InkDropHostView::SetInkDropMode(views::InkDropHostView::InkDropMode) ui/views/animation/ink_drop_host_view.cc:196
    #11 0xeaa8d6 in message_center::PaddedButton::PaddedButton(views::ButtonListener*) ui/message_center/views/padded_button.cc:29:3
    #12 0xea2316 in message_center::NotificationControlButtonsView::ShowCloseButton(bool) ui/message_center/views/notification_control_buttons_view.cc:49:25
    #13 0xe78330 in UpdateControlButtonsVisibilityWithNotification ui/message_center/views/notification_view.cc:630:26
    #14 0xe78330 in message_center::NotificationView::NotificationView(message_center::MessageCenterController*, message_center::Notification const&) ui/message_center/views/notification_view.cc:191
    #15 0xe72e8a in message_center::MessageViewFactory::Create(message_center::MessageCenterController*, message_center::Notification const&, bool) ui/message_center/views/message_view_factory.cc
    #16 0xe55aeb in AddNotificationAt ui/message_center/views/message_center_view.cc:513:7
    #17 0xe55aeb in message_center::MessageCenterView::OnNotificationAdded(std::string const&) ui/message_center/views/message_center_view.cc:340
    #18 0x615a1c in message_center::MessageCenterViewTest::AddNotification(std::unique_ptr<message_center::Notification, std::default_delete<message_center::Notification> >) ui/message_center/views/message_center_view_unittest.cc:346:25
    #19 0x62bc14 in message_center::MessageCenterViewTest_CloseButtonEnablity_Test::TestBody() ui/message_center/views/message_center_view_unittest.cc:717:3
    #20 0xd6b6fc in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #21 0xd6b6fc in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2471
    #22 0xd6cee4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2653:11
    #23 0xd6e046 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2771:28
    #24 0xd82136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4648:43
    #25 0xd816a9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #26 0xd816a9 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4256
    #27 0x109cfa9 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46
    #28 0x109cfa9 in base::TestSuite::Run() base/test/test_suite.cc:271
    #29 0x10a11c6 in Run base/callback.h:80:12
    #30 0x10a11c6 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned long, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:216
    #31 0x10a0cbf in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:462:10
    #32 0x51b4c9 in main ui/message_center/test/run_all_unittests.cc:71:10
    #33 0x7fcbffbdff44 in __libc_start_main /build/eglibc-MjiXCM/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 512 byte(s) in 1 object(s) allocated from:
    #0 0x518512 in operator new(unsigned long) (/b/s/w/ir/out/Release/message_center_unittests+0x518512)
    #1 0x1d776fc in allocate build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/ext/new_allocator.h:104:27
    #2 0x1d776fc in _M_allocate_node build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:533
    #3 0x1d776fc in _M_create_nodes build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:627
    #4 0x1d776fc in _M_initialize_map build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:601
    #5 0x1d776fc in _Deque_base build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:453
    #6 0x1d776fc in deque build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:783
    #7 0x1d776fc in ui::EventHandler::EventHandler() ui/events/event_handler.cc:12
    #8 0x1d78957 in ui::ScopedTargetHandler::ScopedTargetHandler(ui::EventTarget*, ui::EventHandler*) ui/events/scoped_target_handler.cc:13:22
    #9 0x1fbc7b5 in InkDropGestureHandler ui/views/animation/ink_drop_host_view.cc:45:29
    #10 0x1fbc7b5 in MakeUnique<views::InkDropHostView::InkDropGestureHandler, views::InkDropHostView *> base/memory/ptr_util.h:56
    #11 0x1fbc7b5 in views::InkDropHostView::SetInkDropMode(views::InkDropHostView::InkDropMode) ui/views/animation/ink_drop_host_view.cc:196
    #12 0xeaa8d6 in message_center::PaddedButton::PaddedButton(views::ButtonListener*) ui/message_center/views/padded_button.cc:29:3
    #13 0xea2316 in message_center::NotificationControlButtonsView::ShowCloseButton(bool) ui/message_center/views/notification_control_buttons_view.cc:49:25
    #14 0xe78330 in UpdateControlButtonsVisibilityWithNotification ui/message_center/views/notification_view.cc:630:26
    #15 0xe78330 in message_center::NotificationView::NotificationView(message_center::MessageCenterController*, message_center::Notification const&) ui/message_center/views/notification_view.cc:191
    #16 0xe72e8a in message_center::MessageViewFactory::Create(message_center::MessageCenterController*, message_center::Notification const&, bool) ui/message_center/views/message_view_factory.cc
    #17 0xe55aeb in AddNotificationAt ui/message_center/views/message_center_view.cc:513:7
    #18 0xe55aeb in message_center::MessageCenterView::OnNotificationAdded(std::string const&) ui/message_center/views/message_center_view.cc:340
    #19 0x615a1c in message_center::MessageCenterViewTest::AddNotification(std::unique_ptr<message_center::Notification, std::default_delete<message_center::Notification> >) ui/message_center/views/message_center_view_unittest.cc:346:25
    #20 0x62bc14 in message_center::MessageCenterViewTest_CloseButtonEnablity_Test::TestBody() ui/message_center/views/message_center_view_unittest.cc:717:3
    #21 0xd6b6fc in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #22 0xd6b6fc in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2471
    #23 0xd6cee4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2653:11
    #24 0xd6e046 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2771:28
    #25 0xd82136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4648:43
    #26 0xd816a9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #27 0xd816a9 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4256
    #28 0x109cfa9 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46
    #29 0x109cfa9 in base::TestSuite::Run() base/test/test_suite.cc:271
    #30 0x10a11c6 in Run base/callback.h:80:12
    #31 0x10a11c6 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned long, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:216
    #32 0x10a0cbf in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:462:10
    #33 0x51b4c9 in main ui/message_center/test/run_all_unittests.cc:71:10
    #34 0x7fcbffbdff44 in __libc_start_main /build/eglibc-MjiXCM/eglibc-2.19/csu/libc-start.c:287
Indirect leak of 512 byte(s) in 1 object(s) allocated from:
    #0 0x518512 in operator new(unsigned long) (/b/s/w/ir/out/Release/message_center_unittests+0x518512)
    #1 0x1d776fc in allocate build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/ext/new_allocator.h:104:27
    #2 0x1d776fc in _M_allocate_node build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:533
    #3 0x1d776fc in _M_create_nodes build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:627
    #4 0x1d776fc in _M_initialize_map build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:601
    #5 0x1d776fc in _Deque_base build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:453
    #6 0x1d776fc in deque build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_deque.h:783
    #7 0x1d776fc in ui::EventHandler::EventHandler() ui/events/event_handler.cc:12
    #8 0x207a8ce in views::View::View() ui/views/view.cc:128:7
    #9 0x1fb925e in views::InkDropHostView::InkDropHostView() ui/views/animation/ink_drop_host_view.cc:118:18
    #10 0x1fd5361 in views::Button::Button(views::ButtonListener*) ui/views/controls/button/button.cc:75:9
    #11 0x1fdd4ee in views::CustomButton::CustomButton(views::ButtonListener*) ui/views/controls/button/custom_button.cc:448:7
    #12 0x1fdde96 in views::ImageButton::ImageButton(views::ButtonListener*) ui/views/controls/button/image_button.cc:32:7
    #13 0xeaa54f in message_center::PaddedButton::PaddedButton(views::ButtonListener*) ui/message_center/views/padded_button.cc:20:7
    #14 0xea2316 in message_center::NotificationControlButtonsView::ShowCloseButton(bool) ui/message_center/views/notification_control_buttons_view.cc:49:25
    #15 0xe78330 in UpdateControlButtonsVisibilityWithNotification ui/message_center/views/notification_view.cc:630:26
    #16 0xe78330 in message_center::NotificationView::NotificationView(message_center::MessageCenterController*, message_center::Notification const&) ui/message_center/views/notification_view.cc:191
    #17 0xe72e8a in message_center::MessageViewFactory::Create(message_center::MessageCenterController*, message_center::Notification const&, bool) ui/message_center/views/message_view_factory.cc
    #18 0xe55aeb in AddNotificationAt ui/message_center/views/message_center_view.cc:513:7
    #19 0xe55aeb in message_center::MessageCenterView::OnNotificationAdded(std::string const&) ui/message_center/views/message_center_view.cc:340
    #20 0x615a1c in message_center::MessageCenterViewTest::AddNotification(std::unique_ptr<message_center::Notification, std::default_delete<message_center::Notification> >) ui/message_center/views/message_center_view_unittest.cc:346:25
    #21 0x62bc14 in message_center::MessageCenterViewTest_CloseButtonEnablity_Test::TestBody() ui/message_center/views/message_center_view_unittest.cc:717:3
    #22 0xd6b6fc in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #23 0xd6b6fc in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2471
    #24 0xd6cee4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2653:11
    #25 0xd6e046 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2771:28
    #26 0xd82136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4648:43
    #27 0xd816a9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #28 0xd816a9 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4256
    #29 0x109cfa9 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46
    #30 0x109cfa9 in base::TestSuite::Run() base/test/test_suite.cc:271
    #31 0x10a11c6 in Run base/callback.h:80:12
    #32 0x10a11c6 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned long, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:216
    #33 0x10a0cbf in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:462:10
    #34 0x51b4c9 in main ui/message_center/test/run_all_unittests.cc:71:10
    #35 0x7fcbffbdff44 in __libc_start_main /build/eglibc-MjiXCM/eglibc-2.19/csu/libc-start.c:287

(and more)

I'm suspecting https://chromium.googlesource.com/chromium/src/+/12cad72cd90108551c79ebde78ed564832478707, will revert

Comment 1 by yoshiki@chromium.org, Jul 5 2017 

Thank you for reporting.

The fix will be in soon: https://codereview.chromium.org/2967133002/

Comment 2 by glider@chromium.org, Jul 5 2017

Labels: -Sheriff-Chromium

Comment 4 by yoshiki@chromium.org, Jul 5 2017

Status: Fixed (was: Assigned)

Comment 5 by mastiz@chromium.org, Jul 7 2017 

Similar errors are back, surfaced by https://codereview.chromium.org/2966343002

The actual culprit seems different, but I think I'll just revert the patch to make the builder green.

Comment 6 by mastiz@chromium.org, Jul 7 2017 

I see the tests using set_owned_by_client() which likely has a reason but also -and presumably- introduces leaks. So it does seem an issue with the patch linked above, reverting just in case. Apologies for the inconvenience.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0e04c835cae01af85b8532022cec6ee5346f69f

commit a0e04c835cae01af85b8532022cec6ee5346f69f
Author: mastiz <mastiz@chromium.org>
Date: Fri Jul 07 12:45:44 2017

Revert of Port NotificationViewMD unit tests from NotificationViewTest. (patchset #5 id:80001 of https://codereview.chromium.org/2966343002/ )

Reason for revert:
message_center_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

BUG= 739356 

Original issue's description:
> Port NotificationViewMD unit tests from NotificationViewTest.
>
> Ported unit tests from NotificationViewTest and created
> NotificationViewMDTest. Also fixed bugs and check failures found during
> porting the tests.
> * Fix RemoveChildView null checking. (CHECK fails on debug builds.)
> * Fix action button hover state inheritance.
>
> Following tests are not ported from NotificationViewTest, mostly
> because the feature is unimplemented or the test is not applicable.
> * CreateOrUpdateTestSettingsButton
> * TestLineLimits
> * TestImageSizing
> * SettingsButtonTest
> * ViewOrderingTest
> * FormatContextMessageTest
>
> BUG= 733948 
> TEST=out/Debug/message_center_unittests
>
> Review-Url: https://codereview.chromium.org/2966343002
> Cr-Commit-Position: refs/heads/master@{#484851}
> Committed: https://chromium.googlesource.com/chromium/src/+/9a4a1121fae26a1727728888a41975bc15e3e62f

TBR=fukino@chromium.org,yoshiki@chromium.org,tetsui@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 733948 

Review-Url: https://codereview.chromium.org/2965353002
Cr-Commit-Position: refs/heads/master@{#484899}

[modify] https://crrev.com/a0e04c835cae01af85b8532022cec6ee5346f69f/ui/message_center/BUILD.gn
[modify] https://crrev.com/a0e04c835cae01af85b8532022cec6ee5346f69f/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/a0e04c835cae01af85b8532022cec6ee5346f69f/ui/message_center/views/notification_view_md.h
[delete] https://crrev.com/dbb008f0e650d625766f8d29776a52aadbad9ce1/ui/message_center/views/notification_view_md_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67cb979431064350778e059b4204e7241cad00b7

commit 67cb979431064350778e059b4204e7241cad00b7
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue Jul 11 11:46:47 2017

Fix NotificationViewMD leak and restore unit tests.

NotificationViewMDTest were reverted due to LSan failure in
NotificationViewMD.
This CL fixes the leak and restores NotificationViewMDTest.
The leak was caused because we assumed a->RemoveChildView(b)
would delete the b object, but it was not true.
We should use DCHECK(a->Contains(b)); delete b; instead.

Original CL: https://codereview.chromium.org/2966343002/

BUG= 733948 , 739356 
TEST=
gn gen out/asan --args='is_asan=true is_lsan=true enable_nacl=false
is_debug=false' &&
ASAN_OPTIONS="detect_leaks=1 symbolize=1
external_symbolizer_path=`pwd`/third_party/llvm-build/
Release+Asserts/bin/llvm-symbolizer" out/asan/message_center_unittests

Change-Id: I81f1aefdab6fafa35fd00e69875b1aa426822c9e
Reviewed-on: https://chromium-review.googlesource.com/564859
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485591}
[modify] https://crrev.com/67cb979431064350778e059b4204e7241cad00b7/ui/message_center/BUILD.gn
[modify] https://crrev.com/67cb979431064350778e059b4204e7241cad00b7/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/67cb979431064350778e059b4204e7241cad00b7/ui/message_center/views/notification_view_md.h
[add] https://crrev.com/67cb979431064350778e059b4204e7241cad00b7/ui/message_center/views/notification_view_md_unittest.cc
►

Sign in to add a comment