SadTab page text is not translated in other languages |
||||||||
Issue descriptionApp Version: 61.0.3148.0 Canary iOS Version: 11.0.0, 10.3.2, 9.3.5 Device: iPhone and iPad URL: chrome://crash Pre-condition: Set the device language to any language other than English Steps to reproduce: 1. Launch chrome and navigate to chrome://crash in normal tab 2. Tap on Reload button Or Repeat step 1 & 2 in incognito tab Observed results: The text of the repeated crash page is not displayed in device language Expected results: The SadTab text should be displayed in device language Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Yes (whole text is displayed only in english) Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No (Repeated crash page is not available in stable) Bug reproducible on the current beta channel build (App Version, iOS Version): yes on M60 Link to video/image: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8QjJQdFpZT0QwOTQ/view?usp=sharing
,
Jul 13 2017
Just tested with 61.0.3156.0 canary using French UI. chrome://crash page shows "Aie aie aie" (i.e. translated). Tap on "Actualiser" (reload) and you get "Impossible d'ouvrir cette page". The first bullet shows "Open page in a new incognito tab" (still in English). => cmasso@ for status of translated strings.
,
Jul 13 2017
,
Jul 13 2017
Please what is the string ID?
,
Jul 13 2017
IDS_SAD_TAB_RELOAD_INCOGNITO The English value is "Open page in a new Incognito tab" and is bracketed by <if expr="is_android or is_ios">
,
Jul 13 2017
This to be expected in 61. Strings were updated for 61 as per crbug.com/736122 and would not yet be localized. Please check this again in a 60 build. This should not be a release blocker for 60 as the strings in 60 were localized a while ago.
,
Jul 14 2017
Verified on 60.0.3112.68 beta on iPhone 6 plus (iOS 11), iPhone 7(iOS 10) and iPad pro (iOS 9.3.5). The strings are localized as per the selected language. As mentioned in comment#2, the issue persists in M61.
,
Jul 25 2017
Please verify this now on M61. We have branched last week and translations ran yesterday.
,
Jul 25 2017
,
Jul 26 2017
Verified on latest Beta build M61.0.3163.11 on iPhone 6s plus(iOS 10), iPhone 6 plus(iOS 11) and iPad Air(iOS 10.3.3) The strings are localized as per the selected language. Screenshot: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8alVsZkFURVN1M00/view?usp=sharing
,
Jul 26 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 26 2017
,
Jul 26 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by justincohen@chromium.org
, Jul 5 2017Status: Assigned (was: Untriaged)