Implementation Exploration: https://docs.google.com/document/d/1ehDiymXXbsSInSIwfX-WQZPw0GUmvlqe_FYQdkwsoSo/edit?pli=1# Flows slide deck: https://docs.google.com/presentation/d/10za0hvOXmZNjjTcViMFjMJIoOU8LJKJlaE6iQ2LtTgY/edit#slide=id.g22b8009b27_0_110
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04fc429cf5d4c16316402d43c5435c36d09c480f commit 04fc429cf5d4c16316402d43c5435c36d09c480f Author: melandory <melandory@chromium.org> Date: Fri Jul 28 11:51:32 2017 Skeleton for showing "Show all saved passwords row" Shows "Show all saved passwords row" for the case when the password was autofilled and user clicks on the password field for Linux/CrOs/Windows platforms. The appearance of the row is guarded only buy flag. No metrics are added in this CL. TBR=mahmadi@chromium.org BUG= 739343 Review-Url: https://codereview.chromium.org/2971783002 Cr-Commit-Position: refs/heads/master@{#490365} [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/android_webview/browser/aw_autofill_client.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/android_webview/browser/aw_autofill_client.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/app/vector_icons/open_in_new.icon [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/browser/ui/autofill/autofill_popup_layout_model.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/browser/ui/autofill/autofill_popup_layout_model_unittest.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/browser/ui/autofill/chrome_autofill_client.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill/core/browser/autofill_client.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill/core/browser/autofill_external_delegate.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill/core/browser/autofill_external_delegate_unittest.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill/core/browser/autofill_metrics_unittest.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill/core/browser/popup_item_ids.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill/core/browser/test_autofill_client.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill/core/browser/test_autofill_client.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/autofill_strings.grdp [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/password_manager/core/common/password_manager_features.cc [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/components/password_manager/core/common/password_manager_features.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/ios/chrome/browser/ui/autofill/autofill_client_ios.h [modify] https://crrev.com/04fc429cf5d4c16316402d43c5435c36d09c480f/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afb4045bbe3537e3b8bac8e8a14cf9be4a6eb33b commit afb4045bbe3537e3b8bac8e8a14cf9be4a6eb33b Author: Tatiana Gornak <melandory@chromium.org> Date: Mon Jul 31 13:50:04 2017 Add switch to chrome://flags for enabling manual fallbacks for filling. BUG= 739343 Save skeletoon Change-Id: I5aac58e8e4675c3a12044130b5b9329a743f1361 Reviewed-on: https://chromium-review.googlesource.com/586604 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#490757} [modify] https://crrev.com/afb4045bbe3537e3b8bac8e8a14cf9be4a6eb33b/chrome/browser/about_flags.cc [modify] https://crrev.com/afb4045bbe3537e3b8bac8e8a14cf9be4a6eb33b/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/afb4045bbe3537e3b8bac8e8a14cf9be4a6eb33b/chrome/browser/flag_descriptions.h [modify] https://crrev.com/afb4045bbe3537e3b8bac8e8a14cf9be4a6eb33b/tools/metrics/histograms/enums.xml
generate password fallback
To #7: Looks cool! :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6255523eef3825880434d33085a4764e52f8859f commit 6255523eef3825880434d33085a4764e52f8859f Author: Tatiana Gornak <melandory@chromium.org> Date: Mon Aug 07 11:35:19 2017 Show filling manual fallback when no saved credentials are available. This CL implements standalone showing for the "Show all saved passwords" fallback for the case when the password filed was not autofilled. No metrics are added in this CL. BUG= 739343 Change-Id: Ie73ade898efd71c7f3abc5066df10e5072e77268 Reviewed-on: https://chromium-review.googlesource.com/595587 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#492300} [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/chrome/renderer/autofill/fake_content_password_manager_driver.cc [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/chrome/renderer/autofill/fake_content_password_manager_driver.h [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/autofill/content/common/autofill_driver.mojom [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/autofill/content/renderer/BUILD.gn [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/autofill/content/renderer/DEPS [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/password_manager/content/browser/content_password_manager_driver.cc [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/password_manager/content/browser/content_password_manager_driver.h [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/password_manager/core/browser/password_autofill_manager.h [modify] https://crrev.com/6255523eef3825880434d33085a4764e52f8859f/components/password_manager/core/browser/password_autofill_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86fa3c4a571c5d9c3172dedfd3f76ac062e32637 commit 86fa3c4a571c5d9c3172dedfd3f76ac062e32637 Author: Tatiana Gornak <melandory@chromium.org> Date: Tue Aug 08 14:53:29 2017 "Show all saved passwords" fallback for Android. This Cl implements missing pieces for the "Show all saved passwords" fallback for Android in the case when the password field was autofilled. Screenshots are attached to the bug. This CL doesn't include separate treatment for the case of keyboard accessory. BUG= 739343 Change-Id: I71fe2f5980090ab360aeec1c233b02034597a2d9 Reviewed-on: https://chromium-review.googlesource.com/598231 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#492621} [modify] https://crrev.com/86fa3c4a571c5d9c3172dedfd3f76ac062e32637/chrome/browser/about_flags.cc [modify] https://crrev.com/86fa3c4a571c5d9c3172dedfd3f76ac062e32637/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/86fa3c4a571c5d9c3172dedfd3f76ac062e32637/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/86fa3c4a571c5d9c3172dedfd3f76ac062e32637/components/password_manager/core/browser/password_autofill_manager_unittest.cc
Desktop UI without icon
Screenshots for "Show all saved passwords" on Android. Both popup and keyboard accessory.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/360acb6a5c29a5f90bc916c40fc716ad0c91d22a commit 360acb6a5c29a5f90bc916c40fc716ad0c91d22a Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Aug 09 10:35:40 2017 Change how "Show all saved passwords" fallback is displayed. This CL removed the icon from the "Show all saved passwords" manual fallback. BUG= 739343 Change-Id: Ic258721a106afe041a27119b335fc5c71bc8ec62 Reviewed-on: https://chromium-review.googlesource.com/605187 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#492936} [modify] https://crrev.com/360acb6a5c29a5f90bc916c40fc716ad0c91d22a/chrome/app/vector_icons/BUILD.gn [delete] https://crrev.com/622eab38a8f9300203cb505ad9adc7f027ca588e/chrome/app/vector_icons/open_in_new.icon [modify] https://crrev.com/360acb6a5c29a5f90bc916c40fc716ad0c91d22a/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/360acb6a5c29a5f90bc916c40fc716ad0c91d22a/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc [modify] https://crrev.com/360acb6a5c29a5f90bc916c40fc716ad0c91d22a/components/autofill_strings.grdp [modify] https://crrev.com/360acb6a5c29a5f90bc916c40fc716ad0c91d22a/components/password_manager/core/browser/password_autofill_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/161200ebca98c1ba716ff9d015d21aadb1ee1daf commit 161200ebca98c1ba716ff9d015d21aadb1ee1daf Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Aug 10 11:55:02 2017 Implement "Show all saved passwords" drop-down item on Mac. Enable the feature by default. With this CL the feature is implemented on desktop. TBR=groby@chromium.org Bug: 739343 Change-Id: I7f3dfdc61a676c08e6999cafee94704e14d533a6 Reviewed-on: https://chromium-review.googlesource.com/600548 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#493359} [modify] https://crrev.com/161200ebca98c1ba716ff9d015d21aadb1ee1daf/chrome/browser/autofill/autofill_interactive_uitest.cc [modify] https://crrev.com/161200ebca98c1ba716ff9d015d21aadb1ee1daf/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm [modify] https://crrev.com/161200ebca98c1ba716ff9d015d21aadb1ee1daf/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/161200ebca98c1ba716ff9d015d21aadb1ee1daf/components/password_manager/core/common/password_manager_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce9412c7f3092fad31ac060a00e52656c2cf66d6 commit ce9412c7f3092fad31ac060a00e52656c2cf66d6 Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Aug 16 12:54:55 2017 Enable Autofill manual fallbacks for all platforms except CrOs. BUG= 754326 , 739343 Change-Id: Idd7239e4c6b22e4cde958911c1e9b16d3d4f6cb2 Reviewed-on: https://chromium-review.googlesource.com/616760 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#494754} [modify] https://crrev.com/ce9412c7f3092fad31ac060a00e52656c2cf66d6/components/password_manager/core/common/password_manager_features.cc
We should probably disable the menu item if no passwords are saved which would also cover guest mode on non CrOS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e9f39bf1866840726bc16045427fdcb5964a1dc commit 4e9f39bf1866840726bc16045427fdcb5964a1dc Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Aug 17 16:20:43 2017 Reenable "Show all passwords" on CrOS. The CL fixes the crash caused by NULL pointer dereferencing. Bug: 754326 , 739343 Change-Id: Ib448b501f00fe1f6b060f5e51ef77e99d7b9e3f0 Reviewed-on: https://chromium-review.googlesource.com/618327 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#495187} [modify] https://crrev.com/4e9f39bf1866840726bc16045427fdcb5964a1dc/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/4e9f39bf1866840726bc16045427fdcb5964a1dc/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/4e9f39bf1866840726bc16045427fdcb5964a1dc/components/password_manager/core/common/password_manager_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15129ee4d7fc6670e9be038faef846e0668b2255 commit 15129ee4d7fc6670e9be038faef846e0668b2255 Author: Tatiana Gornak <melandory@chromium.org> Date: Fri Aug 18 16:27:02 2017 Change appearance behaviour for the "Show all saved passwords" This CL changes the behaviour for "Show all saved passwords" fallback. In case when no credentials were autofilled fallback appears, but once user starts typing in a password field, the fallback disappears. BUG= 739343 Change-Id: Ic2b4d17be9516638f353782e36338bc6571cb7cd Reviewed-on: https://chromium-review.googlesource.com/620658 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#495569} [modify] https://crrev.com/15129ee4d7fc6670e9be038faef846e0668b2255/chrome/renderer/autofill/fake_content_password_manager_driver.h [modify] https://crrev.com/15129ee4d7fc6670e9be038faef846e0668b2255/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/15129ee4d7fc6670e9be038faef846e0668b2255/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/15129ee4d7fc6670e9be038faef846e0668b2255/components/autofill/content/renderer/password_autofill_agent.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2 commit 68ea9eefe1fa576c2076eff3417cbb75c87b3ff2 Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Aug 23 16:04:43 2017 Log Show All Saved Passwords Fallback This CL adds metrics to track when and how often the "Show all saved passwords" fallback was shown and accepted. Bug: 739343 Change-Id: I40188d8bab169faba80a39101b981751410b9646 Reviewed-on: https://chromium-review.googlesource.com/623228 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#496696} [modify] https://crrev.com/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2/components/password_manager/core/browser/password_autofill_manager.h [modify] https://crrev.com/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2/components/password_manager/core/browser/password_manager_metrics_util.cc [modify] https://crrev.com/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2/tools/metrics/histograms/enums.xml [modify] https://crrev.com/68ea9eefe1fa576c2076eff3417cbb75c87b3ff2/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44122988fd076af7d55f243e2ef21cdc921a4f99 commit 44122988fd076af7d55f243e2ef21cdc921a4f99 Author: Tatiana Gornak <melandory@chromium.org> Date: Fri Aug 25 13:38:43 2017 Don't show "Show all saved passwords" fallback when generation poupup is showing. BUG= 739343 Change-Id: I9057c6c4a0c39f67554e1353ae3f6482d2a4e559 Reviewed-on: https://chromium-review.googlesource.com/635523 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#497393} [modify] https://crrev.com/44122988fd076af7d55f243e2ef21cdc921a4f99/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/44122988fd076af7d55f243e2ef21cdc921a4f99/components/autofill/content/renderer/password_autofill_agent.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82f46e17b92968105af01619285dd33e1b447c89 commit 82f46e17b92968105af01619285dd33e1b447c89 Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Aug 30 09:10:30 2017 Don't show "Show all saved passwords" fallback for pre-lolipop devices. Once CL https://chromium-review.googlesource.com/c/chromium/src/+/628497 lands this condition can be soften, since we can show fallback for Sync users. BUG= 739343 Change-Id: Ia8fb9c58176402a861b61559146a4c68c2218bb7 Reviewed-on: https://chromium-review.googlesource.com/635383 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#498407} [modify] https://crrev.com/82f46e17b92968105af01619285dd33e1b447c89/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/82f46e17b92968105af01619285dd33e1b447c89/components/password_manager/core/browser/password_autofill_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7e84fa480be67a1fae168d7a9be8fd3c4896614 commit f7e84fa480be67a1fae168d7a9be8fd3c4896614 Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Aug 30 15:55:23 2017 Enable "Show all saved passwords" fallback for pre-Lolipop sync users. BUG= 739343 Change-Id: Ie1a172576606e7ae88fd489b952e649dec25f6dc Reviewed-on: https://chromium-review.googlesource.com/643293 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#498477} [modify] https://crrev.com/f7e84fa480be67a1fae168d7a9be8fd3c4896614/components/password_manager/core/browser/password_autofill_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43837c04cf7f9d6b3c17a067b824b289edba4866 commit 43837c04cf7f9d6b3c17a067b824b289edba4866 Author: Tatiana Gornak <melandory@chromium.org> Date: Thu Aug 31 14:43:38 2017 Prevent "Show all saved passwords" fallback appear if site have blacklisted form. This CL implements the logic, which suppresses "Show all saved passwords" fallback for the cases when the user has blacklisted credentials for this origin, BUG= 739343 Change-Id: I46a8336ea7d964ac32c47c8582a053ccf9b961db Reviewed-on: https://chromium-review.googlesource.com/632578 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#498864} [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/autofill/content/common/autofill_agent.mojom [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/content/browser/content_password_manager_driver.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/content/browser/content_password_manager_driver.h [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/content/browser/content_password_manager_driver_unittest.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/core/browser/password_form_manager.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/core/browser/password_form_manager.h [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/core/browser/password_generation_manager_unittest.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/core/browser/password_manager_driver.h [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/core/browser/stub_password_manager_driver.cc [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/components/password_manager/core/browser/stub_password_manager_driver.h [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h [modify] https://crrev.com/43837c04cf7f9d6b3c17a067b824b289edba4866/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7770b8ed7da9f4db81695d22789d092414367e6 commit f7770b8ed7da9f4db81695d22789d092414367e6 Author: Tatiana Gornak <melandory@chromium.org> Date: Fri Sep 01 15:58:53 2017 Fork standalone popup as separate feature. This patch guards standalone "Show all saved passwords" popup with separate feature. BUG= 739343 Change-Id: Ie9064c9a6a5943f187ea1f63b1ddf42eb1546b00 Reviewed-on: https://chromium-review.googlesource.com/645975 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#499204} [modify] https://crrev.com/f7770b8ed7da9f4db81695d22789d092414367e6/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/f7770b8ed7da9f4db81695d22789d092414367e6/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/f7770b8ed7da9f4db81695d22789d092414367e6/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/f7770b8ed7da9f4db81695d22789d092414367e6/components/password_manager/core/common/password_manager_features.cc [modify] https://crrev.com/f7770b8ed7da9f4db81695d22789d092414367e6/components/password_manager/core/common/password_manager_features.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4edbf868dbf1b7250f828136f3ef899462a626e0 commit 4edbf868dbf1b7250f828136f3ef899462a626e0 Author: Tatiana Gornak <melandory@chromium.org> Date: Tue Sep 19 11:08:06 2017 Manual fallback for password generation. This CL implements following logic: 1. "Generate a strong password..." fallback is shown 2. When user clicks on the fallback NO PASSWORD IS GENERATED. Instead the generation bubble is shown. 3. Only if the user clicks on the generation popup, then the password is generated and pre-saved. In this CL if user clicks out of the password field and then clicks back, the generation popup will appear again. No decision on what should appear was made yet. BUG= 739343 Change-Id: Ib01bb2a24f5106b29afd1f0ce1efac2aa830a06e Reviewed-on: https://chromium-review.googlesource.com/594148 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#502822} [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/chrome/renderer/autofill/password_generation_agent_browsertest.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/autofill/content/common/autofill_agent.mojom [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/autofill/content/renderer/password_generation_agent.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/autofill/content/renderer/password_generation_agent.h [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/autofill/core/browser/popup_item_ids.h [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/autofill_strings.grdp [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/content/browser/content_password_manager_driver.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/content/browser/content_password_manager_driver.h [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/core/browser/password_manager_driver.h [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/core/browser/stub_password_manager_driver.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/core/browser/stub_password_manager_driver.h [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/core/common/password_manager_features.cc [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/components/password_manager/core/common/password_manager_features.h [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h [modify] https://crrev.com/4edbf868dbf1b7250f828136f3ef899462a626e0/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ed5f0b501dc6704ecd8f554a33d1c5c1c7de7c commit f4ed5f0b501dc6704ecd8f554a33d1c5c1c7de7c Author: Tatiana Gornak <melandory@chromium.org> Date: Tue Sep 19 14:20:04 2017 Disable manual fallback for filling by default. BUG= 739343 Change-Id: I81eb671ca64b84df871bf071af6817117acbd9a5 Reviewed-on: https://chromium-review.googlesource.com/672544 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#502850} [modify] https://crrev.com/f4ed5f0b501dc6704ecd8f554a33d1c5c1c7de7c/components/password_manager/core/common/password_manager_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4def7e0d0522ccc4cabe3537acaf28bc9cfce084 commit 4def7e0d0522ccc4cabe3537acaf28bc9cfce084 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Sep 22 09:03:17 2017 Add a string for the iOS keyboard accessory to open all passwords. The implementation is coming soon. Bug: 739343 Change-Id: I2aa945541826ecf38656ba746f760a1f8dd6764d Reviewed-on: https://chromium-review.googlesource.com/678212 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#503695} [modify] https://crrev.com/4def7e0d0522ccc4cabe3537acaf28bc9cfce084/ios/chrome/app/strings/ios_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3040ef9076acf5380d4ce4f9e055dc542790768d commit 3040ef9076acf5380d4ce4f9e055dc542790768d Author: Tatiana Gornak <melandory@chromium.org> Date: Mon Sep 25 14:33:30 2017 Enable generation fallback in Content Menu by default. BUG= 739343 Change-Id: Idd36598d563920bf94f75eaad1cbf70b9078282a Reviewed-on: https://chromium-review.googlesource.com/681336 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#504047} [modify] https://crrev.com/3040ef9076acf5380d4ce4f9e055dc542790768d/components/password_manager/core/common/password_manager_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b commit 7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Sep 27 12:32:49 2017 "Show all saved passwords" option in context menu. This CL adds a "Show all saved passwords" in context menu. Clicking on this option opens password manager settings page. BUG= 739343 Change-Id: I6875a6956075d29fe548262c59f7468e3c27f32f Reviewed-on: https://chromium-review.googlesource.com/681941 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#504636} [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/chrome/app/chrome_command_ids.h [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/components/autofill_strings.grdp [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/components/password_manager/core/common/experiments.cc [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/components/password_manager/core/common/experiments.h [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/components/password_manager/core/common/password_manager_features.cc [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/components/password_manager/core/common/password_manager_features.h [modify] https://crrev.com/7d7b4b9bd42b7c66991f4f6d71c115f9e11ec13b/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e062dd15c1f25787dc28ed6f2640f2037c17d8c2 commit e062dd15c1f25787dc28ed6f2640f2037c17d8c2 Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Oct 04 13:00:09 2017 Mac capitalization option for Show-all-saved-passwords string BUG= 739343 Change-Id: Id767a406ae5f1971d61f5efcf0149326cd0f4436 Reviewed-on: https://chromium-review.googlesource.com/692375 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#506369} [modify] https://crrev.com/e062dd15c1f25787dc28ed6f2640f2037c17d8c2/components/autofill_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c7026ba04c426e4f66d3e7b4f42203671c87570 commit 8c7026ba04c426e4f66d3e7b4f42203671c87570 Author: Tatiana Gornak <melandory@chromium.org> Date: Tue Oct 17 18:50:01 2017 Restrict generation context menu item only to non passphrase sync users BUG= 739343 , 775509 Change-Id: I7f9b42cadd63c55c5b59d9787f6a41ff0742a556 Reviewed-on: https://chromium-review.googlesource.com/707436 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509459} [modify] https://crrev.com/8c7026ba04c426e4f66d3e7b4f42203671c87570/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/8c7026ba04c426e4f66d3e7b4f42203671c87570/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/8c7026ba04c426e4f66d3e7b4f42203671c87570/components/password_manager/core/browser/password_manager_util.h [modify] https://crrev.com/8c7026ba04c426e4f66d3e7b4f42203671c87570/components/password_manager/core/common/experiments.cc [modify] https://crrev.com/8c7026ba04c426e4f66d3e7b4f42203671c87570/components/password_manager/core/common/experiments.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/376b1551feed797687cbf362188efdf1ab5a718d commit 376b1551feed797687cbf362188efdf1ab5a718d Author: Tatiana Gornak <melandory@chromium.org> Date: Thu Oct 19 08:27:13 2017 Record metrics when "Show all saved passwords" is triggered from Context Menu. BUG= 739343 , 775825 Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0 Reviewed-on: https://chromium-review.googlesource.com/725342 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#510036} [modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/browser/password_manager_util.h [modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/common/experiments.cc [modify] https://crrev.com/376b1551feed797687cbf362188efdf1ab5a718d/components/password_manager/core/common/experiments.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73d16270fac6f7660e867123abda9761da60981f commit 73d16270fac6f7660e867123abda9761da60981f Author: Tatiana Gornak <melandory@chromium.org> Date: Thu Oct 19 09:48:08 2017 Restrict generation context menu item only to non passphrase sync users BUG= 739343 , 775509 TBR=melandory@chromium.org (cherry picked from commit 8c7026ba04c426e4f66d3e7b4f42203671c87570) Change-Id: I7f9b42cadd63c55c5b59d9787f6a41ff0742a556 Reviewed-on: https://chromium-review.googlesource.com/707436 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509459} Reviewed-on: https://chromium-review.googlesource.com/727763 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#65} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/browser/password_manager_util.h [modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/common/experiments.cc [modify] https://crrev.com/73d16270fac6f7660e867123abda9761da60981f/components/password_manager/core/common/experiments.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43b335030921dbc94cbadab8a78b981c0066c21a commit 43b335030921dbc94cbadab8a78b981c0066c21a Author: Tatiana Gornak <melandory@chromium.org> Date: Fri Oct 20 08:16:46 2017 Record metrics when "Generate a password" is triggered from Context Menu. BUG= 739343 , 775825 Change-Id: I12ba09c21afd4e2fd70e82974bb1720228b0829b Reviewed-on: https://chromium-review.googlesource.com/727894 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#510376} [modify] https://crrev.com/43b335030921dbc94cbadab8a78b981c0066c21a/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/43b335030921dbc94cbadab8a78b981c0066c21a/components/autofill/core/common/password_generation_util.h [modify] https://crrev.com/43b335030921dbc94cbadab8a78b981c0066c21a/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/43b335030921dbc94cbadab8a78b981c0066c21a/components/password_manager/core/browser/password_manager_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1 commit 885ce1e482d9f15f9c1bcf5cbf23ad91974278a1 Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Oct 25 13:49:08 2017 Record metrics when "Show all saved passwords" is triggered from Context Menu. BUG= 739343 , 775825 TBR=melandory@chromium.org (cherry picked from commit 376b1551feed797687cbf362188efdf1ab5a718d) Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0 Reviewed-on: https://chromium-review.googlesource.com/725342 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510036} Reviewed-on: https://chromium-review.googlesource.com/738205 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#212} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/browser/password_manager_util.h [modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/common/experiments.cc [modify] https://crrev.com/885ce1e482d9f15f9c1bcf5cbf23ad91974278a1/components/password_manager/core/common/experiments.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2b94a9c448ba0c04f4b96916e1503f180846a9a commit a2b94a9c448ba0c04f4b96916e1503f180846a9a Author: Tatiana Gornak <melandory@chromium.org> Date: Wed Oct 25 14:15:22 2017 Record metrics when "Generate a password" is triggered from Context Menu. BUG= 739343 , 775825 TBR=melandory@chromium.org (cherry picked from commit 43b335030921dbc94cbadab8a78b981c0066c21a) Change-Id: I12ba09c21afd4e2fd70e82974bb1720228b0829b Reviewed-on: https://chromium-review.googlesource.com/727894 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510376} Reviewed-on: https://chromium-review.googlesource.com/738208 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#213} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/components/autofill/core/common/password_generation_util.h [modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/a2b94a9c448ba0c04f4b96916e1503f180846a9a/components/password_manager/core/browser/password_manager_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f383f1835b2fbb523d01959f5284e54d81b499f commit 3f383f1835b2fbb523d01959f5284e54d81b499f Author: Tatiana Gornak <melandory@chromium.org> Date: Tue Nov 14 10:59:28 2017 Add dots to "Generate password" string BUG= 739343 Change-Id: I5821dd6bdf1eee4fd7aa3798818da307106ca4f6 Reviewed-on: https://chromium-review.googlesource.com/768710 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#516259} [modify] https://crrev.com/3f383f1835b2fbb523d01959f5284e54d81b499f/chrome/app/generated_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb7f63dbf34c96ad71646f1c1d7c72aa1923354c commit eb7f63dbf34c96ad71646f1c1d7c72aa1923354c Author: Tatiana Gornak <melandory@chromium.org> Date: Tue Nov 14 13:29:23 2017 Fix Mac capitalization for "Show all saved passwords string". BUG= 739343 Change-Id: I5d22b76b8a321eccb82a1811ea1a906a93435ac4 Reviewed-on: https://chromium-review.googlesource.com/768730 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#516285} [modify] https://crrev.com/eb7f63dbf34c96ad71646f1c1d7c72aa1923354c/components/autofill_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2758a93e38f0bfc46d82fe1fb8835027f693352b commit 2758a93e38f0bfc46d82fe1fb8835027f693352b Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Thu Jan 11 14:01:04 2018 [Password Manager] Ellipsis for "Generate Password" in the context menu for Mac It is a request from UX team. Adding ellipsis was missed in https://chromium-review.googlesource.com/c/chromium/src/+/768710 Bug: 739343 Change-Id: Idee4af773f06ada6f873d5066743f7cc63218ddb Reviewed-on: https://chromium-review.googlesource.com/860098 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#528617} [modify] https://crrev.com/2758a93e38f0bfc46d82fe1fb8835027f693352b/chrome/app/generated_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb2b02ace587fa16576949e93af4859811cd25f4 commit bb2b02ace587fa16576949e93af4859811cd25f4 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Wed Jan 31 14:12:10 2018 [Password Manager] Add missed rows to UMA enum In https://chromium-review.googlesource.com/c/chromium/src/+/725342, enum.xm wasn't updated properly. It should corresponds to |ShowAllSavedPasswordsContext| Bug: 739343 , 775825 Change-Id: I0129522e95414412aeb6f271d0aa07cc236801cf Reviewed-on: https://chromium-review.googlesource.com/893560 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533266} [modify] https://crrev.com/bb2b02ace587fa16576949e93af4859811cd25f4/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1483cf11e916987e2ac55146b102e324c3a54497 commit 1483cf11e916987e2ac55146b102e324c3a54497 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Jul 02 14:32:49 2018 Remove password generation in the drop-down feature. Password drop-down used to show "Generate password" as a fallback. The feature was never launched. Instead user may right-click a password field and select "Generate password" from the context menu. It's available on stable. Bug: 739343 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ide9bc9ed132e687cc81288de84b2b8f88d60c9ec Reviewed-on: https://chromium-review.googlesource.com/1112242 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571890} [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/chrome/renderer/autofill/password_generation_agent_browsertest.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/autofill/content/common/autofill_agent.mojom [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/autofill/content/renderer/password_generation_agent.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/autofill/content/renderer/password_generation_agent.h [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/autofill/core/browser/popup_item_ids.h [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/autofill_strings.grdp [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/content/browser/content_password_manager_driver.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/content/browser/content_password_manager_driver.h [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/core/browser/password_manager_driver.h [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/core/browser/stub_password_manager_driver.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/core/browser/stub_password_manager_driver.h [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/core/common/password_manager_features.cc [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/components/password_manager/core/common/password_manager_features.h [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h [modify] https://crrev.com/1483cf11e916987e2ac55146b102e324c3a54497/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b25d77777d6f597582bdcb75ffcd4b1d849a6c91 commit b25d77777d6f597582bdcb75ffcd4b1d849a6c91 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Jul 05 18:31:15 2018 Remove standalone "Show all passwords" feature. The feature showed a dropdown with the only item "Show all passwords" when user clicks on a password field and no credentials were saved for the page. The feature isn't scheduled for launch and, therefore, removed. Bug: 739343 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2c68bb8f6f5d1caa49d1b1547a2bc9df41e82138 Reviewed-on: https://chromium-review.googlesource.com/1126250 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572831} [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/chrome/renderer/autofill/fake_content_password_manager_driver.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/chrome/renderer/autofill/fake_content_password_manager_driver.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/autofill/content/common/autofill_agent.mojom [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/autofill/content/common/autofill_driver.mojom [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/autofill/content/renderer/password_form_conversion_utils.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/autofill/content/renderer/password_form_conversion_utils.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/content/browser/content_password_manager_driver.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/content/browser/content_password_manager_driver.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/new_password_form_manager_unittest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_autofill_manager.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_form_filling.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_form_filling_unittest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_generation_manager_unittest.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_manager_driver.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_manager_metrics_recorder.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/stub_password_manager_driver.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/browser/stub_password_manager_driver.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/common/password_manager_features.cc [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/components/password_manager/core/common/password_manager_features.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h [modify] https://crrev.com/b25d77777d6f597582bdcb75ffcd4b1d849a6c91/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
Comment 1 by melandory@chromium.org
, Jul 5 201716.5 KB
16.5 KB View Download