New issue
Advanced search Search tips

Issue 739342 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT import] Imports are failing on git cl upload --send-mail due to expecting input

Project Member Reported by foolip@chromium.org, Jul 5 2017

Issue description

https://chromium-review.googlesource.com/c/558774 was a successful run (although see  issue 739341 ) but was not landed because:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpYChX_g/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpYChX_g/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 112, in main
    commit_successful = self.do_auto_update()
  File "/mnt/data/b/rr/tmpYChX_g/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 363, in do_auto_update
    self.git_cl.run(['upload', '--send-mail'])  # Turn off WIP mode.
  File "/mnt/data/b/rr/tmpYChX_g/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py", line 51, in run
    return self._host.executive.run_command(command, cwd=self._cwd)
  File "/mnt/data/b/rr/tmpYChX_g/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 339, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/mnt/data/b/rr/tmpYChX_g/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 247, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'upload', '--send-mail']" exit_code: 1
output: Last 500 characters of output:
.py", line 4904, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/mnt/data/b/depot_tools/git_cl.py", line 1657, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
  File "/mnt/data/b/depot_tools/git_cl.py", line 2908, in CMDUploadChange
    'Title for patchset [%s]: ' % default_title) or default_title
  File "/mnt/data/b/depot_tools/git_cl.py", line 184, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
step returned non-zero exit code: 1

It looks like the git cl upload --send-mail script was expecting user input, and failed because of that.

Is there some other way to change the WIP bit on Gerrit?
 
Components: Blink>Infra>Ecosystem
Cc: qyears...@chromium.org
 Issue 739377  has been merged into this issue.
Cc: -qyears...@chromium.org
Status: Started (was: Assigned)
Just checked, and it seems all we need to do to make it not expect use input is to also pass the -f flag.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a115df196a948210841258407aaab2dbfa80a747

commit a115df196a948210841258407aaab2dbfa80a747
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Jul 06 00:11:37 2017

wpt-import: Add -f flag when turning off WIP mode

Bug:  739342 
Change-Id: I3848dd3d0edc3073e6d5c88d3dda3b90588d7741
Reviewed-on: https://chromium-review.googlesource.com/559971
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484381}
[modify] https://crrev.com/a115df196a948210841258407aaab2dbfa80a747/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
The latest import has now gotten passed the --send-mail step, and is on track for landing (https://chromium-review.googlesource.com/c/562078/).

Sign in to add a comment