New issue
Advanced search Search tips

Issue 739341 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT import] Importer attempts an import even with no changes

Project Member Reported by foolip@chromium.org, Jul 5 2017 
https://chromium-review.googlesource.com/c/558774

In this CL, wpt had changed, but it was an export, so the net result was no change. The importer proceeded to create a CL anyway, attempting also to add a lot of crash expectations.

Before creating a review, could we check if there are any changes in LayoutTests/external/wpt?

Low priority because even when successful, a CL like this is no more likely to cause trouble than an import with actual changes.

Comment 1 by qyears...@chromium.org, Jul 5 2017 

Even if there is no export, the importer would create a CL here as long as running the manifest script yields a change.

The addition of Crash expectations in that CL may have been a one-off thing that happened because some tests crashed flakily on some bots.

Currently, the manifest is updated before adding new baselines, so if new baselines are added then the next import always contains a change in WPT_MANIFEST_BASE.json adding entries for those baselines.

This would be solved by running the manifest script again after uploading baselines. I thought I filed an issue for this before, but can't find one -- so the next step for this CL would be to make the importer run the manifest script again after updating baselines.

Comment 2 by foolip@chromium.org, Jul 5 2017 

Optimizing this away sounds like more code that could go wrong, so maybe this is a WontFix?

Comment 3 by qyears...@chromium.org, Jul 5 2017

Status: WontFix (was: Available)
Yeah, I think so -- in general, making import CLs with just changes in WPT_MANIFEST_BASE.json is OK (not harmful), and in if there are flaky crashes in the try jobs and a bunch of crash expectations are added, but not reproduced in the CQ, then the import should just be abandoned and retried.
►

Sign in to add a comment