New issue
Advanced search Search tips

Issue 739334 link

Starred by 2 users
Status: Fixed
Owner:
drott@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Follow up on animation type of font-weight in CSS Fonts Level 4

Project Member Reported by drott@chromium.org, Jul 5 2017 
https://drafts.csswg.org/css-fonts-4/#font-weight-prop describes animation type as discrete, without explicitly specifying the discrete steps, but probably refering to the 100,200,300,400,500,600,700,800,900 increments of CSS Fonts Level 3. 

We should follow up on this in hub.com/w3c/csswg-drafts/labels/css-fonts-4

Comment 2 by ericwilligers@chromium.org, Oct 14 2017 

https://github.com/w3c/csswg-drafts/issues/1579
has been resolved with a spec update.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4efaade7d3ac75ccb2124a3c06b37ad0e26dbd82

commit 4efaade7d3ac75ccb2124a3c06b37ad0e26dbd82
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Oct 26 16:20:51 2017

Animate font-weight smoothly

After the working group has resolved this issue [1] and decided it is
okay to animate font-weight as number, remove our clamping to discrete
values and update our test case.

[1] https://github.com/w3c/csswg-drafts/issues/1579

Bug:  739334 
Change-Id: I7d3a18dd192e1b4b8a5728a0fff43d11bcaf5ae2
Reviewed-on: https://chromium-review.googlesource.com/720814
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511839}
[modify] https://crrev.com/4efaade7d3ac75ccb2124a3c06b37ad0e26dbd82/third_party/WebKit/LayoutTests/animations/composition/font-weight-composition.html
[modify] https://crrev.com/4efaade7d3ac75ccb2124a3c06b37ad0e26dbd82/third_party/WebKit/LayoutTests/animations/interpolation/font-weight-interpolation.html
[modify] https://crrev.com/4efaade7d3ac75ccb2124a3c06b37ad0e26dbd82/third_party/WebKit/LayoutTests/animations/responsive/interpolation/font-weight-responsive.html
[modify] https://crrev.com/4efaade7d3ac75ccb2124a3c06b37ad0e26dbd82/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/4efaade7d3ac75ccb2124a3c06b37ad0e26dbd82/third_party/WebKit/Source/platform/fonts/FontSelectionTypes.h

Comment 4 by drott@chromium.org, Oct 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment