New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739314 link

Starred by 4 users

Issue metadata

Status: Fixed
Merged: issue 735855
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : 'IP address','Routing prefix' & 'Gateway' details are seen missing at 'Configure IP address automatically' option for Dongle connection in chrome://md-settings

Project Member Reported by mmanchala@chromium.org, Jul 5 2017

Issue description

Chrome Version 61.0.3147.0/9714.0.0 dev channel Wolf,Gnawty and Parrot
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User ->Insert Mobile Dongle and ensure it is connected
(2)Now go to chrome://md-settings page -> At 'Network' click on Mobile data connection
(3)Now In Connected Dongle page-> scroll down and click on 'Network' -> observe 'IP address','Routing prefix' & 'Gateway' details are seen missing at 'Configure IP address automatically' (Please refer video and screenshot)

Note: Above details are displayed after disabling and enabling 'Configure IP address automatically' option

Expected: 'IP address','Routing prefix' & 'Gateway' details should be displayed directly under 'Configure IP address automatically' option

Actual: Instead 'IP address','Routing prefix' & 'Gateway' details are seen missing

This is Regression issue as same is working fine in chrome://settings.

@stevenjb : Please confirm the issue
 
Actual_IPAddressNotDisplayed.webm
1.0 MB View Download
Actual_IPAddressNotDisplayed.jpg
104 KB View Download
Expected_IPAddressDisplayed.jpg
104 KB View Download
Expected_IPAddressDisplayed.webm
639 KB View Download
Mergedinto: 735855
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
As per comment #1 735855 Issue is related to Wi-Fi page and it is working fine in 61.0.3153.0/9733.0.0.But My Issue is related to Dongle Connection
i.e. Go to chrome://md-settings -> First click on Mobile data connection at 'Network'(Disable Wi-Fi/dont click on Wi-Fi page)
Now In Connected Dongle page -> scroll down and click on 'Network' -> observe 'IP address','Routing prefix' & 'Gateway' details are seen missing at 'Configure IP address automatically' (Please refer video and screenshot)
Issue is reproducible on Latest M-61 i.e. 61.0.3153.0/9733.0.0
Attaching Video for Reference.

Note: Above details are displayed after disabling and enabling 'Configure IP address automatically' option

Actual_IPAddressInDongleConnectionPageIn61.0.3153.0.webm
2.9 MB View Download
Labels: -Pri-1 Pri-2
Hmm. I see. I'll try to take a look. Since dongles are not well supported in general on Chrome OS, lowering this to a P2.

Cc: benchan@chromium.org
Looking more closely, even though the network appears to be connected, it does not appear to have an IP address. This may be because it is not active (since the devices is already connected to Ethernet)? Normally the IP Address would appear above 'Advanced'.

Could you file a feedback report and include the report title here so that I can confirm that?

+benchan@

Labels: Needs-Feedback
Labels: Hotlist-MD-Settings-Internet
Labels: -M-61 M-62
Labels: -M-62 M-63
Cc: ejcaruso@chromium.org cernekee@chromium.org
OK, I can reproduce this with a 'cricket' modem and a Fi SIM.

It looks like Chrome is receiving IPConfigs from Shill, so I'm not sure what is going on here, I will need to do some more digging.

OK, it looks like the fundamental problem here is that with a dongle, the Cellurl Device does not have the IPConfig property set.

The Service however does, so we may be able to work around this by using the Service IP config (which does appear to be present) instead.

I'm not entirely sure why we use Device.IPConfigs instead of Service.IPConfig, but it looks like it may be that Device has both ipv4 and ipv6 configs in an array, but Service just has the one set (presumably ipv4).

Yeah, AFAIK, querying the Device is the best way to obtain all IPConfigs.

It looks to me like Service.IPConfig will return an IPv4 configuration if one is present.
Right. I'm going to add a stopgap fix for now, but we should fix this in Shill (specificaly fix the fact that a Cellular dongle does not have an IPConfigs entries).

The problem is related to cellular dongles that use PPP, where the IPConfigs property isn't updated properly.   On other cellular devices, I can see the Device.IPConfigs property set properly.
CL is up for the Chrome side fix:
https://chromium-review.googlesource.com/c/chromium/src/+/730572

Status: Started (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48e8b30639c2ab30b3dfd93786930285025b5d63

commit 48e8b30639c2ab30b3dfd93786930285025b5d63
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Oct 24 22:49:18 2017

Network: Cellular: Provide IPConfigs for external devices

Shill may not provide IPConfigs for external Cellular devices
(i.e. dongles), so we need to build a dictionary of ipv4 properties
from cached properties in NetworkState ( crbug.com/739314 ) so that
the UI can display them.

For minor chromeos specific changes to dial_service.cc:
TBR=imcheng@chromium.org
 

Bug:  739314 
Change-Id: Ic66654795e5062ff10d52121ef6c0bca3fc8868b
Reviewed-on: https://chromium-review.googlesource.com/730572
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511290}
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/ash/system/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chrome/browser/media/router/discovery/dial/dial_service.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chromeos/network/dhcp_proxy_script_fetcher_chromeos.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chromeos/network/managed_network_configuration_handler_impl.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chromeos/network/network_change_notifier_chromeos.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chromeos/network/network_change_notifier_chromeos.h
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chromeos/network/network_change_notifier_chromeos_unittest.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chromeos/network/network_state.cc
[modify] https://crrev.com/48e8b30639c2ab30b3dfd93786930285025b5d63/chromeos/network/network_state.h

Labels: -M-63 M-64
Status: Fixed (was: Started)
This only applies to external cellular devices (dongles), I don't think it is critical for 63.

Sign in to add a comment