New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739305 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.7%-20.7% regression in smoothness.gpu_rasterization.tough_path_rendering_cases at 483366:483641

Project Member Reported by rmcilroy@chromium.org, Jul 5 2017

Issue description

See the link to graphs below.
 
Cc: hamelphi@chromium.org
Owner: hamelphi@chromium.org

=== Auto-CCing suspected CL author hamelphi@chromium.org ===

Hi hamelphi@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : hamelphi
  Commit : a140aabaf85a21c7085e76d039171c1479d53987
  Date   : Thu Jun 29 16:55:10 2017
  Subject: Move android config for Ranker experiments with CompactUI.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : loading.mobile
  Metric       : timeToFirstContentfulPaint_avg/Regular-3G/58Pic
  Change       : 19.81% | 52743.5856667 -> 63190.2

Revision             Result                  N
chromium@483365      52743.6 +- 1334.44      6      good
chromium@483384      52310.3 +- 2220.72      6      good
chromium@483389      52242.5 +- 1026.21      6      good
chromium@483390      62250.2 +- 2591.24      6      bad       <--
chromium@483391      62963.7 +- 1845.46      6      bad
chromium@483393      62384.9 +- 2037.41      6      bad
chromium@483402      63187.3 +- 1161.19      6      bad
chromium@483439      63174.4 +- 1448.46      6      bad
chromium@483513      62543.5 +- 1880.41      6      bad
chromium@483641      63190.2 +- 922.388      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=58Pic loading.mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8974917848327000720


For feedback, file a bug with component Speed>Bisection
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
Sorry for the delay, I was OOO.

What the CL mentioned above effectively does is turning off field trials for TranslateRankerQuery on Android (since, as I understand it, only the first experiment of the list is run in field trials).

So, what this alert points to is that TranslateRankerQuery actually improves this metric. This feature will soon be the default behavior once we launch in stable (https://bugs.chromium.org/p/chromium/issues/detail?id=646711).

Closing as won't fix.

Sign in to add a comment