New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739289 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline badge mistakenly shown

Project Member Reported by fhorschig@chromium.org, Jul 5 2017

Issue description

Chrome Version: 61 (probably earlier)
OS: Android

What steps will reproduce the problem?
(1) Start chrome with customizied home page (e.g. with command line flag  --partner-homepage-for-testing="http://www.android.com")
(2) Make sure Chrome Home is enabled (#enable-chrome-home, should be default)
(3) Disable home page in settings (verify the first CrHome tile is not "Android")
(4) Enable home page in setting

What is the expected result?
The first tile on CrHome should be present but have no offline badge.

What happens instead?
The first tile on CrHome is present but has an offline badge.
It disappears when clicking the tile.


Maybe this issue is related to/can help to solve issue 679428. (Hence the initial owner.)
 
Status: Started (was: Assigned)
I cannot reproduce this, could you take a video?

(I've attached a Python 2 helper script for screen recording that may be helpful).
screenrecord.py
812 bytes View Download
Cc: fhorschig@chromium.org
@fhorschig, I'm having difficultly reproducing this (comment 2)
Here are my attempts to reproduce (on ToT).
2017-07-06_17-38-46.mp4
16.8 MB Download
2017-07-06_17-39-54.mp4
13.6 MB View Download
I attached a video of the issue.
But you are right, it is apparently harder to reproduce than I thought. I had to pay attention that:

1. all application data was cleared.
2. I did not disable and enable the Homepage without opening CrHome in between.
3. No reload of the home page happened in between.

(If you see the badge and tap the tile or reload the home page, it will disappear but can be brought back by just disabling the home page. The tile with the home page originates from top sites but the badge is still shown.)


PS: Thank you so much for that script! I had no idea that there is a screen recorder App in Android.
OfflineBadgeOnHomeTile.mp4
11.0 MB View Download

Comment 6 by fi...@chromium.org, Jul 20 2017

Labels: -Pri-1 zine-triage M-62 Pri-2
Sounds more like a P2 to me (if not P3)

Comment 7 by fi...@chromium.org, Jul 20 2017

Labels: -zine-triage zine-triaged

Comment 8 by fi...@chromium.org, Sep 18 2017

Labels: -M-62 M-63
punting it to M-63. 

@fhorschig: Are you still able to reproduce?
Interesting, it doesn't seem to be specific to the home tile. In the attached screenshot, it happened to the first tile (cnn.com).
Screenshot_20170926-105718.png
758 KB View Download
I'm looking into this - it looks like the OfflinePageBridge#selectPageForOnlineUrl is calling the Callback so the problem is with the offline page bridge, not the UI. I'll look a bit further.
I don't believe this is specific to the home or the first tile - I believe it happens to whatever tile you happen to have open at the time you toggle the homepage on and off again.
Labels: -M-63 M-64
Labels: -M-64 M-65
Any updates here?

Comment 15 by fi...@chromium.org, Jan 12 2018

gentle ping :-)
I started a conversation about this [1], which lead to some product questions and fizzled out. Where should we go from here?


[1] - https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/offline-dev/V7IgdTwTW_g/CJXTL2R-BgAJ

Sign in to add a comment