authpolicy: Improve domain join error messaging |
||||||||||||||
Issue descriptionIdentify the most common error cases and make sure it's messaged right. In particular, if the user who joins a machine has to change their password, the error message isn't very helpful right now.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b464732ef2cdb408ad79eef03debc2b8d22f5f9 commit 8b464732ef2cdb408ad79eef03debc2b8d22f5f9 Author: Lutz Justen <ljusten@chromium.org> Date: Thu Jul 13 08:07:49 2017 UI tweaks for Active Directory enrollment and user auth On the logon screen, "Username (e.g. user@example.com)" was intersecting with @example.com. This CL removes the "e.g." part since it's really not necessary given that we autofill. Adds an error message if the user who is joining a device has an expired password. Ideally, we'd add UI to update the password in the future like we do for regular user auth. If a user joining a device misspelled the domain name, a generic network error message was displayed. This CL updates this message and asks the user to check both network and domain name. Samba doesn't really give a clue which one is the culprit. Displays a proper error message for the catch-all default error case during domain join. Before, no error was displayed at all. BUG= chromium:739280 TEST=Tested on device. Change-Id: Ibe028f66d50f437532696d7e934a96ff38020dc3 Reviewed-on: https://chromium-review.googlesource.com/567007 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#486315} [modify] https://crrev.com/8b464732ef2cdb408ad79eef03debc2b8d22f5f9/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/8b464732ef2cdb408ad79eef03debc2b8d22f5f9/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/8b464732ef2cdb408ad79eef03debc2b8d22f5f9/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Jul 13 2017
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f1b1ca1894434fc6a47adf7d29adf03d467db5cd commit f1b1ca1894434fc6a47adf7d29adf03d467db5cd Author: Lutz Justen <ljusten@chromium.org> Date: Thu Jul 13 18:44:42 2017 authpolicy: Improve domain join error messaging Detects expired passwords during domain join and returns the proper error code. Note that Chrome doesn't handle this error yet. The error is silently eaten. BUG= chromium:739280 TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy Change-Id: I2f3969bae96107614e8db477aa30b00916ef59aa Reviewed-on: https://chromium-review.googlesource.com/566828 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/f1b1ca1894434fc6a47adf7d29adf03d467db5cd/authpolicy/stub_net_main.cc [modify] https://crrev.com/f1b1ca1894434fc6a47adf7d29adf03d467db5cd/authpolicy/authpolicy_unittest.cc [modify] https://crrev.com/f1b1ca1894434fc6a47adf7d29adf03d467db5cd/authpolicy/samba_interface.cc
,
Jul 19 2017
Reopening. On the "Join device to domain" screen it only says "Username" now, should say "Username (e.g. user@example.com)".
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b9273633e64360208a947b7176d3b36dcb544a5 commit 1b9273633e64360208a947b7176d3b36dcb544a5 Author: Lutz Justen <ljusten@chromium.org> Date: Mon Jul 24 09:42:32 2017 More UI tweaks for Active Directory enrollment and user auth In CL:567007, the user name label on the Active Directory auth screen was changed from "Username (e.g. user@example.com)" to "Username" since the example overlapped with the domain, which was displayed as well. However, the enrollment UI uses the same HTML code and the example was removed there, too. This CL brings it back. Also fixes an alignment issue where the example was 2px too high. BUG= chromium:742726 , chromium:739280 TEST=Tested on Linux box Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaa64c8610f9f720f770b5b7ed79e39371fb910f0 Reviewed-on: https://chromium-review.googlesource.com/579091 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488937} [modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/gaia_input.css [modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/offline_ad_login.html [modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/offline_ad_login.js [modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html [modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/resources/chromeos/login/screen_gaia_signin.html [modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/1b9273633e64360208a947b7176d3b36dcb544a5/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Jul 24 2017
,
Jul 24 2017
Reopened to merge last CL to M-61 (todo: test on canary channel first).
,
Jul 28 2017
I'd like to merge https://chromium-review.googlesource.com/579091 to M61 (the rest is already in). It's a product excellence thing. Biggest concern is that without this CL, we show "Username" on the Active Directory enrollment screen, but the user has to enter username@example.com. This will lead to confusion among the (small) number of testers. This is a new product, so it won't have many users.
,
Jul 28 2017
This bug requires manual review: There is .grd file changes and we are only 38 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
Approving merge to M61 Chrome OS.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44dba5e01501b387dbf2f1c67207c84bc86f9299 commit 44dba5e01501b387dbf2f1c67207c84bc86f9299 Author: Pavol Marko <pmarko@chromium.org> Date: Mon Jul 31 08:01:38 2017 [Merge to M61] More UI tweaks for Active Directory enrollment and user auth Merge on behalf of ljusten@. In CL:567007, the user name label on the Active Directory auth screen was changed from "Username (e.g. user@example.com)" to "Username" since the example overlapped with the domain, which was displayed as well. However, the enrollment UI uses the same HTML code and the example was removed there, too. This CL brings it back. Also fixes an alignment issue where the example was 2px too high. BUG= chromium:742726 , chromium:739280 TEST=Tested on Linux box TBR=ljusten@chromium.org, pmarko@chromium.org (cherry picked from commit 1b9273633e64360208a947b7176d3b36dcb544a5) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaa64c8610f9f720f770b5b7ed79e39371fb910f0 Reviewed-on: https://chromium-review.googlesource.com/579091 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488937} Reviewed-on: https://chromium-review.googlesource.com/593317 Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#145} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/gaia_input.css [modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/offline_ad_login.html [modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/offline_ad_login.js [modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html [modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/resources/chromeos/login/screen_gaia_signin.html [modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/44dba5e01501b387dbf2f1c67207c84bc86f9299/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
,
Aug 2 2017
I believe it's fixed.
,
Aug 16 2017
,
Jan 22 2018
,
Jun 21 2018
,
Jun 22 2018
Verified fixed, tested the following domain join error messaging: - expired password (screenshot 1) - misspelled domain name (screenshot 2) - misspelled password (screenshot 3) Chrome OS: 10718.30.0 Chrome: 68.0.3440.34 Device: Robo |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by ljusten@chromium.org
, Jul 11 2017