MD notification: Button labels are not capitalized. |
|||||||
Issue descriptionAccording to the spec, the button labels should be capitalized.
,
Jul 6 2017
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6c9801027065551008297762dacd1b6631e3aa1 commit b6c9801027065551008297762dacd1b6631e3aa1 Author: tetsui <tetsui@chromium.org> Date: Fri Jul 07 05:44:36 2017 Adjust action button styling in MD notification. Adjusted action button syling to match the mock in MD notification. * Capitalized the button label string. * Centered the button label string. BUG= 739269 , 739270 TEST=manual Review-Url: https://codereview.chromium.org/2971123002 Cr-Commit-Position: refs/heads/master@{#484840} [modify] https://crrev.com/b6c9801027065551008297762dacd1b6631e3aa1/ui/message_center/views/notification_view_md.cc
,
Jul 7 2017
,
Aug 4 2017
Verified on M61 (Chrome OS 9765.16.0, 61.0.3163.30 dev build).
,
Aug 4 2017
I suppose this issue still persists on M62 (Chrome OS 9807.0.0, 62.0.3176.0 dev build). Please refer the attachment, I observe that the Button label is not centered.
,
Aug 7 2017
mkarkada@: Sorry for the confusing description, but this bug mentions about Chrome OS native notification, which is different from ARC notification (Android apps on Chrome OS). In your screenshot, the "Screenshot taken" notification is Chrome OS native notification, and "Hangouts" notification is ARC notification. To verify this item, you have to enable new-style in native notification. 1. Open chrome://flags 2. Enable "New style notification". 3. Take screenshot. 4. Screenshot taken notification should be shown in different style, and the buttons should be centered. Thank you for verifying.
,
Aug 7 2017
@tetsui: Thank you for detailing me through this bug verification. Attached are the screenshots where I have tried scenarios to verify Chrome OS native notification with button label in it. The bug seems to be fixed. But, please confirm if this is the expected one. Else, you can provide me a scenario to create Chrome OS native notification that contains a button in it. I will verify and close this bug. Tested on M62 (Chrome OS 9817.0.0, 62.0.3176.0 dev build) with "New style notification" enabled.
,
Aug 8 2017
Sorry for not making clear description again, but i think it's still not verified. In #8, only "Screenshot taken" notification is the native notification. On the notification, could you press the arrow on the right of "Screenshot . 12m"? This will expand the notification, and buttons will appear on the bottom of the notification. I appreciate your cooperation.
,
Aug 8 2017
Thank you for giving me the steps to verify. I created 'Screenshot taken' and 'Download manager' notifications. On both the notifications and as per #9, I could see the buttons on them. The Button labels are capitalized as well as centered and looks like this bug is verified. Attached is the screenshot for reference. Once you confirm, I close this bug. Thank you for your time.
,
Aug 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tetsui@chromium.org
, Jul 5 2017