New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 739259 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Chrome crashes on navigating to chrome://settings/help after resetting browser.

Reported by aiman.an...@etouch.net, Jul 5 2017

Issue description

Chrome Version: 61.0.3149.0 (Official Build) (64-bit) (cohort: Stable) 4485eb651f6f09c3183285927fe82d17fcd7a13e-refs/heads/master@{#484159}(32/64 Bit).

OS:  Windows(7,8,10), Mac(10.12.3, 10.11.6) and Linux(14.04 LTS).

Pre-condition: Enable Material Design settings flag from chrome://flags.

Steps to reproduce:
1.Launch Chrome, go to chrome://settings/reset from Main Menu.
2.Click on Reset Button on Reset overlay.
3.Immediately click on wrench icon, go to About Google Chrome from Help option and observe. (Kindly refer the attached screen cast)

Actual Result: Browser crash is observed.
Expected Result: Browser should not crash.

This is regression issue broken in 'M 55' and will soon update the bisect info:

Crash Report ID 710bc3de40000000 (Local Crash ID: 16ddd135-fd30-47ed-b065-563433552faa)

Manual Bisect:
Good Build: 55.0.2844.0
Bad Build: 55.0.2845.0
 
Actual Result.mp4
1.6 MB View Download
Expected Result.mp4
2.0 MB View Download
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Providing the below details as per crash id (710bc3de40000000) from crash server.

Stack Trace:
------------
Thread 0 (id: 212) CRASHED [EXCEPTION_BREAKPOINT @ 0x000007fed34cb108 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x000007fed34cb108	(chrome.dll -web_ui_message_handler.cc:80 )	content::WebUIMessageHandler::ResolveJavascriptCallback(base::Value const &,base::Value const &)
0x000007fed448c6b5	(chrome.dll -reset_settings_handler.cc:160 )	settings::ResetSettingsHandler::OnResetProfileSettingsDone(std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,reset_report::ChromeResetReport_ResetRequestOrigin)
0x000007fed448bddd	(chrome.dll -bind_internal.h:209 )	base::internal::FunctorTraits<void ( settings::ResetSettingsHandler::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,reset_report::ChromeResetReport_ResetRequestOrigin),void>::Invoke<base::WeakPtr<settings::ResetSettingsHandler> const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,bool const &,reset_report::ChromeResetReport_ResetRequestOrigin const &>(void ( settings::ResetSettingsHandler::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,reset_report::ChromeResetReport_ResetRequestOrigin),base::WeakPtr<settings::ResetSettingsHandler> const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,bool const &,reset_report::ChromeResetReport_ResetRequestOrigin const &)
0x000007fed448ce65	(chrome.dll -bind_internal.h:329 )	base::internal::Invoker<base::internal::BindState<void ( settings::ResetSettingsHandler::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,reset_report::ChromeResetReport_ResetRequestOrigin),base::WeakPtr<settings::ResetSettingsHandler>,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,reset_report::ChromeResetReport_ResetRequestOrigin>,void >::Run(base::internal::BindStateBase *)
0x000007fed2a2cbc4	(chrome.dll -task_annotator.cc:59 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x000007fed29d4ad5	(chrome.dll -message_loop.cc:422 )	base::MessageLoop::RunTask(base::PendingTask *)
0x000007fed29d5632	(chrome.dll -message_loop.cc:540 )	base::MessageLoop::DoWork()
0x000007fed2a2d15e	(chrome.dll -message_pump_win.cc:173 )	base::MessagePumpForUI::DoRunLoop()
0x000007fed2a2cdc3	(chrome.dll -message_pump_win.cc:56 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x000007fed29fa238	(chrome.dll -run_loop.cc:111 )	base::RunLoop::Run()
0x000007fed37c42b7	(chrome.dll -chrome_browser_main.cc:1960 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x000007fed31bbcf5	(chrome.dll -browser_main_loop.cc:1142 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x000007fed31bd399	(chrome.dll -browser_main_runner.cc:142 )	content::BrowserMainRunnerImpl::Run()
0x000007fed31b7b27	(chrome.dll -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const &)
0x000007fed371cc7e	(chrome.dll -content_main_runner.cc:407 )	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x000007fed371cac7	(chrome.dll -content_main_runner.cc:696 )	content::ContentMainRunnerImpl::Run()
0x000007fed3739745	(chrome.dll -main.cc:469 )	service_manager::Main(service_manager::MainParams const &)
0x000007fed371c2df	(chrome.dll -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const &)
0x000007fed2e934e8	(chrome.dll -chrome_main.cc:133 )	ChromeMain
0x000000013f3d6282	(chrome.exe -main_dll_loader_win.cc:199 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x000000013f3d53c2	(chrome.exe -chrome_exe_main_win.cc:268 )	wWinMain
0x000000013f4074c2	(chrome.exe -exe_common.inl:253 )	__scrt_common_main_seh
0x76fe652c	(kernel32.dll + 0x0001652c )	BaseThreadInitThunk
0x7711c520	(ntdll.dll + 0x0002c520 )	RtlUserThreadStart

Using code search for the file, "web_ui_message_handler.cc" suspecting the following CL.

https://chromium.googlesource.com/chromium/src/+log/b93d74abe840be04755517e2b54d0a5b23d47df2/content/browser/webui/web_ui_message_handler.cc

@tommycli: Could you please look into the issue, this stack trace is similar to ("https://bugs.chromium.org/p/chromium/issues/detail?id=705366").kindly re-assign if this is not related to your changes.

Thank you! 



Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13a8f06cfdbacd09a0b8c8709d83cbb073c73fb2

commit 13a8f06cfdbacd09a0b8c8709d83cbb073c73fb2
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Jul 28 17:09:49 2017

MD Settings: Make ResetSettingsHandler gracefully reject late callbacks.

Previously, it would act on callbacks from ProfileResetter even if
JavaScript has been disallowed (page gone or refreshed).

Now we cancel those callbacks. We use the same strategy in
ProfileInfoHandler.

Bug:  739259 
Change-Id: I4cce50dd899c1e31d89be13a61dfb739c20b4e84
Reviewed-on: https://chromium-review.googlesource.com/590735
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490435}
[modify] https://crrev.com/13a8f06cfdbacd09a0b8c8709d83cbb073c73fb2/chrome/browser/ui/webui/settings/reset_settings_handler.cc
[modify] https://crrev.com/13a8f06cfdbacd09a0b8c8709d83cbb073c73fb2/chrome/browser/ui/webui/settings/reset_settings_handler.h

Labels: TE-Verified-62.0.3172.0 TE-Verified-M62
Status: Fixed (was: Assigned)

Sign in to add a comment