New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 739258 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Jul 2017
Cc:
xiaoche...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools]Unnecessary red underline seen in HEX textbox on colorpicker window.

Reported by dchau...@etouch.net, Jul 5 2017 
Chrome Version: 61.0.3149.0 (Official Build)4485eb651f6f09c3183285927fe82d17fcd7a13e-refs/heads/master@{#484159} 32/64-bit.
OS: Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome, open DevTools and go to 'Styles' section.
2. Click on bidirectional arrow icon such that 'HEX' textbox appears.
3. Now, click in 'HEX' textbox and observe.

Unnecessary red underline seen in HEX textbox.
Red underline should not seen in HEX textbox.

This is a regression issue, broken in M-61 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Jul 5 2017

Labels: OS-Linux OS-Mac
Correction: 
1. After step-1, open "Color picker" window under 'Styles' section and then perform step-2 and step-3
2. This issue is broken in M-58 series, below is manual regression range:

Good build: 58.0.3022.0 
Bad build: 58.0.3023.0

Note: 
1. If issue is not reproducible at first instance then again repeat all the steps.
2. This issue is also reproducible on Linux(14.04 LTS) and Mac(10.11.6, 10.12.3) OS.

Kindly review the attached screen-cast for reference.
Colorpicker_Screenshot.png
91.2 KB View Download
Actual behavior.mp4
1.0 MB View Download
Expected behavior.mp4
1.2 MB View Download

Comment 2 by msrchandra@chromium.org, Jul 5 2017

Labels: hasbisect-per-revision
Owner: xiaoche...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3022.0 (Revision: 452713).
Bad build : 58.0.3023.0 (Revision: 453044).

You are probably looking for a change made after 452898 (known good), but no later than 452899 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/f8de71db706d577e6f8e0407679277022af6c8d2..0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e

@xiaochengh: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.

Comment 3 by xiaoche...@chromium.org, Jul 5 2017

Cc: xiaoche...@chromium.org
Owner: pfeldman@chromium.org
My CL fixes a bug that text in <input> and <textarea> is not checked when not ending with a punctuation.

DevTools team: could you add spellcheck=false attribute to that color <input>? Thanks!

Comment 4 by pfeldman@chromium.org, Jul 5 2017

Owner: l...@chromium.org
@xiaochengh: we can do it, but the web might not like it...
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9043ebe56432326324806ef8a76c05861f3eb77

commit c9043ebe56432326324806ef8a76c05861f3eb77
Author: luoe <luoe@chromium.org>
Date: Thu Jul 13 00:03:38 2017

DevTools: disable spellcheck for inputs by default

BUG= 739258 

Review-Url: https://codereview.chromium.org/2972943002
Cr-Commit-Position: refs/heads/master@{#486167}

[modify] https://crrev.com/c9043ebe56432326324806ef8a76c05861f3eb77/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Comment 6 by l...@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)

Comment 7 by dchau...@etouch.net, Jul 18 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3159.5
Retested this issue on Windows, Mac and Linux machine using Dev build # 61.0.3159.5 (Official Build). It seems to be fixed and working as intended i.e. red underline is not seen in HEX textbox.

Attaching screen-cast for the same.
Dev 61.0.3159.5 behavior.mp4
515 KB View Download
►

Sign in to add a comment